[GitHub] spark pull request: [SPARK-2299] Consolidate various stageIdTo* ha...

2014-07-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/1262 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-2299] Consolidate various stageIdTo* ha...

2014-07-17 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/1262#issuecomment-49387996 Merging in master. Thanks for reviewing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-2299] Consolidate various stageIdTo* ha...

2014-07-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1262#issuecomment-49387905 QA results for PR 1262:- This patch PASSES unit tests.- This patch merges cleanly- This patch adds no public classesFor more information see test ouptut:https://amplab.c

[GitHub] spark pull request: [SPARK-2299] Consolidate various stageIdTo* ha...

2014-07-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1262#issuecomment-49382662 QA tests have started for PR 1262. This patch merges cleanly. View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16795/consoleFull --- If

[GitHub] spark pull request: [SPARK-2299] Consolidate various stageIdTo* ha...

2014-07-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1262#issuecomment-49271814 QA results for PR 1262:- This patch PASSES unit tests.- This patch merges cleanly- This patch adds no public classesFor more information see test ouptut:https://amplab.c

[GitHub] spark pull request: [SPARK-2299] Consolidate various stageIdTo* ha...

2014-07-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1262#issuecomment-49264275 QA tests have started for PR 1262. This patch merges cleanly. View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16768/consoleFull --- If

[GitHub] spark pull request: [SPARK-2299] Consolidate various stageIdTo* ha...

2014-07-16 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/1262#issuecomment-49263949 I pushed a new version. I'd first merge this and then have a separate PR to index the hash table by stageId + attempt. Now it includes @kayousterhout's change. Plea

[GitHub] spark pull request: [SPARK-2299] Consolidate various stageIdTo* ha...

2014-07-16 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/1262#issuecomment-49228272 Yeah I think @rxin is going to change this so that we index on both the stage and attempt. Also, we'll need to extend the listener interface to give both the attempt and

[GitHub] spark pull request: [SPARK-2299] Consolidate various stageIdTo* ha...

2014-07-11 Thread tsudukim
Github user tsudukim commented on the pull request: https://github.com/apache/spark/pull/1262#issuecomment-48798261 Should we have only "stageId" as key of these HashMap? Related to SPARK-2298 at JIRA, I think both stage and attemptId should be included into key in order to discrim

[GitHub] spark pull request: [SPARK-2299] Consolidate various stageIdTo* ha...

2014-07-07 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/1262#discussion_r14612611 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StageTable.scala --- @@ -99,13 +99,14 @@ private[ui] class StageTableBase( {s.details}

[GitHub] spark pull request: [SPARK-2299] Consolidate various stageIdTo* ha...

2014-07-07 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/1262#discussion_r14611517 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/JobProgressListener.scala --- @@ -51,19 +52,8 @@ class JobProgressListener(conf: SparkConf) extends

[GitHub] spark pull request: [SPARK-2299] Consolidate various stageIdTo* ha...

2014-07-07 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/1262#discussion_r14612414 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StageTable.scala --- @@ -99,13 +99,14 @@ private[ui] class StageTableBase( {s.details}

[GitHub] spark pull request: [SPARK-2299] Consolidate various stageIdTo* ha...

2014-07-07 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/1262#discussion_r14611888 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala --- @@ -34,8 +35,9 @@ private[ui] class StagePage(parent: JobProgressTab) extends We

[GitHub] spark pull request: [SPARK-2299] Consolidate various stageIdTo* ha...

2014-07-07 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/1262#discussion_r14612320 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala --- @@ -67,28 +61,28 @@ private[ui] class StagePage(parent: JobProgressTab) extends

[GitHub] spark pull request: [SPARK-2299] Consolidate various stageIdTo* ha...

2014-07-07 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/1262#discussion_r14611170 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/JobProgressListener.scala --- @@ -75,8 +65,13 @@ class JobProgressListener(conf: SparkConf) extends

[GitHub] spark pull request: [SPARK-2299] Consolidate various stageIdTo* ha...

2014-07-07 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/1262#discussion_r14611289 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/JobProgressListener.scala --- @@ -117,26 +99,27 @@ class JobProgressListener(conf: SparkConf) extend

[GitHub] spark pull request: [SPARK-2299] Consolidate various stageIdTo* ha...

2014-07-07 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/1262#discussion_r14611265 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/JobProgressListener.scala --- @@ -75,8 +65,13 @@ class JobProgressListener(conf: SparkConf) extends

[GitHub] spark pull request: [SPARK-2299] Consolidate various stageIdTo* ha...

2014-07-07 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/1262#discussion_r14611078 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/JobProgressListener.scala --- @@ -75,8 +65,13 @@ class JobProgressListener(conf: SparkConf) extends

[GitHub] spark pull request: [SPARK-2299] Consolidate various stageIdTo* ha...

2014-07-07 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/1262#discussion_r14610935 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/JobProgressListener.scala --- @@ -75,8 +65,13 @@ class JobProgressListener(conf: SparkConf) extends

[GitHub] spark pull request: [SPARK-2299] Consolidate various stageIdTo* ha...

2014-07-07 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/1262#discussion_r14610513 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/ExecutorTable.scala --- @@ -17,6 +17,8 @@ package org.apache.spark.ui.jobs +imp

[GitHub] spark pull request: [SPARK-2299] Consolidate various stageIdTo* ha...

2014-06-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1262#issuecomment-47449640 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16240/ --- If your project

[GitHub] spark pull request: [SPARK-2299] Consolidate various stageIdTo* ha...

2014-06-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1262#issuecomment-47449638 Merged build finished. All automated tests passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

[GitHub] spark pull request: [SPARK-2299] Consolidate various stageIdTo* ha...

2014-06-29 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/1262#discussion_r14328143 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala --- @@ -67,28 +61,28 @@ private[ui] class StagePage(parent: JobProgressTab) extends WebUIP

[GitHub] spark pull request: [SPARK-2299] Consolidate various stageIdTo* ha...

2014-06-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1262#issuecomment-47448815 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-2299] Consolidate various stageIdTo* ha...

2014-06-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1262#issuecomment-47448820 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-2299] Consolidate various stageIdTo* ha...

2014-06-29 Thread rxin
GitHub user rxin opened a pull request: https://github.com/apache/spark/pull/1262 [SPARK-2299] Consolidate various stageIdTo* hash maps in JobProgressListener This should reduce memory usage for the web ui as well as slightly increase its speed in draining the UI event queue. You