Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/2055
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/2055#issuecomment-93576897
Yeah, end users could turn on debug logging for this logger if needed. I
could be turned up later to info by default if desired.
---
If your project is set up for it, you
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/2055#issuecomment-93491191
My only concern with logging at debug is that this will mask unexpected
events in most cases. However, given that this is strictly more informative
than before and we
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2055#issuecomment-93430020
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2055#issuecomment-93429979
[Test build #30341 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30341/consoleFull)
for PR 2055 at commit
[`f61d9e6`](https://gith
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/2055#issuecomment-93385407
Cool, unless anyone pops up to object, I'll merge tomorrow.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2055#issuecomment-93382437
[Test build #30341 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30341/consoleFull)
for PR 2055 at commit
[`f61d9e6`](https://githu
Github user isaias commented on the pull request:
https://github.com/apache/spark/pull/2055#issuecomment-93381091
@srowen done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
ena
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/2055#issuecomment-93369197
@isaias can you make the change here? let's use debug logging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
Github user isaias commented on a diff in the pull request:
https://github.com/apache/spark/pull/2055#discussion_r25069002
--- Diff: core/src/main/scala/org/apache/spark/util/ActorLogReceive.scala
---
@@ -43,7 +43,13 @@ private[spark] trait ActorLogReceive {
private
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/2055#discussion_r25068858
--- Diff: core/src/main/scala/org/apache/spark/util/ActorLogReceive.scala
---
@@ -43,7 +43,13 @@ private[spark] trait ActorLogReceive {
private
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2055#issuecomment-75167184
[Test build #27751 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27751/consoleFull)
for PR 2055 at commit
[`f341777`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2055#issuecomment-75167190
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2055#issuecomment-75157852
[Test build #27751 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27751/consoleFull)
for PR 2055 at commit
[`f341777`](https://githu
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/2055#issuecomment-75157654
@isaias I think logging these messages are fine, but as @ScrapCodes
indicated it will be fairly noisy for random dis/association events. I agree
that having something
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/2055#issuecomment-75157332
ok to test...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featur
Github user ScrapCodes commented on the pull request:
https://github.com/apache/spark/pull/2055#issuecomment-54776785
@pwendell This patch will lead to logging of messages like
```
14/09/08 10:23:39.639 WARN AppClient$ClientActor: Received unexpected actor
system event: Associa
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/2055#issuecomment-54775749
@ScrapCodes do you have a verdict one way or the other on this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2055#issuecomment-54694438
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user isaias commented on the pull request:
https://github.com/apache/spark/pull/2055#issuecomment-53256206
Hi @ScrapCodes,
I am starting to contribute with Spark and knowing the source
code/structure now, but I think that the use of Actor are limited to internal
develo
Github user isaias commented on the pull request:
https://github.com/apache/spark/pull/2055#issuecomment-52752384
After send the PR I realized that I could have written some tests based on
underlyingActor and isDefinedAt, if is valuable I can do it.
BR
---
If your project is
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2055#issuecomment-52748507
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
GitHub user isaias opened a pull request:
https://github.com/apache/spark/pull/2055
[SPARK-2312] Logging Unhandled messages
The previous solution has changed based on
https://github.com/apache/spark/pull/2048 discussions.
You can merge this pull request into a Git repository by ru
Github user isaias commented on the pull request:
https://github.com/apache/spark/pull/2048#issuecomment-52745159
Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled a
Github user isaias closed the pull request at:
https://github.com/apache/spark/pull/2048
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/2048#issuecomment-52745114
Sure.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user isaias commented on the pull request:
https://github.com/apache/spark/pull/2048#issuecomment-52744357
@rxin Very nice, it works. Should be better to close this PR and send
another just with the trait changes?
BR
---
If your project is set up for it, you can reply
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/2048#issuecomment-52742926
You just need to change
```scala
override def isDefinedAt(o: Any): Boolean =
_receiveWithLogging.isDefinedAt(o)
```
to
```scala
override def
Github user isaias commented on the pull request:
https://github.com/apache/spark/pull/2048#issuecomment-52742677
@rxin, the trait ActorLogReceive gets the concrete implementation through
receiveWithLogging function overriding of implementing Actor and applying it,
so I think that on
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/2048#issuecomment-52736175
Why don't we just change ActorLogReceive to log messages not defined in the
partial function?
---
If your project is set up for it, you can reply to this email and have you
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2048#issuecomment-52720190
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
GitHub user isaias opened a pull request:
https://github.com/apache/spark/pull/2048
[SPARK-2312] Logging Unhandled messages
Note about tests: The best way to write tests for Log is use the
TestEventListener and EventFilter of Akka, but the current Actors aren't using
default ActorL
32 matches
Mail list logo
