Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/1314#issuecomment-48281532
You can exclude the licensing check by editing .rat-excludes file.
One thing I'm not sure about is whether it is worth it to introduce jquery
and other library just
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/1314#issuecomment-48281747
@rxin what if we merged this as-is and then we create a starter jira to
write a small library for doing tooltips and remove jquery? I think
@kayousterhout probably
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/1314#issuecomment-48282767
Definitely we can merge this first. I can submit a PR later to remove
jquery.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/1314#issuecomment-48369019
In the long run, if we decide to introduce visualization to our UI (e.g. of
execution times) we may use another library, possibly on top of jquery. It's
not clear to
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/1314#issuecomment-48373784
Hi @andrewor14
We would need to at least keep a local fallback of the jquery even if we
use a CDN version because a lot of production Spark deployments don't
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1314#issuecomment-48387408
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1314#issuecomment-48387423
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1314#issuecomment-48388712
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16417/
---
If your project is set up for it, you can
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1314#issuecomment-48388710
Merged build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user kayousterhout commented on the pull request:
https://github.com/apache/spark/pull/1314#issuecomment-48389063
Jenkins, retest this please
On Tue, Jul 8, 2014 at 12:31 PM, UCB AMPLab notificati...@github.com
wrote:
Merged build finished.
Github user kayousterhout commented on the pull request:
https://github.com/apache/spark/pull/1314#issuecomment-48395433
Jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1314#issuecomment-48395752
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1314#issuecomment-48395756
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1314#issuecomment-48402305
Merged build finished. All automated tests passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1314#issuecomment-48402309
All automated tests passed.
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16424/
---
If your
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/1314#issuecomment-48432789
Merging this in master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/1314
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user kayousterhout opened a pull request:
https://github.com/apache/spark/pull/1314
[SPARK-2384] Add tooltips to UI.
This patch adds tooltips to clarify some points of confusion in the UI.
When users mouse over some of the table headers (shuffle read, write, and input
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1314#issuecomment-48144930
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1314#issuecomment-48144921
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1314#issuecomment-48145003
Merged build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/1314#issuecomment-48145125
Awesome. I've been wanting to do this for a long time!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/1314#discussion_r14609276
--- Diff: core/src/main/scala/org/apache/spark/ui/UIUtils.scala ---
@@ -139,6 +140,17 @@ private[spark] object UIUtils extends Logging {
def
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/1314#discussion_r14609615
--- Diff: core/src/main/scala/org/apache/spark/ui/exec/ExecutorsPage.scala
---
@@ -36,8 +52,41 @@ private[ui] class ExecutorsPage(parent: ExecutorsTab)
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/1314#discussion_r14609688
--- Diff: core/src/main/scala/org/apache/spark/ui/ToolTips.scala ---
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/1314#discussion_r14609695
--- Diff: core/src/main/scala/org/apache/spark/ui/exec/ExecutorsPage.scala
---
@@ -36,8 +52,41 @@ private[ui] class ExecutorsPage(parent: ExecutorsTab)
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/1314#discussion_r14623004
--- Diff: core/src/main/scala/org/apache/spark/ui/exec/ExecutorsPage.scala
---
@@ -22,9 +22,25 @@ import javax.servlet.http.HttpServletRequest
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/1314#discussion_r14623050
--- Diff: core/src/main/scala/org/apache/spark/ui/UIUtils.scala ---
@@ -139,6 +140,17 @@ private[spark] object UIUtils extends Logging {
Github user kayousterhout commented on the pull request:
https://github.com/apache/spark/pull/1314#issuecomment-48243714
Thanks for the review @andrewor14 -- uploaded a commit addressing your
comments!
The Jenkins build is failing because the jquery file doesn't have a
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1314#issuecomment-48243892
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1314#issuecomment-48243906
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1314#issuecomment-48244067
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16387/
---
If your project is set up for it, you can
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1314#issuecomment-48244066
Merged build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
33 matches
Mail list logo
