Github user mridulm commented on the pull request:
https://github.com/apache/spark/pull/1327#issuecomment-48571146
The reason to initialize size upfront and keep it immutable is to enforce
constraints on the writer since it is lazily initialized.
On Jul 10, 2014 10:29 AM, "Saisa
Github user aarondav commented on the pull request:
https://github.com/apache/spark/pull/1327#issuecomment-48569260
Agreed, I'd be fine merging this one as-is.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proje
Github user jerryshao commented on the pull request:
https://github.com/apache/spark/pull/1327#issuecomment-48565390
IMHO, if we leave reuse of this object aside, I don't think this change
will bring specific effect to the current code path. If we really want to
defend the reuse of th
Github user aarondav commented on the pull request:
https://github.com/apache/spark/pull/1327#issuecomment-48560796
Honestly, I like this change, because it's generally good practice to
minimize the amount of work done inside constructors. We should consider making
it as part of the s
Github user jerryshao closed the pull request at:
https://github.com/apache/spark/pull/1327
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is e
Github user jerryshao commented on the pull request:
https://github.com/apache/spark/pull/1327#issuecomment-48553246
Ok, sorry for my unthoughtful PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user mridulm commented on the pull request:
https://github.com/apache/spark/pull/1327#issuecomment-48504833
As @aarondav mentions, this class has never been 're-used'.
As part of our shuffle consolidation fixes, we actually depend on this
behavior (and enforce it via a close
Github user aarondav commented on the pull request:
https://github.com/apache/spark/pull/1327#issuecomment-48367468
This class has historically been "almost-reusable", but since there was
never any need to actually reuse it within Spark itself, the effort wasn't
completed. I'm not sur
Github user jerryshao commented on the pull request:
https://github.com/apache/spark/pull/1327#issuecomment-48329176
It is alright if this class is not reopen supported, but seems there is not
obvious fence to defend user to reuse this object, so at least this
modification will not le
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1327#issuecomment-48301683
Merged build finished. All automated tests passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1327#issuecomment-48301689
All automated tests passed.
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16403/
---
If your project
Github user mridulm commented on the pull request:
https://github.com/apache/spark/pull/1327#issuecomment-48295927
This is incorrect. It is used to find the length of the file when created :
not when initialized.
There is not reopen supported in this class btw.
---
If your p
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1327#issuecomment-48289657
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1327#issuecomment-48289644
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
GitHub user jerryshao opened a pull request:
https://github.com/apache/spark/pull/1327
[SPARK-2402] Update the initial position when reuse DiskBlockObjectWriter
Minor fix, `initialPosition` can not be updated after `close()` and
re`open()`, which will lead to error when reusing this
15 matches
Mail list logo
