Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/1349#issuecomment-49271133
Thanks Andrew, looks good!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/1349
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1349#issuecomment-48684502
QA tests have started for PR 1349. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16539/consoleFull
---
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/1349#issuecomment-48684552
As of this comment, I have tested these changes in local, standalone and
yarn modes, running with additional python files and jars and various configs,
and everything
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1349#issuecomment-48684793
QA tests have started for PR 1349. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16541/consoleFull
---
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1349#issuecomment-48689317
QA results for PR 1349:br- This patch PASSES unit tests.br- This patch
merges cleanlybr- This patch adds the following public classes
(experimental):br* (4)
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1349#issuecomment-48689557
QA results for PR 1349:br- This patch PASSES unit tests.br- This patch
merges cleanlybr- This patch adds the following public classes
(experimental):br* (4)
GitHub user andrewor14 opened a pull request:
https://github.com/apache/spark/pull/1349
[SPARK-2423] Clean up SparkSubmit for readability
It is currently non-trivial to trace through how different combinations of
cluster managers (e.g. yarn) and deploy modes (e.g. cluster) are
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1349#issuecomment-48542838
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1349#issuecomment-48542823
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/1349#discussion_r14742342
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -27,25 +27,39 @@ import org.apache.spark.executor.ExecutorURLClassLoader
Github user sryza commented on the pull request:
https://github.com/apache/spark/pull/1349#issuecomment-48547918
These changes seem reasonable to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1349#issuecomment-48549408
All automated tests passed.
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16483/
---
If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1349#issuecomment-48549405
Merged build finished. All automated tests passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/1349#discussion_r14746068
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -27,25 +27,39 @@ import org.apache.spark.executor.ExecutorURLClassLoader
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/1349#issuecomment-48556023
An important goal of this PR is to keep the functionality the same. I have
reviewed my own changes closely to verify that the logic is preserved, but it
would be best
16 matches
Mail list logo
