Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/929#issuecomment-50579245
QA results for PR 929:br- This patch PASSES unit tests.br- This patch
merges cleanlybr- This patch adds no public classesbrbrFor more
information see test
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/929#issuecomment-50654846
Merged into master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/929
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/929#issuecomment-50484656
QA tests have started for PR 929. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17358/consoleFull
---
Github user witgo commented on the pull request:
https://github.com/apache/spark/pull/929#issuecomment-50492147
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/929#issuecomment-50492523
QA tests have started for PR 929. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17359/consoleFull
---
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/929#issuecomment-50491613
QA results for PR 929:br- This patch FAILED unit tests.br- This patch
merges cleanlybr- This patch adds no public classesbrbrFor more
information see test
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/929#discussion_r15533428
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/recommendation/ALS.scala ---
@@ -255,6 +260,9 @@ class ALS private (
rank, lambda, alpha,
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/929#issuecomment-50499597
QA results for PR 929:br- This patch PASSES unit tests.br- This patch
merges cleanlybr- This patch adds no public classesbrbrFor more
information see test
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/929#issuecomment-50500525
QA tests have started for PR 929. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17362/consoleFull
---
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/929#discussion_r15534935
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/recommendation/ALS.scala ---
@@ -255,6 +255,9 @@ class ALS private (
rank, lambda, alpha,
Github user witgo commented on the pull request:
https://github.com/apache/spark/pull/929#issuecomment-50503214
@mengxr Done. Tomorrow, I will test in detail.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/929#issuecomment-50506986
QA results for PR 929:br- This patch PASSES unit tests.br- This patch
merges cleanlybr- This patch adds no public classesbrbrFor more
information see test
Github user witgo commented on a diff in the pull request:
https://github.com/apache/spark/pull/929#discussion_r15566577
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/recommendation/ALS.scala ---
@@ -255,6 +255,9 @@ class ALS private (
rank, lambda, alpha,
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/929#discussion_r15566629
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/recommendation/ALS.scala ---
@@ -255,6 +255,9 @@ class ALS private (
rank, lambda, alpha,
Github user witgo commented on a diff in the pull request:
https://github.com/apache/spark/pull/929#discussion_r15566754
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/recommendation/ALS.scala ---
@@ -255,6 +255,9 @@ class ALS private (
rank, lambda, alpha,
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/929#issuecomment-50574626
LGTM. Waiting for Jenkins. Btw, @witgo if you have a big dataset to test,
could you try to set the storage level of ratings and user/product in/out links
to
Github user witgo commented on the pull request:
https://github.com/apache/spark/pull/929#issuecomment-50574926
Ok, I will try it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/929#issuecomment-50575931
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/929#issuecomment-50576082
QA tests have started for PR 929. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17422/consoleFull
---
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/929#issuecomment-50380948
@witgo We don't need to checkpoint both users and products, but only the
smaller one. For the initial version, it is fine to checkpoint either of them.
We should also do
21 matches
Mail list logo
