[GitHub] spark pull request: [SPARK-2554][SQL] Supporting SumDistinct parti...

2014-12-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/3348 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-2554][SQL] Supporting SumDistinct parti...

2014-12-18 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/3348#issuecomment-67596915 Thanks! Merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-2554][SQL] Supporting SumDistinct parti...

2014-12-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3348#issuecomment-67474674 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24

[GitHub] spark pull request: [SPARK-2554][SQL] Supporting SumDistinct parti...

2014-12-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3348#issuecomment-67474669 [Test build #24588 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24588/consoleFull) for PR 3348 at commit [`fd28e4d`](https://gith

[GitHub] spark pull request: [SPARK-2554][SQL] Supporting SumDistinct parti...

2014-12-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3348#issuecomment-67467429 [Test build #24588 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24588/consoleFull) for PR 3348 at commit [`fd28e4d`](https://githu

[GitHub] spark pull request: [SPARK-2554][SQL] Supporting SumDistinct parti...

2014-12-17 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/3348#issuecomment-67392120 Minor style comments otherwise LGTM. Thanks for working on this :) --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-2554][SQL] Supporting SumDistinct parti...

2014-12-17 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/3348#discussion_r22003211 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregates.scala --- @@ -360,11 +360,11 @@ case class Sum(child: Expression)

[GitHub] spark pull request: [SPARK-2554][SQL] Supporting SumDistinct parti...

2014-12-17 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/3348#discussion_r22003183 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala --- @@ -168,4 +168,9 @@ class SQLQuerySuite extends QueryTest {

[GitHub] spark pull request: [SPARK-2554][SQL] Supporting SumDistinct parti...

2014-12-05 Thread ravipesala
Github user ravipesala commented on the pull request: https://github.com/apache/spark/pull/3348#issuecomment-65766741 I have Rebased with master,Please review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] spark pull request: [SPARK-2554][SQL] Supporting SumDistinct parti...

2014-12-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3348#issuecomment-65413277 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24

[GitHub] spark pull request: [SPARK-2554][SQL] Supporting SumDistinct parti...

2014-12-03 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3348#issuecomment-65413264 [Test build #24093 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24093/consoleFull) for PR 3348 at commit [`e60e67f`](https://gith

[GitHub] spark pull request: [SPARK-2554][SQL] Supporting SumDistinct parti...

2014-12-03 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3348#issuecomment-65404728 [Test build #24093 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24093/consoleFull) for PR 3348 at commit [`e60e67f`](https://githu

[GitHub] spark pull request: [SPARK-2554][SQL] Supporting SumDistinct parti...

2014-12-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3348#issuecomment-65401376 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24

[GitHub] spark pull request: [SPARK-2554][SQL] Supporting SumDistinct parti...

2014-12-03 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3348#issuecomment-65401372 [Test build #24092 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24092/consoleFull) for PR 3348 at commit [`32fe234`](https://gith

[GitHub] spark pull request: [SPARK-2554][SQL] Supporting SumDistinct parti...

2014-12-03 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3348#issuecomment-65400232 [Test build #24092 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24092/consoleFull) for PR 3348 at commit [`32fe234`](https://githu

[GitHub] spark pull request: [SPARK-2554][SQL] Supporting SumDistinct parti...

2014-12-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3348#issuecomment-65172953 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24

[GitHub] spark pull request: [SPARK-2554][SQL] Supporting SumDistinct parti...

2014-12-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3348#issuecomment-65172947 [Test build #24007 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24007/consoleFull) for PR 3348 at commit [`4a31ca7`](https://gith

[GitHub] spark pull request: [SPARK-2554][SQL] Supporting SumDistinct parti...

2014-12-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3348#issuecomment-65163386 [Test build #24007 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24007/consoleFull) for PR 3348 at commit [`4a31ca7`](https://githu

[GitHub] spark pull request: [SPARK-2554][SQL] Supporting SumDistinct parti...

2014-12-01 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/3348#issuecomment-65163018 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] spark pull request: [SPARK-2554][SQL] Supporting SumDistinct parti...

2014-11-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3348#issuecomment-63545561 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] spark pull request: [SPARK-2554][SQL] Supporting SumDistinct parti...

2014-11-18 Thread ravipesala
GitHub user ravipesala opened a pull request: https://github.com/apache/spark/pull/3348 [SPARK-2554][SQL] Supporting SumDistinct partial aggregation Adding support to the partial aggregation of SumDistinct You can merge this pull request into a Git repository by running: $ git