GitHub user dorx opened a pull request:
https://github.com/apache/spark/pull/1710
[SPARK-2782][mllib] Bug fix for getRanks in SpearmanCorrelation
getRanks computes the wrong rank when numPartition = size in the input
RDDs before this patch. added units to address this bug.
You can
Github user dorx commented on the pull request:
https://github.com/apache/spark/pull/1710#issuecomment-50845017
@mengxr I'd really appreciate it if we can get this merged ASAP so I can
send out my python correlation PR before the code freeze. Thanks!
---
If your project is set up
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/1710#issuecomment-50845244
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1710#issuecomment-50845388
QA tests have started for PR 1710. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17635/consoleFull
---
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/1710#discussion_r15681269
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/stat/Statistics.scala
---
@@ -55,20 +55,24 @@ object Statistics {
/**
* Compute the
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/1710#discussion_r15681299
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/stat/correlation/SpearmanCorrelation.scala
---
@@ -89,20 +89,17 @@ private[stat] object
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/1710#discussion_r15681334
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/stat/correlation/SpearmanCorrelation.scala
---
@@ -89,20 +89,17 @@ private[stat] object
Github user dorx commented on a diff in the pull request:
https://github.com/apache/spark/pull/1710#discussion_r15681388
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/stat/correlation/SpearmanCorrelation.scala
---
@@ -89,20 +89,17 @@ private[stat] object
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1710#issuecomment-50847511
QA results for PR 1710:br- This patch PASSES unit tests.br- This patch
merges cleanlybr- This patch adds no public classesbrbrFor more
information see test
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/1710#issuecomment-50847713
LGTM. Merged into master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1710#issuecomment-50848506
QA results for PR 1710:br- This patch PASSES unit tests.br- This patch
merges cleanlybr- This patch adds no public classesbrbrFor more
information see test
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/1710
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
12 matches
Mail list logo
