[GitHub] spark pull request: [SPARK-2852][MLLIB] Separate model from IDF/St...

2014-08-07 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/1814#discussion_r15920590 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/feature/StandardScaler.scala --- @@ -35,38 +35,47 @@ import org.apache.spark.rdd.RDD * @param

[GitHub] spark pull request: [SPARK-2852][MLLIB] Separate model from IDF/St...

2014-08-07 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/1814#discussion_r15920592 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/feature/StandardScaler.scala --- @@ -35,38 +35,47 @@ import org.apache.spark.rdd.RDD * @param

[GitHub] spark pull request: [SPARK-2852][MLLIB] Separate model from IDF/St...

2014-08-07 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/1814#discussion_r15920617 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/feature/IDF.scala --- @@ -177,18 +115,72 @@ private object IDF { private def isEmpty: Boolean =

[GitHub] spark pull request: [SPARK-2852][MLLIB] Separate model from IDF/St...

2014-08-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1814#issuecomment-51438966 QA tests have started for PR 1814. This patch merges cleanly. brView progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18111/consoleFull ---

[GitHub] spark pull request: [SPARK-2852][MLLIB] Separate model from IDF/St...

2014-08-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1814#issuecomment-51442882 QA results for PR 1814:br- This patch PASSES unit tests.br- This patch merges cleanlybr- This patch adds the following public classes (experimental):brclass

[GitHub] spark pull request: [SPARK-2852][MLLIB] Separate model from IDF/St...

2014-08-07 Thread dbtsai
Github user dbtsai commented on the pull request: https://github.com/apache/spark/pull/1814#issuecomment-51511617 LGTM. Merged into both master and branch-1.1. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-2852][MLLIB] Separate model from IDF/St...

2014-08-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/1814 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-2852][MLLIB] Separate model from IDF/St...

2014-08-06 Thread mengxr
GitHub user mengxr opened a pull request: https://github.com/apache/spark/pull/1814 [SPARK-2852][MLLIB] Separate model from IDF/StandardScaler algorithms This is part of SPARK-2828: 1. separate IDF model from IDF algorithm (which generates a model) 2. separate

[GitHub] spark pull request: [SPARK-2852][MLLIB] Separate model from IDF/St...

2014-08-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1814#issuecomment-51405165 QA tests have started for PR 1814. This patch merges cleanly. brView progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18063/consoleFull ---

[GitHub] spark pull request: [SPARK-2852][MLLIB] Separate model from IDF/St...

2014-08-06 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/1814#discussion_r15908219 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/feature/StandardScaler.scala --- @@ -35,38 +35,47 @@ import org.apache.spark.rdd.RDD * @param

[GitHub] spark pull request: [SPARK-2852][MLLIB] Separate model from IDF/St...

2014-08-06 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/1814#discussion_r15908318 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/feature/StandardScaler.scala --- @@ -35,38 +35,47 @@ import org.apache.spark.rdd.RDD * @param

[GitHub] spark pull request: [SPARK-2852][MLLIB] Separate model from IDF/St...

2014-08-06 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/1814#discussion_r15908504 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/feature/IDF.scala --- @@ -177,18 +115,72 @@ private object IDF { private def isEmpty: Boolean =

[GitHub] spark pull request: [SPARK-2852][MLLIB] Separate model from IDF/St...

2014-08-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1814#issuecomment-51409813 QA results for PR 1814:br- This patch PASSES unit tests.br- This patch merges cleanlybr- This patch adds the following public classes (experimental):brclass