Github user roji commented on the pull request:
https://github.com/apache/spark/pull/1875#issuecomment-65195595
Sorry for dropping out, was involved in other things. @mateiz, I'll take a
look at your suggestions in the coming week.
---
If your project is set up for it, you can reply
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/1875#issuecomment-65169491
Any update here? I think this would be a great feature to have, but
perhaps we should close this issue until it is ready to review (to make the
size of the PR queue a l
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1875#issuecomment-54694487
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/1875#issuecomment-53638130
Actually I notice that there's code for this in our `sbt/sbt` script,
though it may be specific for finding directories. Take a look at that.
---
If your project is set u
Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/1875#issuecomment-53634025
It would be nice if you found some best practice way of doing this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/1875#issuecomment-53633816
Actually I spoke too soon, this fix doesn't seem to work with symlinks to
relative paths. You can do
```
cd spark
ln -s bin/spark-shell spark-shell
```
Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/1875#issuecomment-53633364
Hey @roji, actually I looked at this and I notice that `-h` on the `[`
command is deprecated and replaced by `-L`. Mind changing that in the code?
Otherwise it looks good.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1875#issuecomment-53630144
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19315/consoleFull)
for PR 1875 at commit
[`ccbc6e5`](https://github.com/a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1875#issuecomment-53618994
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19315/consoleFull)
for PR 1875 at commit
[`ccbc6e5`](https://github.com/ap
Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/1875#issuecomment-53618008
Jenkins, test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user roji commented on the pull request:
https://github.com/apache/spark/pull/1875#issuecomment-53570312
Rebased on master and squashed to a single commit, hope all is well now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/1875#issuecomment-53299005
Yes, your patch no longer merges on master. Please rebase it onto the
master branch.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user roji commented on the pull request:
https://github.com/apache/spark/pull/1875#issuecomment-53233815
Um, am not sure, did something actually go wrong here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If you
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1875#issuecomment-5203
QA results for PR 1875:- This patch FAILED unit tests.For more
information see test
ouptut:https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18953/consol
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1875#issuecomment-52777692
QA tests have started for PR 1875. This patch DID NOT merge cleanly!
View progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18953/consoleFull
Github user roji commented on the pull request:
https://github.com/apache/spark/pull/1875#issuecomment-52777250
@mateiz, added a commit for the sbin scripts.
In general the scripts could use a bit of cleanup - the bin and sbin
scripts work a bit differently, the sbin-specific
Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/1875#issuecomment-52083943
Yup, please fix those too. I think this is useful to have.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user roji commented on the pull request:
https://github.com/apache/spark/pull/1875#issuecomment-51799530
Have just noticed the additional scripts under sbin, which also require
treatment. Just before I go ahead and work on that, can you confirm this is a
desirable PR?
---
If
Github user roji commented on the pull request:
https://github.com/apache/spark/pull/1875#issuecomment-51736839
@mateiz, thanks for the attention. Have opened an issue for this.
May I suggest you guys update the contribution guide to specify that an
issue be opened alongside p
19 matches
Mail list logo
