[GitHub] spark pull request: [SPARK-2980][mllib] testing the Chi-squared hy...

2014-12-15 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/3679#issuecomment-67093985 @jbencook I think that JIRA was supposed to be closed; I'll fix that. But adding some Python tests will be good---I'll take a look! Btw, the link for

[GitHub] spark pull request: [SPARK-2980][mllib] testing the Chi-squared hy...

2014-12-15 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/3679#issuecomment-67094622 I made a new JIRA for the unit tests. Could you please swap the JIRA tag for this one? [https://issues.apache.org/jira/browse/SPARK-4855] Thanks! --- If your

[GitHub] spark pull request: [SPARK-2980][mllib] testing the Chi-squared hy...

2014-12-15 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/3679#issuecomment-67095129 I would recommend not testing for invalid input in stat.py as long as it is tested on the Scala side in ChiSqTest.scala. It will be faster to only test once, and it

[GitHub] spark pull request: [SPARK-2980][mllib] testing the Chi-squared hy...

2014-12-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3679#issuecomment-67096627 [Test build #546 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/546/consoleFull) for PR 3679 at commit

[GitHub] spark pull request: [SPARK-2980][mllib] testing the Chi-squared hy...

2014-12-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3679#issuecomment-67103266 [Test build #546 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/546/consoleFull) for PR 3679 at commit

[GitHub] spark pull request: [SPARK-2980][mllib] testing the Chi-squared hy...

2014-12-11 Thread jbencook
GitHub user jbencook opened a pull request: https://github.com/apache/spark/pull/3679 [SPARK-2980][mllib] testing the Chi-squared hypothesis test This PR tests the pyspark Chi-squared hypothesis test from this commit: c8abddc5164d8cf11cdede6ab3d5d1ea08028708 and moves some of the

[GitHub] spark pull request: [SPARK-2980][mllib] testing the Chi-squared hy...

2014-12-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3679#issuecomment-66639796 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your