Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/1958#issuecomment-53011746
I have backported this to branch-1.1. However @pwendell still found some
other mysterious issues with SparkSinkSuite that broke the maven build, so
he deleted sparkSin
Github user harishreedharan commented on the pull request:
https://github.com/apache/spark/pull/1958#issuecomment-52954913
I believe the commit which added the `getPort()` method had merge conflicts
in the 1.1 branch, which is why @tdas did not backport it. We can probably
backport al
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/1958#issuecomment-52917580
I see @pwendell temporarily removed the test:
https://github.com/apache/spark/commit/1d5e84a99076d3e0168dd2f4626c7911e7ba49e7#diff-d41d8cd98f00b204e9800998ecf8427e
Github user harishreedharan commented on the pull request:
https://github.com/apache/spark/pull/1958#issuecomment-52810248
Correct. This patch uses a method which was introduced in that one.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/1958#issuecomment-52791480
@tdas @harishreedharan This is causing yarn builds to fail on branch-1.1.
I think you are missing commit:
https://github.com/apache/spark/commit/95470a03ae85d7
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/1958
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/1958#issuecomment-52761646
Alright, I am merging this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1958#issuecomment-52745587
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18930/consoleFull)
for PR 1958 at commit
[`e3110b9`](https://github.com/a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1958#issuecomment-52741251
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18930/consoleFull)
for PR 1958 at commit
[`e3110b9`](https://github.com/ap
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/1958#issuecomment-52740904
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1958#issuecomment-52740385
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18927/consoleFull)
for PR 1958 at commit
[`e3110b9`](https://github.com/a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1958#issuecomment-52737616
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18927/consoleFull)
for PR 1958 at commit
[`e3110b9`](https://github.com/ap
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/1958#issuecomment-52737388
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user harishreedharan commented on the pull request:
https://github.com/apache/spark/pull/1958#issuecomment-52731129
Could not find Apache license headers in the following files:
!?
/home/jenkins/workspace/SparkPullRequestBuilder/mllib/checkpoint/.temp.crc
!?
/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1958#issuecomment-52731023
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18916/consoleFull)
for PR 1958 at commit
[`e3110b9`](https://github.com/a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1958#issuecomment-52731014
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18916/consoleFull)
for PR 1958 at commit
[`e3110b9`](https://github.com/ap
Github user harishreedharan commented on the pull request:
https://github.com/apache/spark/pull/1958#issuecomment-52730742
Jenkins, test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user harishreedharan commented on the pull request:
https://github.com/apache/spark/pull/1958#issuecomment-52713686
Jenkins, test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/1958#issuecomment-52710518
Jenkins, test this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featur
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1958#issuecomment-52710115
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18878/consoleFull)
for PR 1958 at commit
[`e3110b9`](https://github.com/a
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/1958#issuecomment-52709005
Right, good. But I want to run it another couple of times to test its
flakiness.
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user harishreedharan commented on the pull request:
https://github.com/apache/spark/pull/1958#issuecomment-52708814
Looks like the tests have passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1958#discussion_r16448274
--- Diff:
external/flume-sink/src/test/scala/org/apache/spark/streaming/flume/sink/SparkSinkSuite.scala
---
@@ -0,0 +1,204 @@
+/*
+ * Licensed to the Ap
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/1958#issuecomment-52708133
Yeah, that sleep might be sufficient.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1958#issuecomment-52703193
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18878/consoleFull)
for PR 1958 at commit
[`e3110b9`](https://github.com/ap
Github user harishreedharan commented on the pull request:
https://github.com/apache/spark/pull/1958#issuecomment-52702892
Jenkins, test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user harishreedharan commented on the pull request:
https://github.com/apache/spark/pull/1958#issuecomment-52699042
Yeah, it passes locally. Seems like some flakiness. Let me debug.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/1958#issuecomment-52698714
still failing unit test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this f
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1958#issuecomment-52695066
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18865/consoleFull)
for PR 1958 at commit
[`120b81e`](https://github.com/a
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/1958#issuecomment-52689514
LGTM, will merge when tests pass.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1958#discussion_r16438954
--- Diff:
external/flume-sink/src/main/scala/org/apache/spark/streaming/flume/sink/SparkSink.scala
---
@@ -53,7 +53,6 @@ import org.apache.flume.sink.AbstractSi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1958#issuecomment-52688804
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18865/consoleFull)
for PR 1958 at commit
[`120b81e`](https://github.com/ap
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1958#discussion_r16401593
--- Diff:
external/flume-sink/src/test/scala/org/apache/spark/streaming/flume/sink/SparkSinkSuite.scala
---
@@ -0,0 +1,206 @@
+/*
+ * Licensed to the Ap
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1958#discussion_r16401354
--- Diff:
external/flume-sink/src/test/scala/org/apache/spark/streaming/flume/sink/SparkSinkSuite.scala
---
@@ -0,0 +1,206 @@
+/*
+ * Licensed to the Ap
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1958#discussion_r16401356
--- Diff:
external/flume-sink/src/test/scala/org/apache/spark/streaming/flume/sink/SparkSinkSuite.scala
---
@@ -0,0 +1,206 @@
+/*
+ * Licensed to the Ap
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1958#discussion_r16401267
--- Diff:
external/flume-sink/src/test/scala/org/apache/spark/streaming/flume/sink/SparkSinkSuite.scala
---
@@ -0,0 +1,206 @@
+/*
+ * Licensed to the Ap
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1958#discussion_r16401236
--- Diff:
external/flume-sink/src/test/scala/org/apache/spark/streaming/flume/sink/SparkSinkSuite.scala
---
@@ -0,0 +1,206 @@
+/*
+ * Licensed to the Ap
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1958#discussion_r16401169
--- Diff:
external/flume-sink/src/test/scala/org/apache/spark/streaming/flume/sink/SparkSinkSuite.scala
---
@@ -0,0 +1,206 @@
+/*
+ * Licensed to the Ap
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1958#discussion_r16401133
--- Diff:
external/flume-sink/src/test/scala/org/apache/spark/streaming/flume/sink/SparkSinkSuite.scala
---
@@ -0,0 +1,206 @@
+/*
+ * Licensed to the Ap
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1958#discussion_r16400756
--- Diff:
external/flume-sink/src/test/scala/org/apache/spark/streaming/flume/sink/SparkSinkSuite.scala
---
@@ -0,0 +1,206 @@
+/*
+ * Licensed to the Ap
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1958#discussion_r16400682
--- Diff:
external/flume-sink/src/test/scala/org/apache/spark/streaming/flume/sink/SparkSinkSuite.scala
---
@@ -0,0 +1,206 @@
+/*
+ * Licensed to the Ap
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1958#discussion_r16400657
--- Diff:
external/flume-sink/src/test/scala/org/apache/spark/streaming/flume/sink/SparkSinkSuite.scala
---
@@ -0,0 +1,206 @@
+/*
+ * Licensed to the Ap
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1958#discussion_r16400150
--- Diff:
external/flume-sink/src/test/scala/org/apache/spark/streaming/flume/sink/SparkSinkSuite.scala
---
@@ -0,0 +1,206 @@
+/*
+ * Licensed to the Ap
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/1958#issuecomment-52597090
unit test is failing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1958#issuecomment-52566816
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18788/consoleFull)
for PR 1958 at commit
[`c9190d1`](https://github.com/a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1958#issuecomment-52562903
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18788/consoleFull)
for PR 1958 at commit
[`c9190d1`](https://github.com/ap
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1958#discussion_r16385317
--- Diff:
external/flume-sink/src/test/scala/org/apache/spark/streaming/flume/sink/SparkSinkSuite.scala
---
@@ -0,0 +1,207 @@
+/*
+ * Licensed to the Ap
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1958#discussion_r16385095
--- Diff:
external/flume-sink/src/test/scala/org/apache/spark/streaming/flume/sink/SparkSinkSuite.scala
---
@@ -0,0 +1,207 @@
+/*
+ * Licensed to the Ap
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1958#discussion_r16385030
--- Diff:
external/flume-sink/src/test/scala/org/apache/spark/streaming/flume/sink/SparkSinkSuite.scala
---
@@ -0,0 +1,207 @@
+/*
+ * Licensed to the Ap
Github user harishreedharan commented on a diff in the pull request:
https://github.com/apache/spark/pull/1958#discussion_r16384773
--- Diff:
external/flume-sink/src/main/scala/org/apache/spark/streaming/flume/sink/SparkSink.scala
---
@@ -53,7 +53,6 @@ import org.apache.flume.sink
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1958#discussion_r16384357
--- Diff:
external/flume-sink/src/test/scala/org/apache/spark/streaming/flume/sink/SparkSinkSuite.scala
---
@@ -0,0 +1,207 @@
+/*
+ * Licensed to the Ap
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1958#discussion_r16384289
--- Diff:
external/flume-sink/src/main/scala/org/apache/spark/streaming/flume/sink/SparkSink.scala
---
@@ -53,7 +53,6 @@ import org.apache.flume.sink.AbstractSi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1958#issuecomment-52532136
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18756/consoleFull)
for PR 1958 at commit
[`7fedc5a`](https://github.com/a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1958#issuecomment-52525221
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18756/consoleFull)
for PR 1958 at commit
[`7fedc5a`](https://github.com/ap
Github user harishreedharan commented on the pull request:
https://github.com/apache/spark/pull/1958#issuecomment-52376357
Jenkins, test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user harishreedharan commented on the pull request:
https://github.com/apache/spark/pull/1958#issuecomment-52374864
Same failures as before - not caused by this patch
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1958#issuecomment-52344694
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18622/consoleFull)
for PR 1958 at commit
[`7b9b649`](https://github.com/a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1958#issuecomment-52339243
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18622/consoleFull)
for PR 1958 at commit
[`7b9b649`](https://github.com/ap
Github user harishreedharan commented on the pull request:
https://github.com/apache/spark/pull/1958#issuecomment-52337867
Failure is unrelated:
[info] SparkSinkSuite:
[info] - Success test
[info] - Nack
[info] - Timeout
[info] - Multiple consumers
[info] - Multi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1958#issuecomment-52332252
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18611/consoleFull)
for PR 1958 at commit
[`f2c56c9`](https://github.com/a
Github user harishreedharan commented on the pull request:
https://github.com/apache/spark/pull/1958#issuecomment-52326820
Jenkins, test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1958#issuecomment-52327168
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18611/consoleFull)
for PR 1958 at commit
[`f2c56c9`](https://github.com/ap
Github user harishreedharan commented on a diff in the pull request:
https://github.com/apache/spark/pull/1958#discussion_r16281516
--- Diff:
external/flume-sink/src/test/scala/org/apache/spark/streaming/flume/sink/SparkSinkSuite.scala
---
@@ -0,0 +1,208 @@
+package org.apache
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1958#issuecomment-5222
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18599/consoleFull)
for PR 1958 at commit
[`f2c56c9`](https://github.com/ap
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/1958#discussion_r16280387
--- Diff:
external/flume-sink/src/test/scala/org/apache/spark/streaming/flume/sink/SparkSinkSuite.scala
---
@@ -0,0 +1,208 @@
+package org.apache.spark
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1958#issuecomment-52265221
QA results for PR 1958:- This patch PASSES unit tests.- This patch
merges cleanly- This patch adds no public classesFor more
information see test
ouptut:https://amplab.c
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1958#issuecomment-52262303
QA tests have started for PR 1958. This patch merges cleanly. View
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18583/consoleFull
---
If
GitHub user harishreedharan opened a pull request:
https://github.com/apache/spark/pull/1958
[SPARK-3054][STREAMING] Add unit tests for Spark Sink.
This patch adds unit tests for Spark Sink.
It also removes the private[flume] for Spark Sink,
since the sink is instantiate
68 matches
Mail list logo
