[GitHub] spark pull request: [SPARK-3081][MLLIB] rename RandomRDDGenerators...

2014-08-16 Thread brkyvz
Github user brkyvz commented on the pull request: https://github.com/apache/spark/pull/1979#issuecomment-52405587 It's a shorter name, and I understand the concern about the confusion. Looks good to me! --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-3081][MLLIB] rename RandomRDDGenerators...

2014-08-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/1979 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-3081][MLLIB] rename RandomRDDGenerators...

2014-08-16 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/1979#issuecomment-52407359 @brkyvz Thanks for reviewing! I've merged this into master and branch-1.1. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-3081][MLLIB] rename RandomRDDGenerators...

2014-08-15 Thread mengxr
GitHub user mengxr opened a pull request: https://github.com/apache/spark/pull/1979 [SPARK-3081][MLLIB] rename RandomRDDGenerators to RandomRDDs `RandomRDDGenerators` means factory for `RandomRDDGenerator`. However, its methods return RDDs but not RDDGenerators. So a more proper

[GitHub] spark pull request: [SPARK-3081][MLLIB] rename RandomRDDGenerators...

2014-08-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1979#issuecomment-52379195 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18654/consoleFull) for PR 1979 at commit

[GitHub] spark pull request: [SPARK-3081][MLLIB] rename RandomRDDGenerators...

2014-08-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1979#issuecomment-52380783 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18654/consoleFull) for PR 1979 at commit