[GitHub] spark pull request: [SPARK-3168]The ServletContextHandler of webui...

2015-02-24 Thread XuTingjun
Github user XuTingjun closed the pull request at: https://github.com/apache/spark/pull/2073 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] spark pull request: [SPARK-3168]The ServletContextHandler of webui...

2015-02-19 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/2073#issuecomment-75157134 @XuTingjun can you elaborate on the requirements of CAS? Are there performance costs to using a HashSessionHandler here, since it saves the session to disk periodicall

[GitHub] spark pull request: [SPARK-3168]The ServletContextHandler of webui...

2014-09-10 Thread XuTingjun
Github user XuTingjun commented on the pull request: https://github.com/apache/spark/pull/2073#issuecomment-55088380 Now Spark doesn't support SSL --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-3168]The ServletContextHandler of webui...

2014-09-09 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/2073#issuecomment-55035316 I'd be more comfortable with enabling sessions based on a config option; sessions are not needed for the built-in functionality, and they do incur overhead (aside from all

[GitHub] spark pull request: [SPARK-3168]The ServletContextHandler of webui...

2014-09-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2073#issuecomment-54694431 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] spark pull request: [SPARK-3168]The ServletContextHandler of webui...

2014-09-04 Thread tgravescs
Github user tgravescs commented on the pull request: https://github.com/apache/spark/pull/2073#issuecomment-54486981 Note that I'm assuming some of these don't necessarily apply. Like I think secure cookies can only be used over https. Looking a bit more at the api I think I am inte

[GitHub] spark pull request: [SPARK-3168]The ServletContextHandler of webui...

2014-09-03 Thread tgravescs
Github user tgravescs commented on the pull request: https://github.com/apache/spark/pull/2073#issuecomment-54399248 I'm not an expert in Sessions. My main concern would be that the config are setup properly and to be secure. For instance with the HashSessionManager does it default

[GitHub] spark pull request: [SPARK-3168]The ServletContextHandler of webui...

2014-08-27 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/2073#discussion_r16811373 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/HistoryServer.scala --- @@ -116,6 +117,8 @@ class HistoryServer( val contextHandler = new

[GitHub] spark pull request: [SPARK-3168]The ServletContextHandler of webui...

2014-08-22 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/2073#discussion_r16628946 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/HistoryServer.scala --- @@ -116,6 +117,8 @@ class HistoryServer( val contextHandler =

[GitHub] spark pull request: [SPARK-3168]The ServletContextHandler of webui...

2014-08-22 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/2073#discussion_r16628944 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/HistoryServer.scala --- @@ -28,6 +28,7 @@ import org.apache.spark.deploy.SparkHadoopUtil i

[GitHub] spark pull request: [SPARK-3168]The ServletContextHandler of webui...

2014-08-22 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/2073#discussion_r16628942 --- Diff: core/src/main/scala/org/apache/spark/ui/JettyUtils.scala --- @@ -35,6 +35,7 @@ import org.json4s.jackson.JsonMethods.{pretty, render} imp

[GitHub] spark pull request: [SPARK-3168]The ServletContextHandler of webui...

2014-08-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2073#issuecomment-52869862 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] spark pull request: [SPARK-3168]The ServletContextHandler of webui...

2014-08-20 Thread XuTingjun
GitHub user XuTingjun opened a pull request: https://github.com/apache/spark/pull/2073 [SPARK-3168]The ServletContextHandler of webui lacks a SessionManager You can merge this pull request into a Git repository by running: $ git pull https://github.com/XuTingjun/spark master