Github user ksakellis commented on the pull request:
https://github.com/apache/spark/pull/4020#issuecomment-70740442
@pwendell yeah, looks good. Sorry I was also away.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If y
Github user sryza commented on the pull request:
https://github.com/apache/spark/pull/4020#issuecomment-70607997
@pwendell sorry, was out for the weekend, but this LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/4020
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/4020#issuecomment-70466063
Okay I'm pulling this in with the minor style fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If you
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/4020#issuecomment-70395176
LGTM - @sryza and @ksakellis look okay to you?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/4020#discussion_r23130489
--- Diff: core/src/main/scala/org/apache/spark/executor/TaskMetrics.scala
---
@@ -44,42 +44,62 @@ class TaskMetrics extends Serializable {
/**
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4020#issuecomment-70321476
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4020#issuecomment-70321469
[Test build #25675 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25675/consoleFull)
for PR 4020 at commit
[`39f3810`](https://gith
Github user ilganeli commented on the pull request:
https://github.com/apache/spark/pull/4020#issuecomment-70311929
Updated to resolve merge conflicts with #3120, fix some small style issues,
and correctly use setters instead of inc/dec in certain places in the code.
---
If your pro
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4020#issuecomment-70311854
[Test build #25675 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25675/consoleFull)
for PR 4020 at commit
[`39f3810`](https://githu
Github user ilganeli commented on the pull request:
https://github.com/apache/spark/pull/4020#issuecomment-70214178
Hi Patrick - I did look over 3120. That one will definitely need to be
merged first and then we can finish this. Thanks.
---
If your project is set up for it, you can
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/4020#issuecomment-70201497
Conflicts abound!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/4020#discussion_r23060808
--- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
@@ -257,8 +257,8 @@ private[spark] class Executor(
val serviceTime =
Github user ksakellis commented on a diff in the pull request:
https://github.com/apache/spark/pull/4020#discussion_r23058543
--- Diff: core/src/main/scala/org/apache/spark/executor/TaskMetrics.scala
---
@@ -240,10 +284,18 @@ class ShuffleWriteMetrics extends Serializable {
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4020#issuecomment-70195240
[Test build #25621 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25621/consoleFull)
for PR 4020 at commit
[`e446287`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4020#issuecomment-70195248
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25
Github user ilganeli commented on a diff in the pull request:
https://github.com/apache/spark/pull/4020#discussion_r23057946
--- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
@@ -257,8 +257,8 @@ private[spark] class Executor(
val serviceTime =
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/4020#discussion_r23057341
--- Diff: core/src/main/scala/org/apache/spark/executor/TaskMetrics.scala
---
@@ -240,10 +284,18 @@ class ShuffleWriteMetrics extends Serializable {
/**
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/4020#discussion_r23057216
--- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
@@ -257,8 +257,8 @@ private[spark] class Executor(
val serviceTime = Sy
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/4020#issuecomment-70192435
Btw - this may conflict with #3120 so maybe we should hold off until that's
merge.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user ksakellis commented on a diff in the pull request:
https://github.com/apache/spark/pull/4020#discussion_r23056809
--- Diff: core/src/main/scala/org/apache/spark/executor/TaskMetrics.scala
---
@@ -240,10 +284,18 @@ class ShuffleWriteMetrics extends Serializable {
Github user ilganeli commented on a diff in the pull request:
https://github.com/apache/spark/pull/4020#discussion_r23056056
--- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
@@ -257,8 +257,8 @@ private[spark] class Executor(
val serviceTime =
Github user sryza commented on the pull request:
https://github.com/apache/spark/pull/4020#issuecomment-70189173
Had a look over, and this mostly looks good, but it looks like there are
many places where the patch replaces assigning with incrementing. It would be
good to take a close
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4020#issuecomment-70189111
[Test build #25621 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25621/consoleFull)
for PR 4020 at commit
[`e446287`](https://githu
Github user sryza commented on a diff in the pull request:
https://github.com/apache/spark/pull/4020#discussion_r23055589
--- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
@@ -257,8 +257,8 @@ private[spark] class Executor(
val serviceTime = Sy
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4020#issuecomment-70186438
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4020#issuecomment-70186432
[Test build #25619 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25619/consoleFull)
for PR 4020 at commit
[`6444391`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4020#issuecomment-70180180
[Test build #25619 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25619/consoleFull)
for PR 4020 at commit
[`6444391`](https://githu
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4020#issuecomment-69798922
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4020#issuecomment-69798914
[Test build #25473 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25473/consoleFull)
for PR 4020 at commit
[`1149e78`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4020#issuecomment-69787519
[Test build #25473 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25473/consoleFull)
for PR 4020 at commit
[`1149e78`](https://githu
GitHub user ilganeli opened a pull request:
https://github.com/apache/spark/pull/4020
[SPARK-3288] All fields in TaskMetrics should be private and use
getters/setters
I've updated the fields and all usages of these fields in the Spark code.
I've verified that this did not break any
32 matches
Mail list logo
