[GitHub] spark pull request: [SPARK-3303][core] fix SparkContextSchedulerCr...

2014-09-03 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/2199#issuecomment-54388093 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] spark pull request: [SPARK-3303][core] fix SparkContextSchedulerCr...

2014-09-03 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2199#issuecomment-54388411 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19714/consoleFull) for PR 2199 at commit [`ef1de22`](https://github.com/ap

[GitHub] spark pull request: [SPARK-3303][core] fix SparkContextSchedulerCr...

2014-09-03 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2199#issuecomment-54391903 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19714/consoleFull) for PR 2199 at commit [`ef1de22`](https://github.com/a

[GitHub] spark pull request: [SPARK-3303][core] fix SparkContextSchedulerCr...

2014-09-03 Thread scwf
Github user scwf commented on the pull request: https://github.com/apache/spark/pull/2199#issuecomment-54393128 Retest this please, failed due to forked process exited code not zero --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [SPARK-3303][core] fix SparkContextSchedulerCr...

2014-09-03 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/2199#issuecomment-54393260 Actually the reason why the fine-grained test didn't fail was because the `executorSparkHome` was not declared on initialization unlike for the coarse-grained test. Te

[GitHub] spark pull request: [SPARK-3303][core] fix SparkContextSchedulerCr...

2014-09-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/2199 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-3303][core] fix SparkContextSchedulerCr...

2014-08-29 Thread scwf
GitHub user scwf opened a pull request: https://github.com/apache/spark/pull/2199 [SPARK-3303][core] fix SparkContextSchedulerCreationSuite test error run test with the master branch with this command when mesos native lib is set sbt/sbt -Pyarn -Phadoop-2.3 -Dhadoop.version=2.3.

[GitHub] spark pull request: [SPARK-3303][core] fix SparkContextSchedulerCr...

2014-08-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2199#issuecomment-53889648 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] spark pull request: [SPARK-3303][core] fix SparkContextSchedulerCr...

2014-09-01 Thread ScrapCodes
Github user ScrapCodes commented on the pull request: https://github.com/apache/spark/pull/2199#issuecomment-54031780 I was in an impression that mesos native libs are set up on Jenkins. But anyway this seems to be a good change. --- If your project is set up for it, you can rep

[GitHub] spark pull request: [SPARK-3303][core] fix SparkContextSchedulerCr...

2014-09-01 Thread scwf
Github user scwf commented on the pull request: https://github.com/apache/spark/pull/2199#issuecomment-54071586 yep, this error produced when mesos native lib is on --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-3303][core] fix SparkContextSchedulerCr...

2014-09-02 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/2199#issuecomment-54119365 /cc @andrewor14 - I'm guessing we just want to set this variable in maven for the tests rather than changing the order of initialization in the code. --- If your projec

[GitHub] spark pull request: [SPARK-3303][core] fix SparkContextSchedulerCr...

2014-09-02 Thread scwf
Github user scwf commented on the pull request: https://github.com/apache/spark/pull/2199#issuecomment-54124416 Set this variable in maven also fix this issue, both is ok. Here i moved ```executorSparkHome``` is because ```executorSparkHome``` only used in ```createCommand ``` ---

[GitHub] spark pull request: [SPARK-3303][core] fix SparkContextSchedulerCr...

2014-09-02 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/2199#discussion_r17003423 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala --- @@ -112,6 +107,11 @@ private[spark] class Coa

[GitHub] spark pull request: [SPARK-3303][core] fix SparkContextSchedulerCr...

2014-09-02 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/2199#issuecomment-54191418 It's fine to move it if it's only used in `createCommand`, or we could even make it lazy and add a comment to explain it. Either is fine as long as it fixes the tests.

[GitHub] spark pull request: [SPARK-3303][core] fix SparkContextSchedulerCr...

2014-09-02 Thread scwf
Github user scwf commented on the pull request: https://github.com/apache/spark/pull/2199#issuecomment-54233687 updated, could you test this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th