Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/2291#discussion_r17191419
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/types/dataTypes.scala
---
@@ -65,7 +70,7 @@ object DataType extends RegexParsers {
GitHub user liancheng opened a pull request:
https://github.com/apache/spark/pull/2291
[SPARK-3421][SQL] Allows arbitrary character in StructField.name
`StructField.toString` now quotes the `name` field and escapes backslashes
and double quotes within the string. The `DataType` pars
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/2291#issuecomment-54909580
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
en
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2291#discussion_r17278691
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataTypeSuite.scala
---
@@ -55,4 +55,38 @@ class DataTypeSuite extends FunSuite {
struct(Se
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2291#issuecomment-54917073
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featu
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2291#issuecomment-55060899
Jenkins, test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2291#issuecomment-55061434
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20061/consoleFull)
for PR 2291 at commit
[`f3d8c98`](https://github.com/ap
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/2291#discussion_r17340060
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataTypeSuite.scala
---
@@ -55,4 +55,38 @@ class DataTypeSuite extends FunSuite {
struct(S
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2291#issuecomment-55067504
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20061/consoleFull)
for PR 2291 at commit
[`f3d8c98`](https://github.com/a
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2291#issuecomment-55152400
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2291#issuecomment-55154552
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20108/consoleFull)
for PR 2291 at commit
[`f3d8c98`](https://github.com/ap
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2291#issuecomment-55154697
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20108/consoleFull)
for PR 2291 at commit
[`f3d8c98`](https://github.com/a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2291#issuecomment-55218265
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/60/consoleFull)
for PR 2291 at commit
[`f3d8c98`](https://github.com/ap
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/2291#issuecomment-55220938
@liancheng Do you plan to fix this in Python?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proje
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2291#issuecomment-55222662
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20140/consoleFull)
for PR 2291 at commit
[`bb452c8`](https://github.com/ap
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2291#issuecomment-55224360
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/60/consoleFull)
for PR 2291 at commit
[`f3d8c98`](https://github.com/a
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/2291#issuecomment-55225283
@davies Oh, actually I didn't even realize this issue also exist in
PySpark.. So basically I only need to rewrite `StructField.__repr__` and quote
the field name, right
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2291#issuecomment-55229865
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20140/consoleFull)
for PR 2291 at commit
[`bb452c8`](https://github.com/a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2291#issuecomment-55243029
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20147/consoleFull)
for PR 2291 at commit
[`e837e2b`](https://github.com/ap
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2291#issuecomment-55251271
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20147/consoleFull)
for PR 2291 at commit
[`e837e2b`](https://github.com/a
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/2291#issuecomment-55288034
@liancheng I think The most important part would be create Row() class
using the name of field as name of attributes.
---
If your project is set up for it, you can reply
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/2291#issuecomment-55301417
The last build failure was caused by streaming suites.
But I do need to update the data type parsing logic in Python.
---
If your project is set up for it, you
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/2291#issuecomment-57085068
PR #2563 supersedes this one. Closing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user liancheng closed the pull request at:
https://github.com/apache/spark/pull/2291
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is e
24 matches
Mail list logo
