[GitHub] spark pull request: [SPARK-3578] Fix upper bound in GraphGenerator...

2014-09-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2439#issuecomment-56421650 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20659/consoleFull) for PR 2439 at commit

[GitHub] spark pull request: [SPARK-3578] Fix upper bound in GraphGenerator...

2014-09-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2439#issuecomment-56432395 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20659/consoleFull) for PR 2439 at commit

[GitHub] spark pull request: [SPARK-3578] Fix upper bound in GraphGenerator...

2014-09-22 Thread jegonzal
Github user jegonzal commented on the pull request: https://github.com/apache/spark/pull/2439#issuecomment-56438311 This looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-3578] Fix upper bound in GraphGenerator...

2014-09-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/2439 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-3578] Fix upper bound in GraphGenerator...

2014-09-20 Thread ankurdave
Github user ankurdave commented on the pull request: https://github.com/apache/spark/pull/2439#issuecomment-56258349 @rnowling Hmm, maybe you're right about that -- I'm not familiar enough with the algorithm to know whether it specifies rounding behavior in the first place.

[GitHub] spark pull request: [SPARK-3578] Fix upper bound in GraphGenerator...

2014-09-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2439#issuecomment-56258780 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20607/consoleFull) for PR 2439 at commit

[GitHub] spark pull request: [SPARK-3578] Fix upper bound in GraphGenerator...

2014-09-20 Thread rnowling
Github user rnowling commented on the pull request: https://github.com/apache/spark/pull/2439#issuecomment-56269533 I looke at the Pregel paper but it doesn't specify and doesn't cite other papers. I know it's a common method, though. After some thought, I think your

[GitHub] spark pull request: [SPARK-3578] Fix upper bound in GraphGenerator...

2014-09-19 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/2439#issuecomment-56153581 @jegonzal you should take a look :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-3578] Fix upper bound in GraphGenerator...

2014-09-19 Thread rnowling
Github user rnowling commented on the pull request: https://github.com/apache/spark/pull/2439#issuecomment-56183914 @ankurdave I'd be a bit concerned about how that affects the correctness of the algorithm. Especially since this will round every value down when maybe you only one to

[GitHub] spark pull request: [SPARK-3578] Fix upper bound in GraphGenerator...

2014-09-18 Thread ankurdave
Github user ankurdave commented on the pull request: https://github.com/apache/spark/pull/2439#issuecomment-56004216 @rxin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-3578] Fix upper bound in GraphGenerator...

2014-09-17 Thread ankurdave
GitHub user ankurdave opened a pull request: https://github.com/apache/spark/pull/2439 [SPARK-3578] Fix upper bound in GraphGenerators.sampleLogNormal GraphGenerators.sampleLogNormal is supposed to return an integer strictly less than maxVal. However, it violates this guarantee. It

[GitHub] spark pull request: [SPARK-3578] Fix upper bound in GraphGenerator...

2014-09-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2439#issuecomment-55975949 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20500/consoleFull) for PR 2439 at commit

[GitHub] spark pull request: [SPARK-3578] Fix upper bound in GraphGenerator...

2014-09-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2439#issuecomment-55981192 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20500/consoleFull) for PR 2439 at commit