[GitHub] spark pull request: [SPARK-3595] Respect configured OutputCommitte...

2014-09-21 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/2450#issuecomment-56306137 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-3595] Respect configured OutputCommitte...

2014-09-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2450#issuecomment-56306228 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/138/consoleFull) for PR 2450 at commit

[GitHub] spark pull request: [SPARK-3595] Respect configured OutputCommitte...

2014-09-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2450#issuecomment-56308294 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/138/consoleFull) for PR 2450 at commit

[GitHub] spark pull request: [SPARK-3595] Respect configured OutputCommitte...

2014-09-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/2450 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-3595] Respect configured OutputCommitte...

2014-09-20 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/2450#issuecomment-56284797 Jenkins, this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-3595] Respect configured OutputCommitte...

2014-09-20 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/2450#issuecomment-56284812 LGTM pending tests. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-3595] Respect configured OutputCommitte...

2014-09-19 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/2450#discussion_r17799318 --- Diff: core/src/main/scala/org/apache/spark/rdd/PairRDDFunctions.scala --- @@ -872,7 +872,12 @@ class PairRDDFunctions[K, V](self: RDD[(K, V)])

[GitHub] spark pull request: [SPARK-3595] Respect configured OutputCommitte...

2014-09-19 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/2450#discussion_r17799792 --- Diff: core/src/test/scala/org/apache/spark/rdd/PairRDDFunctionsSuite.scala --- @@ -478,6 +482,15 @@ class PairRDDFunctionsSuite extends FunSuite with

[GitHub] spark pull request: [SPARK-3595] Respect configured OutputCommitte...

2014-09-19 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/2450#discussion_r17799890 --- Diff: core/src/test/scala/org/apache/spark/rdd/PairRDDFunctionsSuite.scala --- @@ -478,6 +482,15 @@ class PairRDDFunctionsSuite extends FunSuite with

[GitHub] spark pull request: [SPARK-3595] Respect configured OutputCommitte...

2014-09-19 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/2450#discussion_r17800209 --- Diff: examples/src/main/scala/org/apache/spark/examples/AwsTest.scala --- @@ -0,0 +1,88 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: [SPARK-3595] Respect configured OutputCommitte...

2014-09-19 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/2450#issuecomment-56214986 Thanks for sending this. The approach seems solid. I made some small comments in a few places. --- If your project is set up for it, you can reply to this email and

[GitHub] spark pull request: [SPARK-3595] Respect configured OutputCommitte...

2014-09-19 Thread themodernlife
Github user themodernlife commented on a diff in the pull request: https://github.com/apache/spark/pull/2450#discussion_r17808274 --- Diff: core/src/test/scala/org/apache/spark/rdd/PairRDDFunctionsSuite.scala --- @@ -478,6 +482,15 @@ class PairRDDFunctionsSuite extends FunSuite

[GitHub] spark pull request: [SPARK-3595] Respect configured OutputCommitte...

2014-09-18 Thread themodernlife
GitHub user themodernlife opened a pull request: https://github.com/apache/spark/pull/2450 [SPARK-3595] Respect configured OutputCommitters when calling saveAsHadoopFile Addresses the issue in https://issues.apache.org/jira/browse/SPARK-3595, namely saveAsHadoopFile hardcoding the

[GitHub] spark pull request: [SPARK-3595] Respect configured OutputCommitte...

2014-09-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2450#issuecomment-56101950 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your