[GitHub] spark pull request: [SPARK-3629] [YARN] [DOCS]: Improvement of the...

2015-06-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/6924 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-3629] [YARN] [DOCS]: Improvement of the...

2015-06-26 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/6924#issuecomment-115971724 I've eyeballed the change again and looks like it's consistent with everyone's intentions. I'll merge after checking that docs build after this doc-only change. --- If

[GitHub] spark pull request: [SPARK-3629] [YARN] [DOCS]: Improvement of the...

2015-06-24 Thread nssalian
Github user nssalian commented on the pull request: https://github.com/apache/spark/pull/6924#issuecomment-114930404 @mateiz, does this PR need any more changes? Please let me know. Thanks. --- If your project is set up for it, you can reply to this email and have your re

[GitHub] spark pull request: [SPARK-3629] [YARN] [DOCS]: Improvement of the...

2015-06-23 Thread nssalian
Github user nssalian commented on the pull request: https://github.com/apache/spark/pull/6924#issuecomment-114512955 That is correct. I moved the texts a few commits ago. The latter commits were just formatting and changing yarn. --- If your project is set up for it, you can reply

[GitHub] spark pull request: [SPARK-3629] [YARN] [DOCS]: Improvement of the...

2015-06-23 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/6924#issuecomment-114485833 I think this looks pretty good; let's leave it open a day or so. The rest of the changes were just moving text right? so the only text changes were addressing the mast

[GitHub] spark pull request: [SPARK-3629] [YARN] [DOCS]: Improvement of the...

2015-06-22 Thread nssalian
Github user nssalian commented on a diff in the pull request: https://github.com/apache/spark/pull/6924#discussion_r32958854 --- Diff: docs/running-on-yarn.md --- @@ -7,6 +7,53 @@ Support for running on [YARN (Hadoop NextGen)](http://hadoop.apache.org/docs/stable/hadoop-yarn/h

[GitHub] spark pull request: [SPARK-3629] [YARN] [DOCS]: Improvement of the...

2015-06-22 Thread nssalian
Github user nssalian commented on a diff in the pull request: https://github.com/apache/spark/pull/6924#discussion_r32958837 --- Diff: docs/running-on-yarn.md --- @@ -7,6 +7,53 @@ Support for running on [YARN (Hadoop NextGen)](http://hadoop.apache.org/docs/stable/hadoop-yarn/h

[GitHub] spark pull request: [SPARK-3629] [YARN] [DOCS]: Improvement of the...

2015-06-22 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/6924#discussion_r32914728 --- Diff: docs/running-on-yarn.md --- @@ -7,6 +7,53 @@ Support for running on [YARN (Hadoop NextGen)](http://hadoop.apache.org/docs/stable/hadoop-yarn/had

[GitHub] spark pull request: [SPARK-3629] [YARN] [DOCS]: Improvement of the...

2015-06-22 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/6924#discussion_r32914556 --- Diff: docs/running-on-yarn.md --- @@ -7,6 +7,53 @@ Support for running on [YARN (Hadoop NextGen)](http://hadoop.apache.org/docs/stable/hadoop-yarn/had

[GitHub] spark pull request: [SPARK-3629] [YARN] [DOCS]: Improvement of the...

2015-06-21 Thread nssalian
Github user nssalian commented on the pull request: https://github.com/apache/spark/pull/6924#issuecomment-113995711 @mateiz made the changes. Not sure about the master yarn sentence. Please let me know what do you think about it. Thank you. --- If your project is set up

[GitHub] spark pull request: [SPARK-3629] [YARN] [DOCS]: Improvement of the...

2015-06-21 Thread nssalian
Github user nssalian commented on a diff in the pull request: https://github.com/apache/spark/pull/6924#discussion_r32898107 --- Diff: docs/running-on-yarn.md --- @@ -7,6 +7,53 @@ Support for running on [YARN (Hadoop NextGen)](http://hadoop.apache.org/docs/stable/hadoop-yarn/h

[GitHub] spark pull request: [SPARK-3629] [YARN] [DOCS]: Improvement of the...

2015-06-21 Thread nssalian
Github user nssalian commented on a diff in the pull request: https://github.com/apache/spark/pull/6924#discussion_r32897974 --- Diff: docs/running-on-yarn.md --- @@ -7,6 +7,53 @@ Support for running on [YARN (Hadoop NextGen)](http://hadoop.apache.org/docs/stable/hadoop-yarn/h

[GitHub] spark pull request: [SPARK-3629] [YARN] [DOCS]: Improvement of the...

2015-06-21 Thread mateiz
Github user mateiz commented on a diff in the pull request: https://github.com/apache/spark/pull/6924#discussion_r32897637 --- Diff: docs/running-on-yarn.md --- @@ -7,6 +7,53 @@ Support for running on [YARN (Hadoop NextGen)](http://hadoop.apache.org/docs/stable/hadoop-yarn/had

[GitHub] spark pull request: [SPARK-3629] [YARN] [DOCS]: Improvement of the...

2015-06-21 Thread mateiz
Github user mateiz commented on a diff in the pull request: https://github.com/apache/spark/pull/6924#discussion_r32897614 --- Diff: docs/running-on-yarn.md --- @@ -7,6 +7,53 @@ Support for running on [YARN (Hadoop NextGen)](http://hadoop.apache.org/docs/stable/hadoop-yarn/had

[GitHub] spark pull request: [SPARK-3629] [YARN] [DOCS]: Improvement of the...

2015-06-21 Thread mateiz
Github user mateiz commented on a diff in the pull request: https://github.com/apache/spark/pull/6924#discussion_r32897609 --- Diff: docs/running-on-yarn.md --- @@ -7,6 +7,53 @@ Support for running on [YARN (Hadoop NextGen)](http://hadoop.apache.org/docs/stable/hadoop-yarn/had

[GitHub] spark pull request: [SPARK-3629] [YARN] [DOCS]: Improvement of the...

2015-06-21 Thread mateiz
Github user mateiz commented on the pull request: https://github.com/apache/spark/pull/6924#issuecomment-113959572 Yeah, moving the text seems fine. I'm going to make a few small comments on the text itself. --- If your project is set up for it, you can reply to this email and have y

[GitHub] spark pull request: [SPARK-3629] [YARN] [DOCS]: Improvement of the...

2015-06-21 Thread nssalian
Github user nssalian commented on the pull request: https://github.com/apache/spark/pull/6924#issuecomment-113935211 @srowen makes sense. Made 2 commits to reflect the updates. @mateiz, please let me know if there are any additional changes that need to go. Thank you.

[GitHub] spark pull request: [SPARK-3629] [YARN] [DOCS]: Improvement of the...

2015-06-21 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/6924#issuecomment-113884873 @nssalian you don't need me specifically to review it, but I can. There was a previous pull request for this issue, and the feedback was that this diff doesn't ex

[GitHub] spark pull request: [SPARK-3629] [YARN] [DOCS]: Improvement of the...

2015-06-20 Thread nssalian
Github user nssalian commented on the pull request: https://github.com/apache/spark/pull/6924#issuecomment-113864731 @srowen, please review when you get the chance. Thank you. --- If your project is set up for it, you can reply to this email and have your reply appear on Git

[GitHub] spark pull request: [SPARK-3629] [YARN] [DOCS]: Improvement of the...

2015-06-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6924#issuecomment-113863354 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] spark pull request: [SPARK-3629] [YARN] [DOCS]: Improvement of the...

2015-06-20 Thread nssalian
GitHub user nssalian opened a pull request: https://github.com/apache/spark/pull/6924 [SPARK-3629] [YARN] [DOCS]: Improvement of the "Running Spark on YARN" document As per the description in the JIRA, I moved the contents of the page and added a few additional content. You can me