Github user soumitrak commented on the pull request:
https://github.com/apache/spark/pull/2665#issuecomment-62808794
TD, Thanks for getting this through.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/2665
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/2665#issuecomment-62787481
Thanks very much for the changes!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/2665#issuecomment-62787103
Alright I am merging this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user soumitrak commented on a diff in the pull request:
https://github.com/apache/spark/pull/2665#discussion_r20199347
--- Diff:
streaming/src/test/java/org/apache/spark/streaming/JavaAPISuite.java ---
@@ -1241,6 +1243,49 @@ public void testUpdateStateByKey() {
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2665#issuecomment-62658970
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2665#issuecomment-62658967
[Test build #23231 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23231/consoleFull)
for PR 2665 at commit
[`ee8980b`](https://gith
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/2665#discussion_r20196528
--- Diff:
streaming/src/test/java/org/apache/spark/streaming/JavaAPISuite.java ---
@@ -1241,6 +1243,49 @@ public void testUpdateStateByKey() {
@Supp
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2665#issuecomment-62650441
[Test build #23231 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23231/consoleFull)
for PR 2665 at commit
[`ee8980b`](https://githu
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2665#issuecomment-62644658
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2665#issuecomment-62644649
[Test build #23225 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23225/consoleFull)
for PR 2665 at commit
[`304f636`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2665#issuecomment-62636664
[Test build #23225 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23225/consoleFull)
for PR 2665 at commit
[`304f636`](https://githu
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2665#issuecomment-62634447
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2665#issuecomment-62634438
[Test build #23223 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23223/consoleFull)
for PR 2665 at commit
[`9781135`](https://gith
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/2665#issuecomment-62632491
This is starting to look good. Please address the comments (mainly Scala
API addition), and we will good to go. This is a good addition to
updateStateByKey.
---
If your p
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/2665#discussion_r20185491
--- Diff:
streaming/src/test/java/org/apache/spark/streaming/JavaAPISuite.java ---
@@ -1241,6 +1241,49 @@ public void testUpdateStateByKey() {
@Supp
Github user soumitrak commented on a diff in the pull request:
https://github.com/apache/spark/pull/2665#discussion_r20184611
--- Diff:
streaming/src/test/java/org/apache/spark/streaming/JavaAPISuite.java ---
@@ -1241,6 +1241,49 @@ public void testUpdateStateByKey() {
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/2665#discussion_r20183888
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/dstream/StateDStream.scala
---
@@ -41,6 +42,28 @@ class StateDStream[K: ClassTag, V: ClassTag, S:
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/2665#discussion_r20183715
--- Diff:
streaming/src/test/java/org/apache/spark/streaming/JavaAPISuite.java ---
@@ -1241,6 +1241,49 @@ public void testUpdateStateByKey() {
@Supp
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/2665#discussion_r20183390
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/api/java/JavaPairDStream.scala
---
@@ -492,6 +509,26 @@ class JavaPairDStream[K, V](val dstream: D
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/2665#discussion_r20182783
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/api/java/JavaPairDStream.scala
---
@@ -492,6 +509,26 @@ class JavaPairDStream[K, V](val dstream: D
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/2665#discussion_r20182577
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/api/java/JavaPairDStream.scala
---
@@ -443,6 +443,23 @@ class JavaPairDStream[K, V](val dstream: D
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2665#issuecomment-62620795
[Test build #23223 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23223/consoleFull)
for PR 2665 at commit
[`9781135`](https://githu
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2665#issuecomment-62613355
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2665#issuecomment-62613337
[Test build #23219 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23219/consoleFull)
for PR 2665 at commit
[`3da51a2`](https://gith
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/2665#discussion_r20174490
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/dstream/StateDStream.scala
---
@@ -30,7 +30,8 @@ class StateDStream[K: ClassTag, V: ClassTag, S: C
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2665#issuecomment-62598614
[Test build #23219 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23219/consoleFull)
for PR 2665 at commit
[`3da51a2`](https://githu
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2665#issuecomment-62589644
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2665#issuecomment-62589626
[Test build #23218 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23218/consoleFull)
for PR 2665 at commit
[`d4fdd18`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2665#issuecomment-62574997
[Test build #23218 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23218/consoleFull)
for PR 2665 at commit
[`d4fdd18`](https://githu
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/2665#discussion_r20144228
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/dstream/PairDStreamFunctions.scala
---
@@ -406,6 +406,31 @@ class PairDStreamFunctions[K, V](self:
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/2665#issuecomment-62533839
I am yet to do another pass on the logic. Will do tomorrow.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/2665#discussion_r20144216
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/dstream/PairDStreamFunctions.scala
---
@@ -406,6 +406,31 @@ class PairDStreamFunctions[K, V](self:
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/2665#issuecomment-62533479
This was a good update. But i forgot to mention last time that you also
need to add the same API to JavaPairDStream as well.
---
If your project is set up for it, you can r
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2665#issuecomment-62508181
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2665#issuecomment-62508172
[Test build #23194 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23194/consoleFull)
for PR 2665 at commit
[`31399a4`](https://gith
Github user soumitrak commented on the pull request:
https://github.com/apache/spark/pull/2665#issuecomment-62503160
TD, I have merged and incorporated your feedback.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If you
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2665#issuecomment-62503089
[Test build #23194 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23194/consoleFull)
for PR 2665 at commit
[`31399a4`](https://githu
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2665#issuecomment-62486784
**[Test build #23166 timed
out](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23166/consoleFull)**
for PR 2665 at commit
[`4efa58b`](https://git
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2665#issuecomment-62486795
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/2665#issuecomment-62484511
Can up merge with the master? This does not merge correctly any more.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/2665#discussion_r20122762
--- Diff:
streaming/src/test/scala/org/apache/spark/streaming/BasicOperationsSuite.scala
---
@@ -349,6 +350,43 @@ class BasicOperationsSuite extends TestSuiteBa
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/2665#discussion_r20122771
--- Diff:
streaming/src/test/scala/org/apache/spark/streaming/TestSuiteBase.scala ---
@@ -213,6 +213,34 @@ trait TestSuiteBase extends FunSuite with
BeforeAndAf
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2665#issuecomment-62474792
[Test build #23166 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23166/consoleFull)
for PR 2665 at commit
[`4efa58b`](https://githu
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/2665#discussion_r20121591
--- Diff:
streaming/src/test/scala/org/apache/spark/streaming/TestSuiteBase.scala ---
@@ -213,6 +213,34 @@ trait TestSuiteBase extends FunSuite with
BeforeAndAf
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/2665#issuecomment-62474217
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user soumitrak commented on the pull request:
https://github.com/apache/spark/pull/2665#issuecomment-62231787
TD, Let me know how I can help.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2665#issuecomment-62230621
[Test build #23074 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23074/consoleFull)
for PR 2665 at commit
[`4efa58b`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2665#issuecomment-62230629
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2665#issuecomment-62223097
[Test build #23074 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23074/consoleFull)
for PR 2665 at commit
[`4efa58b`](https://githu
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/2665#issuecomment-6474
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2665#issuecomment-60476446
[Test build #22206 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22206/consoleFull)
for PR 2665 at commit
[`4efa58b`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2665#issuecomment-60476448
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/22
53 matches
Mail list logo
