Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/2563
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2563#issuecomment-58446924
Thanks! I've merged this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/2563#issuecomment-58307821
@marmbrus I think this is ready to go.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2563#issuecomment-58300431
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/285/consoleFull)
for PR 2563 at commit
[`fc92eb3`](https://github.com/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2563#issuecomment-58299048
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/2
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2563#issuecomment-58299045
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21437/consoleFull)
for PR 2563 at commit
[`fc92eb3`](https://github.com/a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2563#issuecomment-58292948
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/285/consoleFull)
for PR 2563 at commit
[`fc92eb3`](https://github.com/a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2563#issuecomment-58292425
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21437/consoleFull)
for PR 2563 at commit
[`fc92eb3`](https://github.com/ap
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/2563#issuecomment-58291809
Finished rebasing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/2563#issuecomment-58234335
Could you rebase this to master?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/2563#issuecomment-57926775
LGTM now, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featur
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2563#issuecomment-57925711
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/2
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2563#issuecomment-57925709
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21305/consoleFull)
for PR 2563 at commit
[`de18dea`](https://github.com/a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2563#issuecomment-57924412
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21305/consoleFull)
for PR 2563 at commit
[`de18dea`](https://github.com/ap
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/2563#issuecomment-57923419
@davies Sorry for my carelessness... And thanks again for all the great
advices!
---
If your project is set up for it, you can reply to this email and have your
reply
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/2563#issuecomment-57923097
This looks good to me, you just forget to rollback the changes in run-tests
after debugging.
---
If your project is set up for it, you can reply to this email and have yo
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/2563#discussion_r18432681
--- Diff: python/pyspark/sql.py ---
@@ -62,6 +63,18 @@ def __eq__(self, other):
def __ne__(self, other):
return not self.__eq__(other)
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/2563#discussion_r18432669
--- Diff: python/run-tests ---
@@ -60,56 +60,58 @@ fi
echo "Testing with Python version:"
$PYSPARK_PYTHON --version
-run_test "pyspark/rdd.p
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/2563#discussion_r18432650
--- Diff: python/pyspark/sql.py ---
@@ -312,42 +358,30 @@ def __repr__(self):
return ("StructType(List(%s))" %
",".join(str(fi
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/2563#issuecomment-57922847
@liancheng You had mentioned another guy, my id is davies
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2563#issuecomment-57901579
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/265/consoleFull)
for PR 2563 at commit
[`785b683`](https://github.com/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2563#issuecomment-57900055
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/265/consoleFull)
for PR 2563 at commit
[`785b683`](https://github.com/a
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2563#issuecomment-57899624
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/2
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2563#issuecomment-57899622
**[Tests timed
out](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21289/consoleFull)**
after a configured wait of `120m`.
---
If your project i
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2563#issuecomment-57898948
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/2
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2563#issuecomment-57898946
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21291/consoleFull)
for PR 2563 at commit
[`785b683`](https://github.com/a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2563#issuecomment-57897538
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21291/consoleFull)
for PR 2563 at commit
[`785b683`](https://github.com/ap
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2563#issuecomment-57897375
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21289/consoleFull)
for PR 2563 at commit
[`54c46ce`](https://github.com/ap
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/2563#issuecomment-57897337
@davis Thanks for all the suggestions, really makes things a lot cleaner!
---
If your project is set up for it, you can reply to this email and have your
reply appear o
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/2563#discussion_r18399479
--- Diff: python/pyspark/sql.py ---
@@ -312,42 +343,24 @@ def __repr__(self):
return ("StructType(List(%s))" %
",".join(str
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/2563#discussion_r18384157
--- Diff: python/pyspark/sql.py ---
@@ -385,51 +398,35 @@ def _parse_datatype_string(datatype_string):
>>> check_datatype(complex_maptype)
Tru
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/2563#discussion_r18384024
--- Diff: python/pyspark/sql.py ---
@@ -312,42 +343,24 @@ def __repr__(self):
return ("StructType(List(%s))" %
",".join(str(fi
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/2563#discussion_r18383911
--- Diff: python/pyspark/sql.py ---
@@ -62,6 +67,17 @@ def __eq__(self, other):
def __ne__(self, other):
return not self.__eq__(other)
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/2563#discussion_r18377127
--- Diff: python/pyspark/sql.py ---
@@ -62,6 +63,12 @@ def __eq__(self, other):
def __ne__(self, other):
return not self.__eq__(other)
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2563#issuecomment-57732079
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21227/consoleFull)
for PR 2563 at commit
[`81e28fb`](https://github.com/a
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2563#issuecomment-57732086
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2563#issuecomment-57722826
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21227/consoleFull)
for PR 2563 at commit
[`81e28fb`](https://github.com/ap
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2563#issuecomment-57648680
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2563#issuecomment-57648676
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21205/consoleFull)
for PR 2563 at commit
[`5169238`](https://github.com/a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2563#issuecomment-57648509
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21205/consoleFull)
for PR 2563 at commit
[`5169238`](https://github.com/ap
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/2563#discussion_r18345824
--- Diff: python/pyspark/sql.py ---
@@ -385,50 +429,32 @@ def _parse_datatype_string(datatype_string):
>>> check_datatype(complex_maptype)
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/2563#discussion_r18342925
--- Diff: python/pyspark/sql.py ---
@@ -205,6 +234,16 @@ def __str__(self):
return "ArrayType(%s,%s)" % (self.elementType,
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/2563#discussion_r18342875
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/types/dataTypes.scala
---
@@ -19,71 +19,127 @@ package org.apache.spark.sql.catalyst.ty
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/2563#discussion_r18325514
--- Diff: python/pyspark/sql.py ---
@@ -205,6 +234,16 @@ def __str__(self):
return "ArrayType(%s,%s)" % (self.elementType,
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/2563#discussion_r18324999
--- Diff: python/pyspark/sql.py ---
@@ -205,6 +234,16 @@ def __str__(self):
return "ArrayType(%s,%s)" % (self.elementType,
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/2563#discussion_r18321520
--- Diff: python/pyspark/sql.py ---
@@ -385,50 +429,32 @@ def _parse_datatype_string(datatype_string):
>>> check_datatype(complex_maptype)
Tru
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/2563#discussion_r18321352
--- Diff: python/pyspark/sql.py ---
@@ -205,6 +234,16 @@ def __str__(self):
return "ArrayType(%s,%s)" % (self.elementType,
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/2563#discussion_r18321283
--- Diff: python/pyspark/sql.py ---
@@ -62,6 +63,12 @@ def __eq__(self, other):
def __ne__(self, other):
return not self.__eq__(other)
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2563#issuecomment-57544564
Minor comment otherwise this LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2563#discussion_r18310445
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/types/dataTypes.scala
---
@@ -19,71 +19,127 @@ package org.apache.spark.sql.catalyst.typ
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2563#issuecomment-57279975
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/210/consoleFull)
for PR 2563 at commit
[`03da3ec`](https://github.com/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2563#issuecomment-57272666
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/210/consoleFull)
for PR 2563 at commit
[`03da3ec`](https://github.com/a
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2563#issuecomment-57090932
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/20
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2563#issuecomment-57090930
**[Tests timed
out](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20939/consoleFull)**
after a configured wait of `120m`.
---
If your project i
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2563#issuecomment-57087294
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20939/consoleFull)
for PR 2563 at commit
[`03da3ec`](https://github.com/ap
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2563#issuecomment-57084988
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/20
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2563#issuecomment-57084987
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20938/consoleFull)
for PR 2563 at commit
[`26c6563`](https://github.com/a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2563#issuecomment-57084959
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20938/consoleFull)
for PR 2563 at commit
[`26c6563`](https://github.com/ap
GitHub user liancheng opened a pull request:
https://github.com/apache/spark/pull/2563
[SPARK-3713][SQL] Uses JSON to serialize DataType objects
This PR uses JSON instead of `toString` to serialize `DataType`s. The
latter is not only hard to parse but also flaky in many cases.
59 matches
Mail list logo
