[GitHub] spark pull request: [SPARK-3751] [mllib] DecisionTree: example upd...

2014-10-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2604#issuecomment-57426168 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21092/consoleFull) for PR 2604 at commit

[GitHub] spark pull request: [SPARK-3751] [mllib] DecisionTree: example upd...

2014-10-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2604#issuecomment-57426171 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-3751] [mllib] DecisionTree: example upd...

2014-10-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2604#issuecomment-57426315 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21094/consoleFull) for PR 2604 at commit

[GitHub] spark pull request: [SPARK-3751] [mllib] DecisionTree: example upd...

2014-10-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2604#issuecomment-57426321 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-3751] [mllib] DecisionTree: example upd...

2014-10-01 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/2604#issuecomment-57431357 LGTM. Merged into master. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-3751] [mllib] DecisionTree: example upd...

2014-10-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/2604 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-3751] [mllib] DecisionTree: example upd...

2014-09-30 Thread jkbradley
GitHub user jkbradley opened a pull request: https://github.com/apache/spark/pull/2604 [SPARK-3751] [mllib] DecisionTree: example update + print options DecisionTreeRunner functionality additions: * Allow user to pass in a test dataset * Do not print full model if the model

[GitHub] spark pull request: [SPARK-3751] [mllib] DecisionTree: example upd...

2014-09-30 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2604#issuecomment-57388054 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21067/consoleFull) for PR 2604 at commit

[GitHub] spark pull request: [SPARK-3751] [mllib] DecisionTree: example upd...

2014-09-30 Thread manishamde
Github user manishamde commented on a diff in the pull request: https://github.com/apache/spark/pull/2604#discussion_r18252110 --- Diff: examples/src/main/scala/org/apache/spark/examples/mllib/DecisionTreeRunner.scala --- @@ -170,16 +176,40 @@ object DecisionTreeRunner {

[GitHub] spark pull request: [SPARK-3751] [mllib] DecisionTree: example upd...

2014-09-30 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2604#issuecomment-57394723 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21067/consoleFull) for PR 2604 at commit

[GitHub] spark pull request: [SPARK-3751] [mllib] DecisionTree: example upd...

2014-09-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2604#issuecomment-57394730 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-3751] [mllib] DecisionTree: example upd...

2014-09-30 Thread manishamde
Github user manishamde commented on a diff in the pull request: https://github.com/apache/spark/pull/2604#discussion_r18252633 --- Diff: examples/src/main/scala/org/apache/spark/examples/mllib/DecisionTreeRunner.scala --- @@ -206,32 +236,56 @@ object DecisionTreeRunner {

[GitHub] spark pull request: [SPARK-3751] [mllib] DecisionTree: example upd...

2014-09-30 Thread manishamde
Github user manishamde commented on the pull request: https://github.com/apache/spark/pull/2604#issuecomment-57395157 LGTM. I have made a general comments for all runners but it might be beyond the scope of this PR. --- If your project is set up for it, you can reply to this email

[GitHub] spark pull request: [SPARK-3751] [mllib] DecisionTree: example upd...

2014-09-30 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/2604#discussion_r18261691 --- Diff: examples/src/main/scala/org/apache/spark/examples/mllib/DecisionTreeRunner.scala --- @@ -206,32 +236,56 @@ object DecisionTreeRunner {

[GitHub] spark pull request: [SPARK-3751] [mllib] DecisionTree: example upd...

2014-09-30 Thread manishamde
Github user manishamde commented on a diff in the pull request: https://github.com/apache/spark/pull/2604#discussion_r18261804 --- Diff: examples/src/main/scala/org/apache/spark/examples/mllib/DecisionTreeRunner.scala --- @@ -206,32 +236,56 @@ object DecisionTreeRunner {

[GitHub] spark pull request: [SPARK-3751] [mllib] DecisionTree: example upd...

2014-09-30 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/2604#discussion_r18262076 --- Diff: examples/src/main/scala/org/apache/spark/examples/mllib/DecisionTreeRunner.scala --- @@ -170,16 +176,40 @@ object DecisionTreeRunner {

[GitHub] spark pull request: [SPARK-3751] [mllib] DecisionTree: example upd...

2014-09-30 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2604#issuecomment-57421801 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21092/consoleFull) for PR 2604 at commit

[GitHub] spark pull request: [SPARK-3751] [mllib] DecisionTree: example upd...

2014-09-30 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/2604#issuecomment-57421830 @manishamde Thank you for checking the PR! I updated the Python API and tests to fix the doc test failure. --- If your project is set up for it, you can reply to

[GitHub] spark pull request: [SPARK-3751] [mllib] DecisionTree: example upd...

2014-09-30 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2604#issuecomment-57422106 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21094/consoleFull) for PR 2604 at commit