Github user ravipesala commented on the pull request:
https://github.com/apache/spark/pull/2789#issuecomment-60383108
Closed this PR as it has merge conflicts and created new PR
https://github.com/apache/spark/pull/2926 and handled comments here
---
If your project is set up for it,
Github user ravipesala closed the pull request at:
https://github.com/apache/spark/pull/2789
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/2789#issuecomment-60338332
Would you please rebase?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2789#issuecomment-60014129
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2789#discussion_r19121441
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
---
@@ -64,6 +64,23 @@ abstract class BinaryArithmetic exte
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2789#discussion_r19121230
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
---
@@ -64,6 +64,23 @@ abstract class BinaryArithmetic exte
Github user ravipesala commented on the pull request:
https://github.com/apache/spark/pull/2789#issuecomment-59329218
Added support for Bitwise AND(&), OR(|) ,XOR(^), NOT(~) in this PR only.
Please review it.
---
If your project is set up for it, you can reply to this email and have
Github user ravipesala commented on the pull request:
https://github.com/apache/spark/pull/2789#issuecomment-59087699
@marmbrus Please review this PR, I handled review comments of PR
https://github.com/apache/spark/pull/2736.Due to merge conflicts I have created
new PR.
---
If your
Github user ravipesala commented on the pull request:
https://github.com/apache/spark/pull/2789#issuecomment-58984605
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2789#issuecomment-58982720
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
GitHub user ravipesala opened a pull request:
https://github.com/apache/spark/pull/2789
[SPARK-3814][SQL] Bitwise & does not work in Hive
Currently there is no support of Bitwise & , | in Spark HiveQl and Spark
SQL as well. So this PR support the same.
I am closing https://githu
Github user ravipesala closed the pull request at:
https://github.com/apache/spark/pull/2772
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user ravipesala commented on the pull request:
https://github.com/apache/spark/pull/2772#issuecomment-58980787
Again merge conflicts :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2736#issuecomment-58933848
I don't think that is correct. Github shows whatever the difference is
between the head commit of the PR branch and apache/master. Intermediate
changes/merges should n
Github user ravipesala commented on the pull request:
https://github.com/apache/spark/pull/2736#issuecomment-58872032
Thank you @scwf , I have created new PR since it has merge conflicts. It
will not be neat If I rebase and push to old PR because it will show all
changed files which
Github user scwf commented on the pull request:
https://github.com/apache/spark/pull/2736#issuecomment-58774056
Hi, @ravipesala, you don't need create a new PR, you can update you pr
here(use git push to update this branch)
---
If your project is set up for it, you can reply to this
Github user ravipesala closed the pull request at:
https://github.com/apache/spark/pull/2736
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2772#issuecomment-58765710
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user ravipesala commented on the pull request:
https://github.com/apache/spark/pull/2736#issuecomment-58765712
Since this PR has conflicts , I created new PR
https://github.com/apache/spark/pull/2772 and handled review comments in it.
---
If your project is set up for it, you
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2772#issuecomment-58765716
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
GitHub user ravipesala opened a pull request:
https://github.com/apache/spark/pull/2772
[SPARK-3814][SQL] Bitwise & does not work in Hive
Currently there is no support of Bitwise & , | in Spark HiveQl and Spark
SQL as well. So this PR support the same.
I am closing https://githu
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2736#discussion_r1868
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
---
@@ -100,6 +100,14 @@ case class Remainder(left: Express
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2736#issuecomment-58600357
A few other comments:
- Would it be possible to support bitwise or as well since that code will
be very similar?
- New expressions should have tests in `Express
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2736#discussion_r18684401
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/types/dataTypes.scala
---
@@ -275,36 +275,45 @@ abstract class IntegralType extends Nume
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2736#issuecomment-58587282
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/2
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2736#issuecomment-58586112
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
ena
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2710#issuecomment-58585703
@ravipesala, you don't need to create a new PR. And in fact its better if
you don't so review comments are not lost.
You can just push to the same branch and gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2736#issuecomment-58572765
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user ravipesala commented on the pull request:
https://github.com/apache/spark/pull/2710#issuecomment-58570555
I am closing this PR as it has conflicts. And I created new PR
https://github.com/apache/spark/pull/2736
---
If your project is set up for it, you can reply to this e
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2736#issuecomment-58570582
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user ravipesala closed the pull request at:
https://github.com/apache/spark/pull/2710
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user ravipesala opened a pull request:
https://github.com/apache/spark/pull/2736
[SPARK-3814][SQL] Bitwise & does not work in Hive
Currently there is no support of Bitwise & in Spark HiveQl and Spark SQL as
well. So this PR support the same.
I am closing https://github.co
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2710#issuecomment-58462645
Yeah, sorry github seems extra flakey today. Now there is a conflict
though, could you merge with master?
---
If your project is set up for it, you can reply to this e
Github user ravipesala commented on the pull request:
https://github.com/apache/spark/pull/2710#issuecomment-58458547
@marmbrus it seems git cannot fetch the code that's why it is failed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2710#issuecomment-58446338
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/2
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2710#issuecomment-58445373
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
ena
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2710#issuecomment-58348032
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
GitHub user ravipesala opened a pull request:
https://github.com/apache/spark/pull/2710
[SPARK-3814][SQL] Bitwise & does not work in Hive
Currently there is no support of Bitwise & in Spark HiveQl and Spark SQL as
well. So this PR support the same.
Author : ravipesala ravin
38 matches
Mail list logo
