Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/2762
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2762#issuecomment-60863489
Thanks for working on this. Merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2762#issuecomment-60861522
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/22
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2762#issuecomment-60861518
[Test build #22404 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22404/consoleFull)
for PR 2762 at commit
[`bcacfd7`](https://gith
Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/2762#discussion_r19515074
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveInspectors.scala ---
@@ -123,43 +94,89 @@ private[hive] trait HiveInspectors {
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2762#issuecomment-60857912
[Test build #22404 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22404/consoleFull)
for PR 2762 at commit
[`bcacfd7`](https://githu
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/2762#discussion_r19514698
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveInspectors.scala ---
@@ -123,43 +94,89 @@ private[hive] trait HiveInspectors {
case
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/2762#issuecomment-60857473
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/2762#issuecomment-60856234
Rebased!
test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2762#issuecomment-60849735
[Test build #490 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/490/consoleFull)
for PR 2762 at commit
[`782722f`](https://githu
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2762#issuecomment-60840095
Also, this needs to be updated again (I think it conflicted with your CTAS
patch).
---
If your project is set up for it, you can reply to this email and have your
reply
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2762#issuecomment-60838320
[Test build #490 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/490/consoleFull)
for PR 2762 at commit
[`782722f`](https://github
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/2762#issuecomment-60725691
retest this please. @liancheng :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/2762#issuecomment-60725665
It passed the unit test in my local with the master rebased. Seems weird.
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2762#issuecomment-60719316
[Test build #22345 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22345/consoleFull)
for PR 2762 at commit
[`782722f`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2762#issuecomment-60719319
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/22
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2762#issuecomment-60716603
[Test build #22345 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22345/consoleFull)
for PR 2762 at commit
[`782722f`](https://githu
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/2762#issuecomment-60716472
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/2762#issuecomment-60715086
test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2762#issuecomment-60643053
[Test build #478 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/478/consoleFull)
for PR 2762 at commit
[`9c34cb8`](https://githu
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2762#issuecomment-60642235
[Test build #478 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/478/consoleFull)
for PR 2762 at commit
[`9c34cb8`](https://github
Github user gvramana commented on the pull request:
https://github.com/apache/spark/pull/2762#issuecomment-60556024
Yes, one more advantage of passing object inspector as parameter is,
constants need not be allocated every time, same value in
constantObjectInpector can be reused. I al
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/2762#issuecomment-60554357
test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/2762#discussion_r19389129
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveInspectors.scala ---
@@ -123,43 +93,88 @@ private[hive] trait HiveInspectors {
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/2762#issuecomment-60541840
@marmbrus @gvramana , #2802 looks good to me in general to fix the constant
value pass into the Hive UDFs, and it does some overlap work with this PR. The
reason
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2762#issuecomment-60534712
How does this compare with #2802? They look very similar.
Also can you rebase please?
---
If your project is set up for it, you can reply to this email and hav
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2762#issuecomment-60477012
[Test build #441 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/441/consoleFull)
for PR 2762 at commit
[`5bb1b9d`](https://githu
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2762#issuecomment-60475334
[Test build #441 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/441/consoleFull)
for PR 2762 at commit
[`5bb1b9d`](https://github
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2762#issuecomment-60350429
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/22
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2762#issuecomment-60350423
[Test build #22118 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22118/consoleFull)
for PR 2762 at commit
[`5bb1b9d`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2762#issuecomment-60347589
[Test build #22118 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22118/consoleFull)
for PR 2762 at commit
[`5bb1b9d`](https://githu
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/2762#issuecomment-60347169
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/2762#issuecomment-60343740
test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/2762#issuecomment-60242669
Thank you @liancheng, I've updated the code accordingly.
You're right, the conversion is not so efficient, probably we need to add
some Expression nodes fo
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/2762#issuecomment-60192374
Another high level comments on performance, which we can leave to another
separate PR.
We can turn all these "wrap" and "unwrap" functions into function
factor
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/2762#issuecomment-60191630
Some minor styling comments, otherwise LGTM. Sorry for not being able to
review this earlier.
---
If your project is set up for it, you can reply to this email and hav
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/2762#discussion_r19259002
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveInspectors.scala ---
@@ -123,43 +93,88 @@ private[hive] trait HiveInspectors {
case
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/2762#discussion_r19258998
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveInspectors.scala ---
@@ -123,43 +93,88 @@ private[hive] trait HiveInspectors {
case
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/2762#discussion_r19258567
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveInspectors.scala ---
@@ -123,43 +93,88 @@ private[hive] trait HiveInspectors {
case
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/2762#discussion_r19258366
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveInspectors.scala ---
@@ -123,43 +93,88 @@ private[hive] trait HiveInspectors {
case
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/2762#discussion_r19258312
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveInspectors.scala ---
@@ -123,43 +93,88 @@ private[hive] trait HiveInspectors {
case
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/2762#discussion_r19256168
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveInspectors.scala ---
@@ -123,43 +93,88 @@ private[hive] trait HiveInspectors {
case
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/2762#issuecomment-60178237
I've updated the description a little bit. @rxin @marmbrus @liancheng
@tianyi @gvramana any more comments on this? I have some PRs for the same file,
which blocke
Github user tianyi commented on the pull request:
https://github.com/apache/spark/pull/2762#issuecomment-60025019
Is there any admin could review this PR ASAP? We got some PR blocked by
this one. like #2542 @marmbrus @rxin
---
If your project is set up for it, you can reply to this
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2762#issuecomment-59674011
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/403/consoleFull)
for PR 2762 at commit
[`49d442b`](https://github.com/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2762#issuecomment-59672239
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/403/consoleFull)
for PR 2762 at commit
[`49d442b`](https://github.com/a
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/2762#issuecomment-59474277
Thank you @gvramana , I've updated the code as you suggested.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHu
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/2762#issuecomment-59474302
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
Github user gvramana commented on the pull request:
https://github.com/apache/spark/pull/2762#issuecomment-59168016
unfortunately :( I also have worked and implemented the same as part of
https://github.com/apache/spark/pull/2802
Anyways I will rework on my pull request for support
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/spark/pull/2762#discussion_r18877950
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveInspectors.scala ---
@@ -186,6 +230,51 @@ private[hive] trait HiveInspectors {
f
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/spark/pull/2762#discussion_r18877380
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/hiveUdfs.scala
---
@@ -159,7 +162,10 @@ private[hive] case class
HiveGenericUdf(functionClassNam
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/2762#issuecomment-59144839
test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/2762#issuecomment-59055965
Thanks, I've rebased the latest master, and solved the issues you guys
raised.
---
If your project is set up for it, you can reply to this email and have your
rep
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/2762#discussion_r18819746
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveInspectors.scala ---
@@ -135,26 +139,66 @@ private[hive] trait HiveInspectors {
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/2762#discussion_r18805920
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveInspectors.scala ---
@@ -95,9 +96,12 @@ private[hive] trait HiveInspectors {
}
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2762#discussion_r18792246
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypes.scala
---
@@ -95,8 +95,8 @@ case class GetField(child: Expressi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2762#issuecomment-58776263
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2762#issuecomment-58776261
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21661/consoleFull)
for PR 2762 at commit
[`cb97576`](https://github.com/a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2762#issuecomment-58775530
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21661/consoleFull)
for PR 2762 at commit
[`cb97576`](https://github.com/ap
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2762#issuecomment-58748912
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/2
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2762#issuecomment-58748909
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21645/consoleFull)
for PR 2762 at commit
[`335a952`](https://github.com/a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2762#issuecomment-58748067
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21645/consoleFull)
for PR 2762 at commit
[`335a952`](https://github.com/ap
Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/2762#discussion_r18741363
--- Diff:
sql/hive/compatibility/src/test/scala/org/apache/spark/sql/hive/execution/HiveCompatibilitySuite.scala
---
@@ -578,6 +578,7 @@ class HiveCom
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2762#issuecomment-58741234
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/2
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2762#issuecomment-58741232
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21638/consoleFull)
for PR 2762 at commit
[`06581e3`](https://github.com/a
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2762#issuecomment-58741124
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/2
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2762#issuecomment-58741122
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21637/consoleFull)
for PR 2762 at commit
[`06581e3`](https://github.com/a
Github user tianyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/2762#discussion_r18739877
--- Diff:
sql/hive/compatibility/src/test/scala/org/apache/spark/sql/hive/execution/HiveCompatibilitySuite.scala
---
@@ -578,6 +578,7 @@ class HiveCompatibili
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2762#issuecomment-58740581
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21638/consoleFull)
for PR 2762 at commit
[`06581e3`](https://github.com/ap
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2762#issuecomment-58740484
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21637/consoleFull)
for PR 2762 at commit
[`06581e3`](https://github.com/ap
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/2762#issuecomment-58740444
test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/2762#issuecomment-58740447
test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2762#issuecomment-58740431
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
GitHub user chenghao-intel opened a pull request:
https://github.com/apache/spark/pull/2762
[SPARK-3904] [SQL] add constant objectinspector support for udfs
In HQL, we convert all of the data type into normal `ObjectInspector`s for
UDFs, most of cases it work, however, some of the U
74 matches
Mail list logo
