[GitHub] spark pull request: [SPARK-3934] [SPARK-3918] [mllib] Bug fixes fo...

2014-10-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/2785 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-3934] [SPARK-3918] [mllib] Bug fixes fo...

2014-10-17 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/2785#issuecomment-59582528 LGTM. Merged into master. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-3934] [SPARK-3918] [mllib] Bug fixes fo...

2014-10-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2785#issuecomment-59574512 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21

[GitHub] spark pull request: [SPARK-3934] [SPARK-3918] [mllib] Bug fixes fo...

2014-10-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2785#issuecomment-59574499 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21864/consoleFull) for PR 2785 at commit [`9132321`](https://github.com/a

[GitHub] spark pull request: [SPARK-3934] [SPARK-3918] [mllib] Bug fixes fo...

2014-10-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2785#issuecomment-59565017 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21864/consoleFull) for PR 2785 at commit [`9132321`](https://github.com/ap

[GitHub] spark pull request: [SPARK-3934] [SPARK-3918] [mllib] Bug fixes fo...

2014-10-17 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/2785#issuecomment-59564588 @chouqin @manishamde @mengxr Thanks for taking a look! I think stuff is fixed. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-3934] [SPARK-3918] [mllib] Bug fixes fo...

2014-10-14 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/2785#discussion_r18814133 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/tree/impl/DecisionTreeMetadata.scala --- @@ -17,6 +17,8 @@ package org.apache.spark.mllib.tre

[GitHub] spark pull request: [SPARK-3934] [SPARK-3918] [mllib] Bug fixes fo...

2014-10-14 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/2785#discussion_r18814130 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/tree/RandomForest.scala --- @@ -175,6 +175,7 @@ private class RandomForest ( treeToNodeToInd

[GitHub] spark pull request: [SPARK-3934] [SPARK-3918] [mllib] Bug fixes fo...

2014-10-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2785#issuecomment-58994519 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21715/consoleFull) for PR 2785 at commit [`e116473`](https://github.com/a

[GitHub] spark pull request: [SPARK-3934] [SPARK-3918] [mllib] Bug fixes fo...

2014-10-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2785#issuecomment-58994523 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21

[GitHub] spark pull request: [SPARK-3934] [SPARK-3918] [mllib] Bug fixes fo...

2014-10-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2785#issuecomment-58990408 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21715/consoleFull) for PR 2785 at commit [`e116473`](https://github.com/ap

[GitHub] spark pull request: [SPARK-3934] [SPARK-3918] [mllib] Bug fixes fo...

2014-10-13 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/2785#issuecomment-58990194 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-3934] [SPARK-3918] [mllib] Bug fixes fo...

2014-10-13 Thread manishamde
Github user manishamde commented on the pull request: https://github.com/apache/spark/pull/2785#issuecomment-58987978 @jkbradley Thanks. LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-3934] [SPARK-3918] [mllib] Bug fixes fo...

2014-10-13 Thread chouqin
Github user chouqin commented on the pull request: https://github.com/apache/spark/pull/2785#issuecomment-58980429 @jkbradley Thanks for the PR! It looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-3934] [SPARK-3918] [mllib] Bug fixes fo...

2014-10-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2785#issuecomment-58954306 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21

[GitHub] spark pull request: [SPARK-3934] [SPARK-3918] [mllib] Bug fixes fo...

2014-10-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2785#issuecomment-58944843 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amp.lab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/2

[GitHub] spark pull request: [SPARK-3934] [SPARK-3918] [mllib] Bug fixes fo...

2014-10-13 Thread jkbradley
GitHub user jkbradley opened a pull request: https://github.com/apache/spark/pull/2785 [SPARK-3934] [SPARK-3918] [mllib] Bug fixes for RandomForest, DecisionTree SPARK-3934: When run with a mix of unordered categorical and continuous features, on multiclass classification, RandomFo