[GitHub] spark pull request: [SPARK-4036][MLlib]Add Conditional Random Fiel...

2016-03-14 Thread HuJiayin
Github user HuJiayin commented on the pull request: https://github.com/apache/spark/pull/9794#issuecomment-19064 ok!! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: [SPARK-4036][MLlib]Add Conditional Random Fiel...

2016-03-14 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/9794#issuecomment-196665339 Very cool, thanks! I'll check it out. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-4036][MLlib]Add Conditional Random Fiel...

2016-03-13 Thread HuJiayin
Github user HuJiayin commented on the pull request: https://github.com/apache/spark/pull/9794#issuecomment-196132382 @jkbradley I upload the continuous works at https://github.com/Intel-bigdata/CRF Thanks very much. --- If your project is set up for it, you can reply to this email

[GitHub] spark pull request: [SPARK-4036][MLlib]Add Conditional Random Fiel...

2016-03-10 Thread HuJiayin
Github user HuJiayin closed the pull request at: https://github.com/apache/spark/pull/9794 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-4036][MLlib]Add Conditional Random Fiel...

2016-03-10 Thread HuJiayin
GitHub user HuJiayin reopened a pull request: https://github.com/apache/spark/pull/9794 [SPARK-4036][MLlib]Add Conditional Random Fields (CRF) algorithm to Spark MLlib Conditional random fields (CRFs) are a class of statistical modelling method often applied in pattern recognition

[GitHub] spark pull request: [SPARK-4036][MLlib]Add Conditional Random Fiel...

2016-01-05 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/9794#issuecomment-169103860 @HuJiayin I just commented on the JIRA about this, but could we please close this issue for now? We won't be able to get it into MLlib soon. However, you should

[GitHub] spark pull request: [SPARK-4036][MLlib]Add Conditional Random Fiel...

2016-01-05 Thread HuJiayin
Github user HuJiayin closed the pull request at: https://github.com/apache/spark/pull/9794 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-4036][MLlib]Add Conditional Random Fiel...

2015-12-04 Thread HuJiayin
Github user HuJiayin commented on the pull request: https://github.com/apache/spark/pull/9794#issuecomment-161907963 @Lewuathe It is integrated with Spark. The multiple threads are at executor sides for segments parallel. cc @mengxr --- If your project is set up for it, you

[GitHub] spark pull request: [SPARK-4036][MLlib]Add Conditional Random Fiel...

2015-11-20 Thread HuJiayin
Github user HuJiayin commented on the pull request: https://github.com/apache/spark/pull/9794#issuecomment-158318631 @Lewuathe Thanks! I will use Spark API to write a wrapper for it. Then it can use Spark's advantage. The multiple threads you asked will be run in executor side not

[GitHub] spark pull request: [SPARK-4036][MLlib]Add Conditional Random Fiel...

2015-11-19 Thread Lewuathe
Github user Lewuathe commented on a diff in the pull request: https://github.com/apache/spark/pull/9794#discussion_r45423693 --- Diff: mllib/src/main/scala/org/apache/spark/ml/nlp/CRF.scala --- @@ -0,0 +1,173 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] spark pull request: [SPARK-4036][MLlib]Add Conditional Random Fiel...

2015-11-19 Thread Lewuathe
Github user Lewuathe commented on a diff in the pull request: https://github.com/apache/spark/pull/9794#discussion_r45423796 --- Diff: mllib/src/test/scala/org/apache/spark/ml/nlp/CRFTests.scala --- @@ -0,0 +1,27 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request: [SPARK-4036][MLlib]Add Conditional Random Fiel...

2015-11-19 Thread Lewuathe
Github user Lewuathe commented on a diff in the pull request: https://github.com/apache/spark/pull/9794#discussion_r45424372 --- Diff: mllib/src/main/scala/org/apache/spark/ml/nlp/lbfgs.scala --- @@ -0,0 +1,281 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request: [SPARK-4036][MLlib]Add Conditional Random Fiel...

2015-11-19 Thread Lewuathe
Github user Lewuathe commented on a diff in the pull request: https://github.com/apache/spark/pull/9794#discussion_r45423615 --- Diff: mllib/src/main/scala/org/apache/spark/ml/nlp/CRF.scala --- @@ -0,0 +1,173 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] spark pull request: [SPARK-4036][MLlib]Add Conditional Random Fiel...

2015-11-19 Thread Lewuathe
Github user Lewuathe commented on a diff in the pull request: https://github.com/apache/spark/pull/9794#discussion_r45424677 --- Diff: mllib/src/main/scala/org/apache/spark/ml/nlp/lbfgs.scala --- @@ -0,0 +1,281 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request: [SPARK-4036][MLlib]Add Conditional Random Fiel...

2015-11-19 Thread Lewuathe
Github user Lewuathe commented on the pull request: https://github.com/apache/spark/pull/9794#issuecomment-158247811 @HuJiayin Thank you for sharing your patch. Overall this code seems written in standalone application not integrated Spark MLlib/ML. So could you try to

[GitHub] spark pull request: [SPARK-4036][MLlib]Add Conditional Random Fiel...

2015-11-19 Thread HuJiayin
Github user HuJiayin commented on a diff in the pull request: https://github.com/apache/spark/pull/9794#discussion_r45425805 --- Diff: mllib/src/test/scala/org/apache/spark/ml/nlp/CRFTests.scala --- @@ -0,0 +1,27 @@ +/* + * Licensed to the Apache Software Foundation (ASF)