[GitHub] spark pull request: [SPARK-4239] [SQL] support view in HiveQl

2014-11-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/3131 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-4239] [SQL] support view in HiveQl

2014-11-14 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/3131#issuecomment-63134890 Thanks! Merged to master and 1.2 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[GitHub] spark pull request: [SPARK-4239] [SQL] support view in HiveQl

2014-11-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3131#issuecomment-62262792 [Test build #23103 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23103/consoleFull) for PR 3131 at commit [`8a56fd6`](https://gith

[GitHub] spark pull request: [SPARK-4239] [SQL] support view in HiveQl

2014-11-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3131#issuecomment-62262797 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23

[GitHub] spark pull request: [SPARK-4239] [SQL] support view in HiveQl

2014-11-08 Thread adrian-wang
Github user adrian-wang commented on a diff in the pull request: https://github.com/apache/spark/pull/3131#discussion_r20051975 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala --- @@ -68,19 +66,25 @@ private[hive] class HiveMetastoreCatalog(hi

[GitHub] spark pull request: [SPARK-4239] [SQL] support view in HiveQl

2014-11-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3131#issuecomment-62260293 [Test build #23103 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23103/consoleFull) for PR 3131 at commit [`8a56fd6`](https://githu

[GitHub] spark pull request: [SPARK-4239] [SQL] support view in HiveQl

2014-11-08 Thread adrian-wang
Github user adrian-wang commented on a diff in the pull request: https://github.com/apache/spark/pull/3131#discussion_r20051957 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala --- @@ -68,19 +66,25 @@ private[hive] class HiveMetastoreCatalog(hi

[GitHub] spark pull request: [SPARK-4239] [SQL] support view in HiveQl

2014-11-08 Thread adrian-wang
Github user adrian-wang commented on a diff in the pull request: https://github.com/apache/spark/pull/3131#discussion_r20051950 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala --- @@ -428,7 +432,7 @@ private[hive] case class MetastoreRelation

[GitHub] spark pull request: [SPARK-4239] [SQL] support view in HiveQl

2014-11-08 Thread adrian-wang
Github user adrian-wang commented on a diff in the pull request: https://github.com/apache/spark/pull/3131#discussion_r20051793 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala --- @@ -21,6 +21,7 @@ import java.sql.Date import org.apache.hadoop.hive.conf

[GitHub] spark pull request: [SPARK-4239] [SQL] support view in HiveQl

2014-11-07 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/3131#discussion_r20036358 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala --- @@ -68,19 +66,25 @@ private[hive] class HiveMetastoreCatalog(hive:

[GitHub] spark pull request: [SPARK-4239] [SQL] support view in HiveQl

2014-11-07 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/3131#issuecomment-62209309 Thanks for doing this! Since its pretty small and users have been asking for it, I'd love to squeeze this into 1.2 if possible. --- If your project is set up for it, y

[GitHub] spark pull request: [SPARK-4239] [SQL] support view in HiveQl

2014-11-07 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/3131#discussion_r20036121 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala --- @@ -428,7 +432,7 @@ private[hive] case class MetastoreRelation

[GitHub] spark pull request: [SPARK-4239] [SQL] support view in HiveQl

2014-11-07 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/3131#discussion_r20036131 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala --- @@ -21,6 +21,7 @@ import java.sql.Date import org.apache.hadoop.hive.conf.Hi

[GitHub] spark pull request: [SPARK-4239] [SQL] support view in HiveQl

2014-11-07 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/3131#discussion_r20036066 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala --- @@ -68,19 +66,25 @@ private[hive] class HiveMetastoreCatalog(hive:

[GitHub] spark pull request: [SPARK-4239] [SQL] support view in HiveQl

2014-11-06 Thread chenghao-intel
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/3131#issuecomment-62089575 Thanks for the explanation, LGTM. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-4239] [SQL] support view in HiveQl

2014-11-06 Thread adrian-wang
Github user adrian-wang commented on the pull request: https://github.com/apache/spark/pull/3131#issuecomment-62087390 The actual code change is `+33, -17`, so this patch should be easy to review. --- If your project is set up for it, you can reply to this email and have your reply a

[GitHub] spark pull request: [SPARK-4239] [SQL] support view in HiveQl

2014-11-06 Thread adrian-wang
Github user adrian-wang commented on a diff in the pull request: https://github.com/apache/spark/pull/3131#discussion_r19991505 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala --- @@ -68,19 +66,25 @@ private[hive] class HiveMetastoreCatalog(hi

[GitHub] spark pull request: [SPARK-4239] [SQL] support view in HiveQl

2014-11-06 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/3131#discussion_r19989764 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala --- @@ -68,19 +66,25 @@ private[hive] class HiveMetastoreCatalog

[GitHub] spark pull request: [SPARK-4239] [SQL] support view in HiveQl

2014-11-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3131#issuecomment-61974373 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23

[GitHub] spark pull request: [SPARK-4239] [SQL] support view in HiveQl

2014-11-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3131#issuecomment-61974370 [Test build #23001 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23001/consoleFull) for PR 3131 at commit [`e46c056`](https://gith

[GitHub] spark pull request: [SPARK-4239] [SQL] support view in HiveQl

2014-11-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3131#issuecomment-61967571 [Test build #23001 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23001/consoleFull) for PR 3131 at commit [`e46c056`](https://githu

[GitHub] spark pull request: [SPARK-4239] [SQL] support view in HiveQl

2014-11-06 Thread adrian-wang
Github user adrian-wang commented on the pull request: https://github.com/apache/spark/pull/3131#issuecomment-61967157 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-4239] [SQL] support view in HiveQl

2014-11-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3131#issuecomment-61949100 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/22

[GitHub] spark pull request: [SPARK-4239] [SQL] support view in HiveQl

2014-11-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3131#issuecomment-61949093 [Test build #22994 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22994/consoleFull) for PR 3131 at commit [`079290a`](https://gith

[GitHub] spark pull request: [SPARK-4239] [SQL] support view in HiveQl

2014-11-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3131#issuecomment-61944656 [Test build #22994 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22994/consoleFull) for PR 3131 at commit [`079290a`](https://githu

[GitHub] spark pull request: [SPARK-4239] [SQL] support view in HiveQl

2014-11-06 Thread adrian-wang
GitHub user adrian-wang opened a pull request: https://github.com/apache/spark/pull/3131 [SPARK-4239] [SQL] support view in HiveQl Currently still not support view like CREATE VIEW view3(valoo) TBLPROPERTIES ("fear" = "factor") AS SELECT upper(value) FROM src WHERE