Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/4010#issuecomment-72128334
Thanks! Merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/4010
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4010#issuecomment-70792871
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4010#issuecomment-70792865
[Test build #25874 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25874/consoleFull)
for PR 4010 at commit
[`6343800`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4010#issuecomment-70787881
[Test build #25874 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25874/consoleFull)
for PR 4010 at commit
[`6343800`](https://githu
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/4010#issuecomment-69848787
LGTM, thanks for pointing out 3684fd2 fixes this!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If you
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/3910#issuecomment-69777383
Closing this as @yhuai had pointed out in #4010 that #3987 already fixed
this issue.
---
If your project is set up for it, you can reply to this email and have your
re
Github user liancheng closed the pull request at:
https://github.com/apache/spark/pull/3910
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is e
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/3910#discussion_r22875668
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala
---
@@ -153,11 +153,11 @@ object PartialAggregation {
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4010#issuecomment-69669785
[Test build #25431 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25431/consoleFull)
for PR 4010 at commit
[`6cfadd2`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4010#issuecomment-69669791
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4010#issuecomment-69663741
[Test build #25430 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25430/consoleFull)
for PR 4010 at commit
[`6042328`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4010#issuecomment-69663749
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4010#issuecomment-69660815
[Test build #25431 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25431/consoleFull)
for PR 4010 at commit
[`6cfadd2`](https://githu
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4010#issuecomment-69653410
[Test build #25430 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25430/consoleFull)
for PR 4010 at commit
[`6042328`](https://githu
GitHub user yhuai opened a pull request:
https://github.com/apache/spark/pull/4010
[SPARK-4296][SQL] Trims aliases when resolving and checking aggregate
expressions
This PR tries to address test failures in #3910. @liancheng @marmbrus
You can merge this pull request into a Git re
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/3910#discussion_r22806871
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala
---
@@ -153,11 +153,11 @@ object PartialAggregation {
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3910#issuecomment-69480293
[Test build #563 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/563/consoleFull)
for PR 3910 at commit
[`807e13e`](https://githu
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3910#issuecomment-69479333
[Test build #563 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/563/consoleFull)
for PR 3910 at commit
[`807e13e`](https://github
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3910#issuecomment-68962344
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3910#issuecomment-68962335
[Test build #25123 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25123/consoleFull)
for PR 3910 at commit
[`807e13e`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3910#issuecomment-68958456
[Test build #25123 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25123/consoleFull)
for PR 3910 at commit
[`807e13e`](https://githu
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3910#issuecomment-68864129
[Test build #25100 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25100/consoleFull)
for PR 3910 at commit
[`60d10fb`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3910#issuecomment-68864133
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3910#issuecomment-68864117
[Test build #25100 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25100/consoleFull)
for PR 3910 at commit
[`60d10fb`](https://githu
GitHub user liancheng opened a pull request:
https://github.com/apache/spark/pull/3910
[SPARK-4296][SQL] Trims aliases when resolving and checking aggregate
expressions
This PR is a follow-up of PR #3248. We should not only trim `Alias` around
`GetField` but also all unnamed expre
26 matches
Mail list logo
