Github user ueshin closed the pull request at:
https://github.com/apache/spark/pull/3184
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user ueshin commented on the pull request:
https://github.com/apache/spark/pull/3184#issuecomment-65022825
This was merged to master 2c2e7a4 and 1d7ee2b, so I'll close this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub a
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/3184#issuecomment-63901022
Thanks for cleaning all of this up. I've merged to master and 1.2
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/3184#discussion_r20687030
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/GeneratedAggregate.scala
---
@@ -117,15 +119,15 @@ case class GeneratedAggregate(
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3184#issuecomment-63751021
[Test build #23648 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23648/consoleFull)
for PR 3184 at commit
[`8168c42`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3184#issuecomment-63751028
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3184#issuecomment-63744692
[Test build #23648 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23648/consoleFull)
for PR 3184 at commit
[`8168c42`](https://githu
Github user ueshin commented on the pull request:
https://github.com/apache/spark/pull/3184#issuecomment-63744107
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featu
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3184#issuecomment-63707287
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3184#issuecomment-63707265
**[Test build #23613 timed
out](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23613/consoleFull)**
for PR 3184 at commit
[`66fdb0a`](https://git
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3184#issuecomment-63700191
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3184#issuecomment-63700184
[Test build #23615 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23615/consoleFull)
for PR 3184 at commit
[`8168c42`](https://gith
Github user ueshin commented on the pull request:
https://github.com/apache/spark/pull/3184#issuecomment-63690703
@marmbrus, I refined codes.
Could you check them please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3184#issuecomment-63688651
[Test build #23615 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23615/consoleFull)
for PR 3184 at commit
[`8168c42`](https://githu
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3184#issuecomment-63687930
[Test build #23613 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23613/consoleFull)
for PR 3184 at commit
[`66fdb0a`](https://githu
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/3184#discussion_r20489592
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/GeneratedAggregate.scala
---
@@ -117,15 +119,15 @@ case class GeneratedAggregate(
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/3184#discussion_r20399046
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/GeneratedAggregate.scala
---
@@ -117,15 +119,15 @@ case class GeneratedAggregate(
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/3184#discussion_r20392048
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/GeneratedAggregate.scala
---
@@ -117,15 +119,15 @@ case class GeneratedAggregate(
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3184#issuecomment-62717284
[Test build #23266 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23266/consoleFull)
for PR 3184 at commit
[`6186eb4`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3184#issuecomment-62717289
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23
Github user ueshin commented on the pull request:
https://github.com/apache/spark/pull/3184#issuecomment-62711735
Added some fixes related to aggregation of `DecimalType`.
BTW, is there a way to test `GeneratedAggregate`?
---
If your project is set up for it, you can reply to
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3184#issuecomment-62710065
[Test build #23266 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23266/consoleFull)
for PR 3184 at commit
[`6186eb4`](https://githu
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3184#issuecomment-62709228
[Test build #23264 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23264/consoleFull)
for PR 3184 at commit
[`d2975f6`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3184#issuecomment-62709234
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3184#issuecomment-62702178
[Test build #23264 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23264/consoleFull)
for PR 3184 at commit
[`d2975f6`](https://githu
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3184#issuecomment-62513061
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3184#issuecomment-62513060
[Test build #23206 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23206/consoleFull)
for PR 3184 at commit
[`917e533`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3184#issuecomment-62508302
[Test build #23206 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23206/consoleFull)
for PR 3184 at commit
[`917e533`](https://githu
Github user markhamstra commented on a diff in the pull request:
https://github.com/apache/spark/pull/3184#discussion_r20125624
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DslQuerySuite.scala
---
@@ -195,6 +195,18 @@ class DslQuerySuite extends QueryTest {
asser
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/3184#discussion_r20124918
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DslQuerySuite.scala
---
@@ -195,6 +195,18 @@ class DslQuerySuite extends QueryTest {
assert(emp
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/3184#discussion_r20123497
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DslQuerySuite.scala
---
@@ -195,6 +195,18 @@ class DslQuerySuite extends QueryTest {
assert(e
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3184#issuecomment-62410131
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3184#issuecomment-62410123
[Test build #23152 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23152/consoleFull)
for PR 3184 at commit
[`65b7dd2`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3184#issuecomment-62397623
[Test build #23152 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23152/consoleFull)
for PR 3184 at commit
[`65b7dd2`](https://githu
GitHub user ueshin opened a pull request:
https://github.com/apache/spark/pull/3184
[SPARK-4318][SQL] Fix empty sum distinct.
Executing sum distinct for empty table throws
`java.lang.UnsupportedOperationException: empty.reduceLeft`.
You can merge this pull request into a Git reposi
35 matches
Mail list logo
