[GitHub] spark pull request: [SPARK-4439] [MLlib] add python api for random...

2014-11-20 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/3320#issuecomment-63777609 @davies We updated the `RandomForest` API in #3374 . Now `RandomForest` returns a `RandomForestModel`. Could you rebase and update this PR? Thanks! --- If your project

[GitHub] spark pull request: [SPARK-4439] [MLlib] add python api for random...

2014-11-20 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/3320#issuecomment-63853606 @mengxr done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-4439] [MLlib] add python api for random...

2014-11-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3320#issuecomment-63856051 [Test build #23677 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23677/consoleFull) for PR 3320 at commit

[GitHub] spark pull request: [SPARK-4439] [MLlib] add python api for random...

2014-11-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3320#issuecomment-63869584 [Test build #23677 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23677/consoleFull) for PR 3320 at commit

[GitHub] spark pull request: [SPARK-4439] [MLlib] add python api for random...

2014-11-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3320#issuecomment-63869599 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4439] [MLlib] add python api for random...

2014-11-20 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/3320#discussion_r20676259 --- Diff: python/pyspark/mllib/tree.py --- @@ -181,8 +182,206 @@ def trainRegressor(data, categoricalFeaturesInfo,

[GitHub] spark pull request: [SPARK-4439] [MLlib] add python api for random...

2014-11-20 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/3320#discussion_r20676265 --- Diff: python/pyspark/mllib/tree.py --- @@ -181,8 +182,206 @@ def trainRegressor(data, categoricalFeaturesInfo,

[GitHub] spark pull request: [SPARK-4439] [MLlib] add python api for random...

2014-11-20 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/3320#discussion_r20676263 --- Diff: python/pyspark/mllib/tree.py --- @@ -181,8 +182,206 @@ def trainRegressor(data, categoricalFeaturesInfo,

[GitHub] spark pull request: [SPARK-4439] [MLlib] add python api for random...

2014-11-20 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/3320#issuecomment-63877350 @davies Thanks for adding this API! I made a few small comments. Other than those, LGTM --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-4439] [MLlib] add python api for random...

2014-11-20 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/3320#issuecomment-63880444 @jkbradley done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-4439] [MLlib] add python api for random...

2014-11-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3320#issuecomment-63880964 [Test build #23684 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23684/consoleFull) for PR 3320 at commit

[GitHub] spark pull request: [SPARK-4439] [MLlib] add python api for random...

2014-11-20 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/3320#issuecomment-63881779 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: [SPARK-4439] [MLlib] add python api for random...

2014-11-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3320#issuecomment-63893839 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4439] [MLlib] add python api for random...

2014-11-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3320#issuecomment-63893828 [Test build #23684 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23684/consoleFull) for PR 3320 at commit

[GitHub] spark pull request: [SPARK-4439] [MLlib] add python api for random...

2014-11-20 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/3320#issuecomment-63899911 Merged into master and branch-1.2. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-4439] [MLlib] add python api for random...

2014-11-20 Thread manishamde
Github user manishamde commented on the pull request: https://github.com/apache/spark/pull/3320#issuecomment-63900346 Thanks a lot @davies --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-4439] [MLlib] add python api for random...

2014-11-20 Thread davies
Github user davies closed the pull request at: https://github.com/apache/spark/pull/3320 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-4439] [MLlib] add python api for random...

2014-11-19 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/3320#discussion_r20591273 --- Diff: python/pyspark/mllib/tree.py --- @@ -181,8 +180,191 @@ def trainRegressor(data, categoricalFeaturesInfo,

[GitHub] spark pull request: [SPARK-4439] [MLlib] add python api for random...

2014-11-19 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/3320#discussion_r20618709 --- Diff: python/pyspark/mllib/tree.py --- @@ -181,8 +180,191 @@ def trainRegressor(data, categoricalFeaturesInfo, model.predict(rdd).collect()

[GitHub] spark pull request: [SPARK-4439] [MLlib] add python api for random...

2014-11-19 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/3320#discussion_r20619421 --- Diff: python/pyspark/mllib/tree.py --- @@ -181,8 +180,191 @@ def trainRegressor(data, categoricalFeaturesInfo, model.predict(rdd).collect()

[GitHub] spark pull request: [SPARK-4439] [MLlib] add python api for random...

2014-11-19 Thread manishamde
Github user manishamde commented on a diff in the pull request: https://github.com/apache/spark/pull/3320#discussion_r20619737 --- Diff: python/pyspark/mllib/tree.py --- @@ -181,8 +180,191 @@ def trainRegressor(data, categoricalFeaturesInfo,

[GitHub] spark pull request: [SPARK-4439] [MLlib] add python api for random...

2014-11-17 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/3320#issuecomment-63364920 @JoshRosen corrected, thanks! I had these mistakes many times :-( --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [SPARK-4439] [MLlib] add python api for random...

2014-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3320#issuecomment-63371418 [Test build #23487 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23487/consoleFull) for PR 3320 at commit

[GitHub] spark pull request: [SPARK-4439] [MLlib] add python api for random...

2014-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3320#issuecomment-63371428 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4439] [MLlib] add python api for random...

2014-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3320#issuecomment-63390282 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4439] [MLlib] add python api for random...

2014-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3320#issuecomment-63390276 [Test build #23495 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23495/consoleFull) for PR 3320 at commit

[GitHub] spark pull request: [SPARK-4439] [MLlib] add python api for random...

2014-11-17 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/3320#discussion_r20479562 --- Diff: python/pyspark/mllib/tree.py --- @@ -181,8 +180,191 @@ def trainRegressor(data, categoricalFeaturesInfo, model.predict(rdd).collect()

[GitHub] spark pull request: [SPARK-4439] [MLlib] add python api for random...

2014-11-17 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/3320#discussion_r20479607 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/api/python/PythonMLLibAPI.scala --- @@ -465,6 +465,40 @@ class PythonMLLibAPI extends Serializable {

[GitHub] spark pull request: [SPARK-4439] [MLlib] add python api for random...

2014-11-17 Thread manishamde
Github user manishamde commented on a diff in the pull request: https://github.com/apache/spark/pull/3320#discussion_r20479768 --- Diff: python/pyspark/mllib/tree.py --- @@ -181,8 +180,191 @@ def trainRegressor(data, categoricalFeaturesInfo,

[GitHub] spark pull request: [SPARK-4439] [MLlib] add python api for random...

2014-11-17 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/3320#discussion_r20480563 --- Diff: python/pyspark/mllib/tree.py --- @@ -181,8 +180,191 @@ def trainRegressor(data, categoricalFeaturesInfo, model.predict(rdd).collect()

[GitHub] spark pull request: [SPARK-4439] [MLlib] add python api for random...

2014-11-17 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/3320#discussion_r20481058 --- Diff: python/pyspark/mllib/tree.py --- @@ -181,8 +180,191 @@ def trainRegressor(data, categoricalFeaturesInfo, model.predict(rdd).collect()

[GitHub] spark pull request: [SPARK-4439] [MLlib] add python api for random...

2014-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3320#issuecomment-63410715 [Test build #23527 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23527/consoleFull) for PR 3320 at commit

[GitHub] spark pull request: [SPARK-4439] [MLlib] add python api for random...

2014-11-17 Thread manishamde
Github user manishamde commented on a diff in the pull request: https://github.com/apache/spark/pull/3320#discussion_r20481177 --- Diff: python/pyspark/mllib/tree.py --- @@ -181,8 +180,191 @@ def trainRegressor(data, categoricalFeaturesInfo,

[GitHub] spark pull request: [SPARK-4439] [MLlib] add python api for random...

2014-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3320#issuecomment-63411351 [Test build #23528 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23528/consoleFull) for PR 3320 at commit

[GitHub] spark pull request: [SPARK-4439] [MLlib] add python api for random...

2014-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3320#issuecomment-63416979 [Test build #23527 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23527/consoleFull) for PR 3320 at commit

[GitHub] spark pull request: [SPARK-4439] [MLlib] add python api for random...

2014-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3320#issuecomment-63416983 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4439] [MLlib] add python api for random...

2014-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3320#issuecomment-63418194 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4439] [MLlib] add python api for random...

2014-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3320#issuecomment-63418185 [Test build #23528 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23528/consoleFull) for PR 3320 at commit