[GitHub] spark pull request: [SPARK-4485][SQL] (1) Add broadcast hash outer...

2015-08-04 Thread kai-zeng
Github user kai-zeng commented on a diff in the pull request: https://github.com/apache/spark/pull/7162#discussion_r36235723 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/ShuffledHashOuterJoin.scala --- @@ -0,0 +1,85 @@ +/* + * Licensed to the Apac

[GitHub] spark pull request: [SPARK-4485][SQL] (1) Add broadcast hash outer...

2015-08-04 Thread kai-zeng
Github user kai-zeng commented on a diff in the pull request: https://github.com/apache/spark/pull/7162#discussion_r36235248 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/ShuffledHashOuterJoin.scala --- @@ -0,0 +1,85 @@ +/* + * Licensed to the Apac

[GitHub] spark pull request: [SPARK-4485][SQL] (1) Add broadcast hash outer...

2015-08-04 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/7162#discussion_r36234861 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/ShuffledHashOuterJoin.scala --- @@ -0,0 +1,85 @@ +/* + * Licensed to the Apa

[GitHub] spark pull request: [SPARK-4485][SQL] (1) Add broadcast hash outer...

2015-08-04 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/7162#discussion_r36234637 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/ShuffledHashOuterJoin.scala --- @@ -0,0 +1,85 @@ +/* + * Licensed to the Apa

[GitHub] spark pull request: [SPARK-4485][SQL] (1) Add broadcast hash outer...

2015-08-04 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/7162#discussion_r36234539 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/ShuffledHashOuterJoin.scala --- @@ -0,0 +1,85 @@ +/* + * Licensed to the Apa

[GitHub] spark pull request: [SPARK-4485][SQL] (1) Add broadcast hash outer...

2015-08-04 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/7162#discussion_r36234484 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/ShuffledHashOuterJoin.scala --- @@ -0,0 +1,85 @@ +/* + * Licensed to the Apa

[GitHub] spark pull request: [SPARK-4485][SQL] (1) Add broadcast hash outer...

2015-07-06 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/7162#discussion_r34002025 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/SparkPlanTest.scala --- @@ -92,27 +153,25 @@ object SparkPlanTest { * @param expect

[GitHub] spark pull request: [SPARK-4485][SQL] (1) Add broadcast hash outer...

2015-07-06 Thread kai-zeng
Github user kai-zeng commented on a diff in the pull request: https://github.com/apache/spark/pull/7162#discussion_r34001466 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/SparkPlanTest.scala --- @@ -92,27 +153,25 @@ object SparkPlanTest { * @param expecte

[GitHub] spark pull request: [SPARK-4485][SQL] (1) Add broadcast hash outer...

2015-07-06 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/7162#discussion_r33995787 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/SparkPlanTest.scala --- @@ -92,27 +153,25 @@ object SparkPlanTest { * @param expect

[GitHub] spark pull request: [SPARK-4485][SQL] (1) Add broadcast hash outer...

2015-07-06 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/7162#discussion_r33995110 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/SparkPlanTest.scala --- @@ -92,27 +153,25 @@ object SparkPlanTest { * @param expect

[GitHub] spark pull request: [SPARK-4485][SQL] (1) Add broadcast hash outer...

2015-07-06 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/7162#discussion_r33974944 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashOuterJoin.scala --- @@ -0,0 +1,121 @@ +/* + * Licensed to the Ap

[GitHub] spark pull request: [SPARK-4485][SQL] (1) Add broadcast hash outer...

2015-07-06 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/7162#issuecomment-118977442 Here are some performance results: ![screen shot 2015-07-06 at 12 46 32 pm](https://cloud.githubusercontent.com/assets/527/8531650/c31266f4-23dd-11e5-849b-e3d00

[GitHub] spark pull request: [SPARK-4485][SQL] (1) Add broadcast hash outer...

2015-07-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/7162 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-4485][SQL] (1) Add broadcast hash outer...

2015-07-06 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/7162#issuecomment-119003802 I'm going to go ahead and merge this to unblock other work on the plan tests. We can take care of threadpool consolidation in a followup. Thanks! --- If your project

[GitHub] spark pull request: [SPARK-4485][SQL] (1) Add broadcast hash outer...

2015-07-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7162#issuecomment-118449132 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-4485][SQL] (1) Add broadcast hash outer...

2015-07-03 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7162#issuecomment-118439069 [Test build #36517 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36517/consoleFull) for PR 7162 at commit [`3742359`](https://gith

[GitHub] spark pull request: [SPARK-4485][SQL] (1) Add broadcast hash outer...

2015-07-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7162#issuecomment-118438978 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-4485][SQL] (1) Add broadcast hash outer...

2015-07-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7162#issuecomment-118438970 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-4485][SQL] (1) Add broadcast hash outer...

2015-07-03 Thread kai-zeng
Github user kai-zeng commented on a diff in the pull request: https://github.com/apache/spark/pull/7162#discussion_r33883065 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashOuterJoin.scala --- @@ -0,0 +1,120 @@ +/* + * Licensed to the Ap

[GitHub] spark pull request: [SPARK-4485][SQL] (1) Add broadcast hash outer...

2015-07-03 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/7162#discussion_r33883033 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashOuterJoin.scala --- @@ -0,0 +1,120 @@ +/* + * Licensed to the Ap

[GitHub] spark pull request: [SPARK-4485][SQL] (1) Add broadcast hash outer...

2015-07-03 Thread kai-zeng
Github user kai-zeng commented on a diff in the pull request: https://github.com/apache/spark/pull/7162#discussion_r33882839 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashOuterJoin.scala --- @@ -0,0 +1,120 @@ +/* + * Licensed to the Ap

[GitHub] spark pull request: [SPARK-4485][SQL] (1) Add broadcast hash outer...

2015-07-03 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/7162#discussion_r33882776 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashOuterJoin.scala --- @@ -0,0 +1,120 @@ +/* + * Licensed to the Ap

[GitHub] spark pull request: [SPARK-4485][SQL] (1) Add broadcast hash outer...

2015-07-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7162#issuecomment-117963252 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-4485][SQL] (1) Add broadcast hash outer...

2015-07-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7162#issuecomment-117938040 [Test build #36360 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36360/consoleFull) for PR 7162 at commit [`14e4bf8`](https://gith

[GitHub] spark pull request: [SPARK-4485][SQL] (1) Add broadcast hash outer...

2015-07-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7162#issuecomment-117937885 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-4485][SQL] (1) Add broadcast hash outer...

2015-07-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7162#issuecomment-117937901 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-4485][SQL] (1) Add broadcast hash outer...

2015-07-01 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/7162#discussion_r33742969 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala --- @@ -118,8 +118,19 @@ private[sql] abstract class SparkStrategies exten

[GitHub] spark pull request: [SPARK-4485][SQL] (1) Add broadcast hash outer...

2015-07-01 Thread kai-zeng
Github user kai-zeng commented on the pull request: https://github.com/apache/spark/pull/7162#issuecomment-117839182 cc @marmbrus --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-4485][SQL] (1) Add broadcast hash outer...

2015-07-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7162#issuecomment-117799843 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-4485][SQL] (1) Add broadcast hash outer...

2015-07-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7162#issuecomment-117764781 [Test build #36285 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36285/consoleFull) for PR 7162 at commit [`dc5127e`](https://gith

[GitHub] spark pull request: [SPARK-4485][SQL] (1) Add broadcast hash outer...

2015-07-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7162#issuecomment-117764343 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-4485][SQL] (1) Add broadcast hash outer...

2015-07-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7162#issuecomment-117764373 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have