Github user EntilZha closed the pull request at:
https://github.com/apache/spark/pull/3405
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is en
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/3405#issuecomment-64975169
Yep - that's the best way to proceed. Close this PR, if you don't mind. I
can update the JIRA.
---
If your project is set up for it, you can reply to this email and hav
Github user EntilZha commented on the pull request:
https://github.com/apache/spark/pull/3405#issuecomment-64969668
Works for me for building against master branch. Close PR and close issue
with reference to #3058?
---
If your project is set up for it, you can reply to this email and
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/3405#issuecomment-64967038
@pwendell @EntilZha It seems to work for me. I see fewer warnings, and no
errors. The steps in the JIRA succeed for me.
---
If your project is set up for it, you can repl
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/3405#issuecomment-64966282
@EntilZha would you mind trying to build against the master branch and
seeing if it works?
---
If your project is set up for it, you can reply to this email and have yo
Github user EntilZha commented on the pull request:
https://github.com/apache/spark/pull/3405#issuecomment-64959721
@srowen, definitely a good question. Looks like as #3058 was closed/merged
in so this might be fixed now?
---
If your project is set up for it, you can reply to this em
Github user EntilZha commented on the pull request:
https://github.com/apache/spark/pull/3405#issuecomment-64918891
@pwendell, I am building on Java 8.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/3405#issuecomment-64918222
@pwendell There's a slightly different mystery here -- even if javadoc
warnings are generated, why are they an error in just this module? and why is
javadoc run at all for
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/3405#issuecomment-64918092
@EntilZha are you building with Java 8? @srowen so did we decide this isn't
just an instance of #3058
---
If your project is set up for it, you can reply to this email
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/3405#issuecomment-64539308
I think we should add @ueshin 's patch at
https://github.com/apache/spark/pull/3058 which should properly disable javadoc
8 missing javadoc warnings anyway. I think this i
Github user ueshin commented on the pull request:
https://github.com/apache/spark/pull/3405#issuecomment-64514010
Hmm, I can't reproduce the situation that the javadoc messages are just
warnings.
In my environment, the build succeeds in Java7 or fails with javadoc error
messages i
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/3405#issuecomment-64380418
I don't think so in the sense that it only affects Java 8, and should turn
_off_ errors for missing javadoc. Here, the javadoc messages are indeed just
warnings, but SBT s
Github user ueshin commented on the pull request:
https://github.com/apache/spark/pull/3405#issuecomment-64351835
Hi, is this related to #3058?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user EntilZha commented on the pull request:
https://github.com/apache/spark/pull/3405#issuecomment-64262913
Agreed, requiring to fill in the javadoc is tedious (it was tedious just
entering in TODOs, let alone real docs). Who might be someone good to ping that
would know more
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/3405#issuecomment-64115070
Yeah, I'm not clear why only this module is treating javadoc warnings as
errors. Ideally we'd figure that out too. But strictly speaking it's just
necessary to figure out
Github user aarondav commented on the pull request:
https://github.com/apache/spark/pull/3405#issuecomment-64114213
Regarding filling in the javadoc, why do we have to add `@param` and
`@return` everywhere? Other Spark javadoc doesn't necessarily have this, and
where it's not used it'
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/3405#issuecomment-64099835
I stared at the SBT config for a while here, and I don't understand how it
works. I see some bits that seem to exclude these packages, but they're in the
TestSettings sect
Github user aarondav commented on the pull request:
https://github.com/apache/spark/pull/3405#issuecomment-64076199
No clue!
On Fri, Nov 21, 2014 at 6:11 PM, Pedro Rodriguez
wrote:
> In theory yes, I think that would fix the issue. What change would be
> neede
Github user EntilZha commented on the pull request:
https://github.com/apache/spark/pull/3405#issuecomment-64064542
In theory yes, I think that would fix the issue. What change would be
needed for that?
---
If your project is set up for it, you can reply to this email and have your
r
Github user aarondav commented on the pull request:
https://github.com/apache/spark/pull/3405#issuecomment-64057897
We actually don't want these methods to be exposed in Javadoc right now,
none of them are actually public. Java simply does not expose the
fine-grained visibility
Github user EntilZha commented on the pull request:
https://github.com/apache/spark/pull/3405#issuecomment-64051631
In sbt they are warnings, so I suppose the question is as you posed, what
configuration is different. I have scoured through the directories/config files
+ search on git
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/3405#issuecomment-64033369
Hm, I doubt it, but don't know 100%. That change should affect how Java
code gets generated from Scala code for purposes of generating one big set of
docs. The "errors" he
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/3405#issuecomment-64033190
Maybe related to https://github.com/apache/spark/commit/293672c4? Although
that should apply for all projects...
---
If your project is set up for it, you can reply to th
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/3405#issuecomment-64032182
No, that's really not a solution to put in a bunch of dummy TODOs. The
Javadoc messages are just warnings. I do not see why just the network common
module ends up showing
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3405#issuecomment-64031328
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
GitHub user EntilZha opened a pull request:
https://github.com/apache/spark/pull/3405
[SPARK-4543] Javadoc failure for network-common causes publish-local to fail
Pull request to accompany: https://issues.apache.org/jira/browse/SPARK-4543
Javadoc is missing from network-comm
26 matches
Mail list logo
