Github user sarutak closed the pull request at:
https://github.com/apache/spark/pull/3433
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user sarutak commented on the pull request:
https://github.com/apache/spark/pull/3433#issuecomment-69473753
O.K, closing this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this f
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/3433#issuecomment-69473685
Yeah, agreed. Lets block this on SPARK-4867, but once that is fixed I'd
love to have a native `concat` function.
---
If your project is set up for it, you can reply to
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/3433#issuecomment-69473691
For now though I propose we close this issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user sarutak commented on the pull request:
https://github.com/apache/spark/pull/3433#issuecomment-69209267
So, how about adding `CONCAT` function working like the function Hive has?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/3433#issuecomment-68392344
Hmm, okay. It might be a little confusing to users if in one version it
does concatenation and in the other it is an `OR`. My other concern here is
that the new concat
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3433#issuecomment-68370097
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3433#issuecomment-68370094
[Test build #24896 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24896/consoleFull)
for PR 3433 at commit
[`6b47555`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3433#issuecomment-68363448
[Test build #24896 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24896/consoleFull)
for PR 3433 at commit
[`6b47555`](https://githu
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3433#issuecomment-68141153
[Test build #24836 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24836/consoleFull)
for PR 3433 at commit
[`9b94d48`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3433#issuecomment-68141157
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3433#issuecomment-68139017
[Test build #24836 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24836/consoleFull)
for PR 3433 at commit
[`9b94d48`](https://githu
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3433#issuecomment-68020570
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3433#issuecomment-68020569
[Test build #24749 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24749/consoleFull)
for PR 3433 at commit
[`85469b4`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3433#issuecomment-68016951
[Test build #24749 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24749/consoleFull)
for PR 3433 at commit
[`85469b4`](https://githu
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/3433#discussion_r22243404
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/SqlParser.scala ---
@@ -362,7 +362,7 @@ class SqlParser extends AbstractSparkSQLParser {
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/3433#discussion_r22204669
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/SqlParser.scala ---
@@ -362,7 +362,7 @@ class SqlParser extends AbstractSparkSQLParser {
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3433#issuecomment-67438060
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3433#issuecomment-67438057
[Test build #24565 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24565/consoleFull)
for PR 3433 at commit
[`372d665`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3433#issuecomment-67433690
[Test build #24565 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24565/consoleFull)
for PR 3433 at commit
[`372d665`](https://githu
Github user sarutak commented on the pull request:
https://github.com/apache/spark/pull/3433#issuecomment-67433680
Thanks @marmbrus .
In Hive, `||` is assigned as Logical OR operator and Hive has `concat`
function instead of `||` so I don't think we need change for `HiveQL.scala`.
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/3433#issuecomment-67412595
One minor style comment. Also, does Hive support this? If so we should
add it to `HiveQl.scala` as well. Otherwise this LGTM
---
If your project is set up for it, yo
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/3433#discussion_r22011924
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala
---
@@ -272,3 +272,31 @@ case class Substring(str: Ex
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3433#issuecomment-66395356
[Test build #24278 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24278/consoleFull)
for PR 3433 at commit
[`8b162ec`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3433#issuecomment-66395358
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3433#issuecomment-66389406
[Test build #24278 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24278/consoleFull)
for PR 3433 at commit
[`8b162ec`](https://githu
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/3433#discussion_r21136072
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/SqlParser.scala ---
@@ -362,7 +362,7 @@ class SqlParser extends AbstractSparkSQLParser {
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/3433#discussion_r21131159
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/SqlParser.scala ---
@@ -362,7 +362,7 @@ class SqlParser extends AbstractSparkSQLParser {
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3433#issuecomment-65013533
[Test build #23960 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23960/consoleFull)
for PR 3433 at commit
[`66df576`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3433#issuecomment-65013537
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3433#issuecomment-65010309
[Test build #23960 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23960/consoleFull)
for PR 3433 at commit
[`66df576`](https://githu
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3433#issuecomment-64286010
[Test build #23797 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23797/consoleFull)
for PR 3433 at commit
[`5437d49`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3433#issuecomment-64286016
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3433#issuecomment-64276373
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3433#issuecomment-64276367
[Test build #23795 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23795/consoleFull)
for PR 3433 at commit
[`0e5062c`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3433#issuecomment-64276366
[Test build #23797 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23797/consoleFull)
for PR 3433 at commit
[`5437d49`](https://githu
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3433#issuecomment-64275127
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3433#issuecomment-64275118
[Test build #23794 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23794/consoleFull)
for PR 3433 at commit
[`f4bbec3`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3433#issuecomment-64274543
[Test build #23795 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23795/consoleFull)
for PR 3433 at commit
[`0e5062c`](https://githu
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3433#issuecomment-64273476
[Test build #23794 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23794/consoleFull)
for PR 3433 at commit
[`f4bbec3`](https://githu
GitHub user sarutak opened a pull request:
https://github.com/apache/spark/pull/3433
[SPARK-4576][SQL] Add concatenation operator
The standard SQL defines || as a concatenation operator.
The operator makes concatenated string from 2 operands.
You can merge this pull request into
41 matches
Mail list logo
