Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/3461#issuecomment-65322960
@jkbradley minor: Shall we merge RF and GBT into a single section called
tree ensembles (random forests and gradient-boosted trees (on the same level
as decision trees) ?
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/3461#issuecomment-65352254
@mengxr Sure, that seems like a good solution to the suggestion from
@manishamde
Will do.
---
If your project is set up for it, you can reply to this email and
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/3461#discussion_r2669
--- Diff: docs/mllib-decision-tree.md ---
@@ -103,36 +106,73 @@ and the resulting `$M-1$` split candidates are
considered.
### Stopping rule
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/3461#discussion_r2725
--- Diff: docs/mllib-decision-tree.md ---
@@ -103,36 +106,73 @@ and the resulting `$M-1$` split candidates are
considered.
### Stopping rule
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/3461#discussion_r2857
--- Diff: docs/mllib-decision-tree.md ---
@@ -103,36 +106,73 @@ and the resulting `$M-1$` split candidates are
considered.
### Stopping rule
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/3461#discussion_r21112016
--- Diff: docs/mllib-decision-tree.md ---
@@ -103,36 +106,73 @@ and the resulting `$M-1$` split candidates are
considered.
### Stopping rule
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/3461#discussion_r21112912
--- Diff: docs/mllib-decision-tree.md ---
@@ -103,36 +106,73 @@ and the resulting `$M-1$` split candidates are
considered.
### Stopping rule
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/3461#discussion_r21113406
--- Diff: docs/mllib-decision-tree.md ---
@@ -103,36 +106,73 @@ and the resulting `$M-1$` split candidates are
considered.
### Stopping rule
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/3461#discussion_r21113669
--- Diff: docs/mllib-gbt.md ---
@@ -0,0 +1,308 @@
+---
+layout: global
+title: Gradient-Boosted Trees - MLlib
+displayTitle: a
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/3461#discussion_r21113959
--- Diff: docs/mllib-gbt.md ---
@@ -0,0 +1,308 @@
+---
+layout: global
+title: Gradient-Boosted Trees - MLlib
+displayTitle: a
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/3461#discussion_r21114104
--- Diff: docs/mllib-gbt.md ---
@@ -0,0 +1,308 @@
+---
+layout: global
+title: Gradient-Boosted Trees - MLlib
+displayTitle: a
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/3461#issuecomment-65124916
@manishamde Thanks for the feedback! I made the fixes, except for the
default values for all optional parameters + ensembles section issues. Let me
know if you
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3461#issuecomment-65125044
[Test build #23997 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23997/consoleFull)
for PR 3461 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3461#issuecomment-65136493
[Test build #23997 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23997/consoleFull)
for PR 3461 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3461#issuecomment-65136503
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user manishamde commented on a diff in the pull request:
https://github.com/apache/spark/pull/3461#discussion_r21133672
--- Diff: docs/mllib-decision-tree.md ---
@@ -103,36 +106,73 @@ and the resulting `$M-1$` split candidates are
considered.
### Stopping rule
Github user manishamde commented on the pull request:
https://github.com/apache/spark/pull/3461#issuecomment-65167028
@jkbradley The GBDT sections looks good to me but the subsection on
Comparison with RFs could possibly be moved towards the end. It breaks the flow
in my opinion.
Github user manishamde commented on a diff in the pull request:
https://github.com/apache/spark/pull/3461#discussion_r21067775
--- Diff: docs/mllib-decision-tree.md ---
@@ -103,36 +106,73 @@ and the resulting `$M-1$` split candidates are
considered.
### Stopping rule
Github user manishamde commented on a diff in the pull request:
https://github.com/apache/spark/pull/3461#discussion_r21067802
--- Diff: docs/mllib-decision-tree.md ---
@@ -103,36 +106,73 @@ and the resulting `$M-1$` split candidates are
considered.
### Stopping rule
Github user manishamde commented on a diff in the pull request:
https://github.com/apache/spark/pull/3461#discussion_r21067657
--- Diff: docs/mllib-decision-tree.md ---
@@ -103,36 +106,73 @@ and the resulting `$M-1$` split candidates are
considered.
### Stopping rule
Github user manishamde commented on a diff in the pull request:
https://github.com/apache/spark/pull/3461#discussion_r21067826
--- Diff: docs/mllib-decision-tree.md ---
@@ -103,36 +106,73 @@ and the resulting `$M-1$` split candidates are
considered.
### Stopping rule
Github user manishamde commented on a diff in the pull request:
https://github.com/apache/spark/pull/3461#discussion_r21067860
--- Diff: docs/mllib-decision-tree.md ---
@@ -103,36 +106,73 @@ and the resulting `$M-1$` split candidates are
considered.
### Stopping rule
Github user manishamde commented on a diff in the pull request:
https://github.com/apache/spark/pull/3461#discussion_r21067979
--- Diff: docs/mllib-decision-tree.md ---
@@ -103,36 +106,73 @@ and the resulting `$M-1$` split candidates are
considered.
### Stopping rule
Github user manishamde commented on a diff in the pull request:
https://github.com/apache/spark/pull/3461#discussion_r21068084
--- Diff: docs/mllib-gbt.md ---
@@ -0,0 +1,308 @@
+---
+layout: global
+title: Gradient-Boosted Trees - MLlib
+displayTitle: a
Github user manishamde commented on a diff in the pull request:
https://github.com/apache/spark/pull/3461#discussion_r21068117
--- Diff: docs/mllib-gbt.md ---
@@ -0,0 +1,308 @@
+---
+layout: global
+title: Gradient-Boosted Trees - MLlib
+displayTitle: a
Github user manishamde commented on a diff in the pull request:
https://github.com/apache/spark/pull/3461#discussion_r21068173
--- Diff: docs/mllib-gbt.md ---
@@ -0,0 +1,308 @@
+---
+layout: global
+title: Gradient-Boosted Trees - MLlib
+displayTitle: a
GitHub user jkbradley opened a pull request:
https://github.com/apache/spark/pull/3461
[SPARK-4580] [SPARK-4610] [mllib] Documentation for tree ensembles +
DecisionTree API fix
Major changes:
* Added documentation for tree ensembles
* Added examples for tree ensembles
*
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3461#issuecomment-64499904
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3461#issuecomment-64499901
[Test build #23852 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23852/consoleFull)
for PR 3461 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3461#issuecomment-64499893
[Test build #23852 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23852/consoleFull)
for PR 3461 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3461#issuecomment-64503813
[Test build #23858 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23858/consoleFull)
for PR 3461 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3461#issuecomment-64503902
[Test build #23858 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23858/consoleFull)
for PR 3461 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3461#issuecomment-64503905
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3461#issuecomment-64504928
[Test build #23861 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23861/consoleFull)
for PR 3461 at commit
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/3461#issuecomment-64506845
Note: I'm working on updating the decision tree programming guide further
too (with more info about parameters).
---
If your project is set up for it, you can reply
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3461#issuecomment-64510904
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3461#issuecomment-64510902
[Test build #23861 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23861/consoleFull)
for PR 3461 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3461#issuecomment-64517610
[Test build #23879 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23879/consoleFull)
for PR 3461 at commit
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/3461#issuecomment-64518822
OK! I think everything's updated, though I'm sure people will have
feedback.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3461#issuecomment-64522984
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3461#issuecomment-64522980
[Test build #23879 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23879/consoleFull)
for PR 3461 at commit
41 matches
Mail list logo
