Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/3555#issuecomment-69475931
Thanks! I've merged this to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/3555
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/3555#issuecomment-68393607
Hey sorry, this has merge conflicts. Can you merge with master?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3555#issuecomment-68421330
[Test build #24935 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24935/consoleFull)
for PR 3555 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3555#issuecomment-68424029
[Test build #24939 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24939/consoleFull)
for PR 3555 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3555#issuecomment-68424165
[Test build #24940 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24940/consoleFull)
for PR 3555 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3555#issuecomment-68424645
[Test build #24935 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24935/consoleFull)
for PR 3555 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3555#issuecomment-68424648
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user YanTangZhai commented on the pull request:
https://github.com/apache/spark/pull/3555#issuecomment-68425639
@marmbrus I've updated it. Please review again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3555#issuecomment-68425949
[Test build #24939 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24939/consoleFull)
for PR 3555 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3555#issuecomment-68425952
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3555#issuecomment-68426066
[Test build #24940 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24940/consoleFull)
for PR 3555 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3555#issuecomment-68426067
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/3555#issuecomment-67814308
Ah, sorry, forgot that the golden answer file name is generated by the MD5
of the query string. Then let's revert the last space change. I think this
minor issue
Github user YanTangZhai commented on the pull request:
https://github.com/apache/spark/pull/3555#issuecomment-67816709
@liancheng I will revert the last space change. Thanks for your comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3555#issuecomment-67817199
[Test build #24702 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24702/consoleFull)
for PR 3555 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3555#issuecomment-67823381
[Test build #24702 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24702/consoleFull)
for PR 3555 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3555#issuecomment-67823389
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/3555#issuecomment-67827365
Thanks for the update, this now LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3555#issuecomment-67803723
[Test build #24697 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24697/consoleFull)
for PR 3555 at commit
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/3555#discussion_r22155207
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala
---
@@ -56,6 +56,14 @@ class HiveQuerySuite extends
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/3555#issuecomment-67804795
This LGTM except for a minor styling issue. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3555#issuecomment-67805806
[Test build #24698 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24698/consoleFull)
for PR 3555 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3555#issuecomment-67806817
[Test build #24697 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24697/consoleFull)
for PR 3555 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3555#issuecomment-67806819
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3555#issuecomment-67807971
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3555#issuecomment-67807970
[Test build #24698 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24698/consoleFull)
for PR 3555 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3555#issuecomment-67457906
[Test build #24583 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24583/consoleFull)
for PR 3555 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3555#issuecomment-67465486
[Test build #24583 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24583/consoleFull)
for PR 3555 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3555#issuecomment-67465495
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user YanTangZhai commented on the pull request:
https://github.com/apache/spark/pull/3555#issuecomment-67473028
@marmbrus Please review again. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/3555#discussion_r22089196
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala
---
@@ -413,6 +421,16 @@ class HiveQuerySuite extends
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/3555#issuecomment-67278205
How about we switch this to a query test
(https://github.com/YanTangZhai/spark/pull/14). otherwise LGTM
---
If your project is set up for it, you can reply to this
GitHub user YanTangZhai opened a pull request:
https://github.com/apache/spark/pull/3555
[SPARK-4692] [SQL] Support ! boolean logic operator like NOT
Support ! boolean logic operator like NOT in sql as follows
select * from for_test where !(col1 col2)
You can merge this pull
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3555#issuecomment-65214491
[Test build #24041 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24041/consoleFull)
for PR 3555 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3555#issuecomment-65221949
[Test build #24041 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24041/consoleFull)
for PR 3555 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3555#issuecomment-65221953
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/3555#issuecomment-65295402
Please add a test to `HiveQuerySuite`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3555#issuecomment-65349979
[Test build #24070 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24070/consoleFull)
for PR 3555 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3555#issuecomment-65352677
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3555#issuecomment-65352673
[Test build #24070 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24070/consoleFull)
for PR 3555 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3555#issuecomment-65358422
[Test build #24076 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24076/consoleFull)
for PR 3555 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3555#issuecomment-65362422
[Test build #24076 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24076/consoleFull)
for PR 3555 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3555#issuecomment-65362427
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
44 matches
Mail list logo
