[GitHub] spark pull request: [SPARK-4855][mllib] testing the Chi-squared hy...

2014-12-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/3679 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-4855][mllib] testing the Chi-squared hy...

2014-12-16 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/3679#issuecomment-67218225 Merged into master. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] spark pull request: [SPARK-4855][mllib] testing the Chi-squared hy...

2014-12-15 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/3679#issuecomment-67119469 @jbencook Thanks for the updates! (Your comment about checking for exceptions makes me wonder if you were right before to throw a more meaningful exception than a Py4

[GitHub] spark pull request: [SPARK-4855][mllib] testing the Chi-squared hy...

2014-12-15 Thread jbencook
Github user jbencook commented on the pull request: https://github.com/apache/spark/pull/3679#issuecomment-67108325 OK, should be good to go now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] spark pull request: [SPARK-4855][mllib] testing the Chi-squared hy...

2014-12-15 Thread jbencook
Github user jbencook commented on the pull request: https://github.com/apache/spark/pull/3679#issuecomment-67107800 Thanks for the comments @jkbradley. I revised the JIRA tag to reference the new ticket you added, updated the URL by adding the "/" (oops), and removed the pytho