[GitHub] spark pull request: [SPARK-4858] Add an option to turn off a progr...

2015-01-10 Thread maropu
Github user maropu commented on the pull request: https://github.com/apache/spark/pull/3709#issuecomment-69450446 Ok. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request: [SPARK-4858] Add an option to turn off a progr...

2015-01-10 Thread maropu
Github user maropu closed the pull request at: https://github.com/apache/spark/pull/3709 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-4858] Add an option to turn off a progr...

2015-01-08 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/3709#issuecomment-69236555 Yeah that's a good point. It seems that `--conf` is sufficient for this use case. @maropu would you mind closing this issue? --- If your project is set up for it,

[GitHub] spark pull request: [SPARK-4858] Add an option to turn off a progr...

2015-01-07 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/3709#issuecomment-69143775 Just wondering, it seems like a fairly esoteric option for adding a built-in flag. Why not just do this? ``` ./bin/spark-shell --conf

[GitHub] spark pull request: [SPARK-4858] Add an option to turn off a progr...

2015-01-07 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/3709#issuecomment-69144559 @pwendell This is a better solution, we can not continue to add more flags for every useful user-cases. --- If your project is set up for it, you can reply to this email

[GitHub] spark pull request: [SPARK-4858] Add an option to turn off a progr...

2015-01-07 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/3709#issuecomment-69110931 @davies any other comments? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-4858] Add an option to turn off a progr...

2015-01-07 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/3709#discussion_r22625797 --- Diff: bin/utils.sh --- @@ -32,10 +32,11 @@ function gatherSparkSubmitOpts() { APPLICATION_OPTS=() while (($#)); do case $1 in -

[GitHub] spark pull request: [SPARK-4858] Add an option to turn off a progr...

2015-01-07 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/3709#discussion_r22624759 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala --- @@ -380,6 +386,8 @@ private[spark] class SparkSubmitArguments(args:

[GitHub] spark pull request: [SPARK-4858] Add an option to turn off a progr...

2015-01-07 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/3709#discussion_r22624919 --- Diff: bin/utils.sh --- @@ -32,10 +32,11 @@ function gatherSparkSubmitOpts() { APPLICATION_OPTS=() while (($#)); do case $1 in

[GitHub] spark pull request: [SPARK-4858] Add an option to turn off a progr...

2014-12-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3709#issuecomment-68050938 [Test build #24785 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24785/consoleFull) for PR 3709 at commit

[GitHub] spark pull request: [SPARK-4858] Add an option to turn off a progr...

2014-12-24 Thread maropu
Github user maropu commented on the pull request: https://github.com/apache/spark/pull/3709#issuecomment-68050965 Fixed, please test it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-4858] Add an option to turn off a progr...

2014-12-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3709#issuecomment-68055149 [Test build #24785 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24785/consoleFull) for PR 3709 at commit

[GitHub] spark pull request: [SPARK-4858] Add an option to turn off a progr...

2014-12-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3709#issuecomment-68055152 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4858] Add an option to turn off a progr...

2014-12-23 Thread maropu
Github user maropu commented on the pull request: https://github.com/apache/spark/pull/3709#issuecomment-68016680 @andrewor14 OK, I'll re-check it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-4858] Add an option to turn off a progr...

2014-12-23 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/3709#issuecomment-68016895 @maropu Thank you for explain this, it sounds good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: [SPARK-4858] Add an option to turn off a progr...

2014-12-22 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/3709#issuecomment-67884407 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-4858] Add an option to turn off a progr...

2014-12-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3709#issuecomment-67884964 [Test build #24713 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24713/consoleFull) for PR 3709 at commit

[GitHub] spark pull request: [SPARK-4858] Add an option to turn off a progr...

2014-12-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3709#issuecomment-67891805 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4858] Add an option to turn off a progr...

2014-12-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3709#issuecomment-67891795 [Test build #24713 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24713/consoleFull) for PR 3709 at commit

[GitHub] spark pull request: [SPARK-4858] Add an option to turn off a progr...

2014-12-22 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/3709#issuecomment-67896317 Looks like this one has a legitimate test failure --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-4858] Add an option to turn off a progr...

2014-12-17 Thread maropu
Github user maropu commented on the pull request: https://github.com/apache/spark/pull/3709#issuecomment-67291895 @davies Thx for your comment :) IMHO, it'd be better that switching on/off the bar is independent of log4j log level. This is useful for users to look into some

[GitHub] spark pull request: [SPARK-4858] Add an option to turn off a progr...

2014-12-17 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/3709#discussion_r21958440 --- Diff: bin/utils.sh --- @@ -32,10 +32,11 @@ function gatherSparkSubmitOpts() { APPLICATION_OPTS=() while (($#)); do case $1 in -

[GitHub] spark pull request: [SPARK-4858] Add an option to turn off a progr...

2014-12-15 Thread maropu
GitHub user maropu opened a pull request: https://github.com/apache/spark/pull/3709 [SPARK-4858] Add an option to turn off a progress bar in spark-shell Add an '--no-progress-bar' option to easily turn off a progress bar in spark-shell for users who'd like to look into debug logs

[GitHub] spark pull request: [SPARK-4858] Add an option to turn off a progr...

2014-12-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3709#issuecomment-67110752 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-4858] Add an option to turn off a progr...

2014-12-15 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/3709#issuecomment-67117052 /cc @davies --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-4858] Add an option to turn off a progr...

2014-12-15 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/3709#discussion_r21879847 --- Diff: bin/utils.sh --- @@ -32,10 +32,11 @@ function gatherSparkSubmitOpts() { APPLICATION_OPTS=() while (($#)); do case $1 in -

[GitHub] spark pull request: [SPARK-4858] Add an option to turn off a progr...

2014-12-15 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/3709#issuecomment-67118160 @maropu Thank you for work in this. I'm just wondering what's the user case that his argument will be useful? Because progress bar is disabled if logging level is DEBUG