Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/4006
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/4006#issuecomment-72396925
Ok, LGTM I will merge this and fix the override thing myself. Thanks
@zsxwing!
---
If your project is set up for it, you can reply to this email and have your
reply a
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4006#discussion_r23904129
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/SparkListenerBus.scala ---
@@ -17,78 +17,47 @@
package org.apache.spark.scheduler
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4006#issuecomment-71962472
[Test build #26280 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26280/consoleFull)
for PR 4006 at commit
[`c8dade2`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4006#issuecomment-71962481
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4006#issuecomment-71956401
[Test build #26280 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26280/consoleFull)
for PR 4006 at commit
[`c8dade2`](https://githu
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/4006#issuecomment-71955889
@andrewor14 The news names are pretty good to me. I have renamed them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on Git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4006#issuecomment-71955606
[Test build #26279 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26279/consoleFull)
for PR 4006 at commit
[`5715061`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4006#issuecomment-71955607
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4006#issuecomment-71955528
[Test build #26279 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26279/consoleFull)
for PR 4006 at commit
[`5715061`](https://githu
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/4006#issuecomment-71905267
@zsxwing I looked at this in greater detail and I have a better
understanding of the design choices you made here. The bottom line is that the
common properties betwee
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/4006#issuecomment-71577448
It's because `ReplayListenerBus` needs the functions in SparkListenerBus
and ListenerHelper. But it doesn't need `ListenerBus`. That's why
`SparkListenerBus` doesn't exte
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/4006#issuecomment-71503764
I see. That makes sense. However I still don't see the need for a separate
`ListenerHelper` trait. In my mind `SparkListenerBus` should extend
`ListenerBus[L, E]` inst
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4006#issuecomment-71423408
[Test build #26079 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26079/consoleFull)
for PR 4006 at commit
[`f0ef647`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4006#issuecomment-71423414
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/4006#discussion_r23514218
--- Diff: core/src/main/scala/org/apache/spark/util/ListenerBus.scala ---
@@ -0,0 +1,173 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4006#issuecomment-71419466
[Test build #26079 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26079/consoleFull)
for PR 4006 at commit
[`f0ef647`](https://githu
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/4006#issuecomment-71419194
> (1) make StreamingListenerEvent extend SparkListenerEvent
I don't like it because if so, we will get many meaningless "match may not
be exhaustive." warnings fr
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/4006#issuecomment-71411703
@zsxwing rather than making a `ListenerHelper` take in two type parameters,
can we do the following two things: (1) make `StreamingListenerEvent` extend
`SparkListener
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4006#discussion_r23511860
--- Diff: core/src/main/scala/org/apache/spark/util/ListenerBus.scala ---
@@ -0,0 +1,173 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4006#discussion_r23511852
--- Diff: core/src/main/scala/org/apache/spark/util/ListenerBus.scala ---
@@ -0,0 +1,173 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4006#discussion_r23511814
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/LiveListenerBus.scala ---
@@ -29,113 +28,18 @@ import org.apache.spark.util.Utils
* has star
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/4006#issuecomment-70590205
I still need to do a close review. I will do so within the next day or two.
---
If your project is set up for it, you can reply to this email and have your
reply appea
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/4006#issuecomment-70549995
@tdas @andrewor14 is this PR good to go, or did you have further review
comments?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4006#issuecomment-70228091
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4006#issuecomment-70228082
[Test build #25646 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25646/consoleFull)
for PR 4006 at commit
[`4e85ffc`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4006#issuecomment-70221214
[Test build #25646 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25646/consoleFull)
for PR 4006 at commit
[`4e85ffc`](https://githu
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4006#issuecomment-70206157
[Test build #25631 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25631/consoleFull)
for PR 4006 at commit
[`0710364`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4006#issuecomment-70206158
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4006#issuecomment-70052864
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4006#issuecomment-70052857
[Test build #25597 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25597/consoleFull)
for PR 4006 at commit
[`d2ef990`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4006#issuecomment-70047781
[Test build #25597 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25597/consoleFull)
for PR 4006 at commit
[`d2ef990`](https://githu
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4006#issuecomment-69871182
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4006#issuecomment-69871179
[Test build #25508 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25508/consoleFull)
for PR 4006 at commit
[`4539f91`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4006#issuecomment-69867386
[Test build #25508 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25508/consoleFull)
for PR 4006 at commit
[`4539f91`](https://githu
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/4006#issuecomment-69788047
Yeah, if you look at the test output it'll tell you the exact lines you'll
need to add to `MimaExcludes.scala`
---
If your project is set up for it, you can reply to
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/4006#issuecomment-69686343
Do I need to make some change to passs MiMa tests?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If you
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/4006#issuecomment-69684948
Updated the desription and jira
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/4006#issuecomment-69619189
Hi @zsxwing the same JIRA is fine, but could you add more detail in the
issue itself and in this PR description on each of the bugs you are trying to
fix? Also, please
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4006#issuecomment-69588632
[Test build #25418 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25418/consoleFull)
for PR 4006 at commit
[`a9dccd3`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4006#issuecomment-69588641
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4006#issuecomment-69577579
[Test build #25418 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25418/consoleFull)
for PR 4006 at commit
[`a9dccd3`](https://githu
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4006#issuecomment-69566482
[Test build #25412 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25412/consoleFull)
for PR 4006 at commit
[`7cc04c3`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4006#issuecomment-69566490
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/4006#issuecomment-69562564
Should I open another JIRA, or just update SPARK-4859 jira?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/4006#issuecomment-69561690
cc @JoshRosen @tdas @andrewor14
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4006#issuecomment-69561477
[Test build #25412 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25412/consoleFull)
for PR 4006 at commit
[`7cc04c3`](https://githu
GitHub user zsxwing opened a pull request:
https://github.com/apache/spark/pull/4006
[SPARK-4859][Core][Streaming] Refactor LiveListenerBus and
StreamingListenerBus
This PR refactors LiveListenerBus and StreamingListenerBus and extracts the
common codes to a parent class `Listener
48 matches
Mail list logo
