[GitHub] spark pull request: [SPARK-4871][SQL] Show sql statement in spark ...

2015-03-25 Thread wkhapy
Github user wkhapy commented on the pull request: https://github.com/apache/spark/pull/3718#issuecomment-85978470 @marmbrus ,when I use Statement.cancel() from JDBC,web ui shows that query keep going 。 --- If your project is set up for it, you can reply to this email and have yo

[GitHub] spark pull request: [SPARK-4871][SQL] Show sql statement in spark ...

2015-01-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/3718 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-4871][SQL] Show sql statement in spark ...

2015-01-10 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/3718#issuecomment-69479191 Thanks, merged to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] spark pull request: [SPARK-4871][SQL] Show sql statement in spark ...

2015-01-10 Thread scwf
Github user scwf commented on the pull request: https://github.com/apache/spark/pull/3718#issuecomment-69476551 ping @marmbrus --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[GitHub] spark pull request: [SPARK-4871][SQL] Show sql statement in spark ...

2015-01-08 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/3718#issuecomment-69181757 This LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[GitHub] spark pull request: [SPARK-4871][SQL] Show sql statement in spark ...

2014-12-30 Thread scwf
Github user scwf commented on the pull request: https://github.com/apache/spark/pull/3718#issuecomment-68408513 @marmbrus, can this go since i have filed a PR to add pop-up for full job desc? --- If your project is set up for it, you can reply to this email and have your reply appea

[GitHub] spark pull request: [SPARK-4871][SQL] Show sql statement in spark ...

2014-12-28 Thread scwf
Github user scwf commented on the pull request: https://github.com/apache/spark/pull/3718#issuecomment-68235672 Filed a PR to add pop-up for full job description #3819 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If y

[GitHub] spark pull request: [SPARK-4871][SQL] Show sql statement in spark ...

2014-12-22 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/3718#issuecomment-67923806 I see. Yes, a random group ID string is not intuitive nor useful. And just realize another reason that we shouldn't set group ID in `SparkExecuteStatementOperation.run`

[GitHub] spark pull request: [SPARK-4871][SQL] Show sql statement in spark ...

2014-12-22 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/3718#issuecomment-67886480 It's not deprecated for any good reason and I think we should undeprecate it. I'm not opposed to setting the job group, but I am opposed to setting it to a rand

[GitHub] spark pull request: [SPARK-4871][SQL] Show sql statement in spark ...

2014-12-21 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/3718#issuecomment-67806102 @marmbrus Maybe I missed something here, but why do we prefer `setJobDescription` over `setJobGroup`, especially when the former is deprecated? @scwf For job c

[GitHub] spark pull request: [SPARK-4871][SQL] Show sql statement in spark ...

2014-12-21 Thread scwf
Github user scwf commented on the pull request: https://github.com/apache/spark/pull/3718#issuecomment-67797406 Ok, i will add a pop-up containing the full --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] spark pull request: [SPARK-4871][SQL] Show sql statement in spark ...

2014-12-20 Thread markhamstra
Github user markhamstra commented on the pull request: https://github.com/apache/spark/pull/3718#issuecomment-67750241 That wrapping in the UI is barely tolerable for what are still fairly modest-length queries. We're really going to need some kind of elided query in the main Jobs ta

[GitHub] spark pull request: [SPARK-4871][SQL] Show sql statement in spark ...

2014-12-20 Thread scwf
Github user scwf commented on the pull request: https://github.com/apache/spark/pull/3718#issuecomment-67746894 1 My locally test it seems ctrl-c stops(not cancel) a running sql. 2 The sql statement wraps in ui auto. ![image](https://cloud.githubusercontent.com/assets/70

[GitHub] spark pull request: [SPARK-4871][SQL] Show sql statement in spark ...

2014-12-20 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/3718#issuecomment-67745797 One other thought: how does this handle really long queries, or ones with a lots of new lines? Does it mess up the UI? Do we need to truncate the statement? Can you p

[GitHub] spark pull request: [SPARK-4871][SQL] Show sql statement in spark ...

2014-12-20 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/3718#issuecomment-67745756 In principle I agree with @rxin. We probably should be setting the job group id and saving it so that if the users presses ctrl-c (or calls `Statement#cancel()` from JD

[GitHub] spark pull request: [SPARK-4871][SQL] Show sql statement in spark ...

2014-12-20 Thread scwf
Github user scwf commented on the pull request: https://github.com/apache/spark/pull/3718#issuecomment-67733650 i think this is ok. Even if we set the job group id, we can not use the cancel api to cancel job in spark-sql or beeline. --- If your project is set up for it, you can repl

[GitHub] spark pull request: [SPARK-4871][SQL] Show sql statement in spark ...

2014-12-19 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/3718#issuecomment-67727829 LGTM - but are we sure we don't want to set the job group id? We can use that to cancel running commands. --- If your project is set up for it, you can reply to this email

[GitHub] spark pull request: [SPARK-4871][SQL] Show sql statement in spark ...

2014-12-19 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/3718#issuecomment-67695031 Lets wait for some feedback from @rxin or @pwendell on the APIs in question here. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-4871][SQL] Show sql statement in spark ...

2014-12-18 Thread scwf
Github user scwf commented on the pull request: https://github.com/apache/spark/pull/3718#issuecomment-67604099 @marmbrus, is this ok to go? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] spark pull request: [SPARK-4871][SQL] Show sql statement in spark ...

2014-12-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3718#issuecomment-67603749 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24

[GitHub] spark pull request: [SPARK-4871][SQL] Show sql statement in spark ...

2014-12-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3718#issuecomment-67603746 [Test build #24625 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24625/consoleFull) for PR 3718 at commit [`e0d6b5d`](https://gith

[GitHub] spark pull request: [SPARK-4871][SQL] Show sql statement in spark ...

2014-12-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3718#issuecomment-67598149 [Test build #24625 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24625/consoleFull) for PR 3718 at commit [`e0d6b5d`](https://githu

[GitHub] spark pull request: [SPARK-4871][SQL] Show sql statement in spark ...

2014-12-18 Thread scwf
Github user scwf commented on the pull request: https://github.com/apache/spark/pull/3718#issuecomment-67592957 Updated --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled an

[GitHub] spark pull request: [SPARK-4871][SQL] Show sql statement in spark ...

2014-12-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3718#issuecomment-67468412 [Test build #24580 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24580/consoleFull) for PR 3718 at commit [`4d2038a`](https://gith

[GitHub] spark pull request: [SPARK-4871][SQL] Show sql statement in spark ...

2014-12-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3718#issuecomment-67468425 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24

[GitHub] spark pull request: [SPARK-4871][SQL] Show sql statement in spark ...

2014-12-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3718#issuecomment-67456523 [Test build #24580 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24580/consoleFull) for PR 3718 at commit [`4d2038a`](https://githu

[GitHub] spark pull request: [SPARK-4871][SQL] Show sql statement in spark ...

2014-12-18 Thread scwf
Github user scwf commented on the pull request: https://github.com/apache/spark/pull/3718#issuecomment-67456216 Retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[GitHub] spark pull request: [SPARK-4871][SQL] Show sql statement in spark ...

2014-12-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3718#issuecomment-67442452 [Test build #24570 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24570/consoleFull) for PR 3718 at commit [`4d2038a`](https://gith

[GitHub] spark pull request: [SPARK-4871][SQL] Show sql statement in spark ...

2014-12-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3718#issuecomment-67442456 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24

[GitHub] spark pull request: [SPARK-4871][SQL] Show sql statement in spark ...

2014-12-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3718#issuecomment-67437137 [Test build #24570 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24570/consoleFull) for PR 3718 at commit [`4d2038a`](https://githu

[GitHub] spark pull request: [SPARK-4871][SQL] Show sql statement in spark ...

2014-12-17 Thread scwf
Github user scwf commented on a diff in the pull request: https://github.com/apache/spark/pull/3718#discussion_r22017818 --- Diff: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/AbstractSparkSQLDriver.scala --- @@ -53,6 +54,8 @@ private[hive] abstract

[GitHub] spark pull request: [SPARK-4871][SQL] Show sql statement in spark ...

2014-12-17 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/3718#discussion_r21993324 --- Diff: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/AbstractSparkSQLDriver.scala --- @@ -53,6 +54,8 @@ private[hive] abstr

[GitHub] spark pull request: [SPARK-4871][SQL] Show sql statement in spark ...

2014-12-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3718#issuecomment-67304700 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24

[GitHub] spark pull request: [SPARK-4871][SQL] Show sql statement in spark ...

2014-12-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3718#issuecomment-67304693 [Test build #24540 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24540/consoleFull) for PR 3718 at commit [`df79837`](https://gith

[GitHub] spark pull request: [SPARK-4871][SQL] Show sql statement in spark ...

2014-12-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3718#issuecomment-67296740 [Test build #24540 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24540/consoleFull) for PR 3718 at commit [`df79837`](https://githu

[GitHub] spark pull request: [SPARK-4871][SQL] Show sql statement in spark ...

2014-12-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3718#issuecomment-67294522 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24

[GitHub] spark pull request: [SPARK-4871][SQL] Show sql statement in spark ...

2014-12-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3718#issuecomment-67294519 [Test build #24539 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24539/consoleFull) for PR 3718 at commit [`92ce834`](https://gith

[GitHub] spark pull request: [SPARK-4871][SQL] Show sql statement in spark ...

2014-12-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3718#issuecomment-67294126 [Test build #24539 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24539/consoleFull) for PR 3718 at commit [`92ce834`](https://githu

[GitHub] spark pull request: [SPARK-4871][SQL] Show sql statement in spark ...

2014-12-17 Thread scwf
Github user scwf commented on the pull request: https://github.com/apache/spark/pull/3718#issuecomment-67293587 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[GitHub] spark pull request: [SPARK-4871][SQL] Show sql statement in spark ...

2014-12-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3718#issuecomment-67282956 [Test build #24532 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24532/consoleFull) for PR 3718 at commit [`92ce834`](https://gith

[GitHub] spark pull request: [SPARK-4871][SQL] Show sql statement in spark ...

2014-12-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3718#issuecomment-67282950 [Test build #24532 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24532/consoleFull) for PR 3718 at commit [`92ce834`](https://githu

[GitHub] spark pull request: [SPARK-4871][SQL] Show sql statement in spark ...

2014-12-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3718#issuecomment-67282957 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24

[GitHub] spark pull request: [SPARK-4871][SQL] Show sql statement in spark ...

2014-12-16 Thread scwf
Github user scwf commented on the pull request: https://github.com/apache/spark/pull/3718#issuecomment-67282772 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[GitHub] spark pull request: [SPARK-4871][SQL] Show sql statement in spark ...

2014-12-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3718#issuecomment-67282305 [Test build #24531 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24531/consoleFull) for PR 3718 at commit [`92ce834`](https://gith

[GitHub] spark pull request: [SPARK-4871][SQL] Show sql statement in spark ...

2014-12-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3718#issuecomment-67282295 [Test build #24531 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24531/consoleFull) for PR 3718 at commit [`92ce834`](https://githu

[GitHub] spark pull request: [SPARK-4871][SQL] Show sql statement in spark ...

2014-12-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3718#issuecomment-67282309 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24

[GitHub] spark pull request: [SPARK-4871][SQL] Show sql statement in spark ...

2014-12-16 Thread scwf
GitHub user scwf opened a pull request: https://github.com/apache/spark/pull/3718 [SPARK-4871][SQL] Show sql statement in spark ui when run sql with spark-sql You can merge this pull request into a Git repository by running: $ git pull https://github.com/scwf/spark sparksqlui