[GitHub] spark pull request: [SPARK-4934][CORE] Print remote address in Con...

2015-01-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/4157 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-4934][CORE] Print remote address in Con...

2015-01-25 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/4157#issuecomment-71359375 Thanks, @shenh062326. In that case, do you mind closing this PR? Please let us know if the Netty implementation have any problems. Thanks again! --- If your project is set

[GitHub] spark pull request: [SPARK-4934][CORE] Print remote address in Con...

2015-01-24 Thread shenh062326
Github user shenh062326 commented on the pull request: https://github.com/apache/spark/pull/4157#issuecomment-71348155 I think you are right, it's no need to change. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-4934][CORE] Print remote address in Con...

2015-01-23 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/4157#issuecomment-71304102 The new default implementation for transport is Netty, which also provides much better error messages. I think eventually we should remove the current connection manager, so

[GitHub] spark pull request: [SPARK-4934][CORE] Print remote address in Con...

2015-01-22 Thread shenh062326
Github user shenh062326 commented on a diff in the pull request: https://github.com/apache/spark/pull/4157#discussion_r23370062 --- Diff: core/src/main/scala/org/apache/spark/network/nio/ConnectionManager.scala --- @@ -375,16 +375,22 @@ private[nio] class ConnectionManager(

[GitHub] spark pull request: [SPARK-4934][CORE] Print remote address in Con...

2015-01-22 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/4157#discussion_r23365112 --- Diff: core/src/main/scala/org/apache/spark/network/nio/ConnectionManager.scala --- @@ -375,16 +375,22 @@ private[nio] class ConnectionManager(

[GitHub] spark pull request: [SPARK-4934][CORE] Print remote address in Con...

2015-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4157#issuecomment-70991317 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25

[GitHub] spark pull request: [SPARK-4934][CORE] Print remote address in Con...

2015-01-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4157#issuecomment-70991309 [Test build #25957 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25957/consoleFull) for PR 4157 at commit [`e5ac73e`](https://gith

[GitHub] spark pull request: [SPARK-4934][CORE] Print remote address in Con...

2015-01-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4157#issuecomment-70984613 [Test build #25957 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25957/consoleFull) for PR 4157 at commit [`e5ac73e`](https://githu

[GitHub] spark pull request: [SPARK-4934][CORE] Print remote address in Con...

2015-01-22 Thread shenh062326
GitHub user shenh062326 opened a pull request: https://github.com/apache/spark/pull/4157 [SPARK-4934][CORE] Print remote address in ConnectionManager Connection key is hard to read : key already cancelled ? sun.nio.ch.SelectionKeyImpl@52b0e278. It’s hard to solve problem by t