[GitHub] spark pull request: [SPARK-4949]shutdownCallback in SparkDeploySch...

2015-02-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/3781 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-4949]shutdownCallback in SparkDeploySch...

2015-02-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3781#issuecomment-74854552 [Test build #27678 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27678/consoleFull) for PR 3781 at commit [`c146c93`](https://gith

[GitHub] spark pull request: [SPARK-4949]shutdownCallback in SparkDeploySch...

2015-02-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3781#issuecomment-74854562 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27

[GitHub] spark pull request: [SPARK-4949]shutdownCallback in SparkDeploySch...

2015-02-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3781#issuecomment-74846885 [Test build #27678 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27678/consoleFull) for PR 3781 at commit [`c146c93`](https://githu

[GitHub] spark pull request: [SPARK-4949]shutdownCallback in SparkDeploySch...

2015-02-18 Thread sarutak
Github user sarutak commented on a diff in the pull request: https://github.com/apache/spark/pull/3781#discussion_r24893296 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/SparkDeploySchedulerBackend.scala --- @@ -148,19 +152,16 @@ private[spark] class SparkDeploy

[GitHub] spark pull request: [SPARK-4949]shutdownCallback in SparkDeploySch...

2015-02-18 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/3781#discussion_r24890677 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/SparkDeploySchedulerBackend.scala --- @@ -148,19 +152,16 @@ private[spark] class SparkDeployS

[GitHub] spark pull request: [SPARK-4949]shutdownCallback in SparkDeploySch...

2015-02-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3781#issuecomment-74803198 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27

[GitHub] spark pull request: [SPARK-4949]shutdownCallback in SparkDeploySch...

2015-02-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3781#issuecomment-74803195 [Test build #27668 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27668/consoleFull) for PR 3781 at commit [`42ca528`](https://gith

[GitHub] spark pull request: [SPARK-4949]shutdownCallback in SparkDeploySch...

2015-02-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3781#issuecomment-74803111 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27

[GitHub] spark pull request: [SPARK-4949]shutdownCallback in SparkDeploySch...

2015-02-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3781#issuecomment-74803108 [Test build #27667 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27667/consoleFull) for PR 3781 at commit [`3c1c018`](https://gith

[GitHub] spark pull request: [SPARK-4949]shutdownCallback in SparkDeploySch...

2015-02-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3781#issuecomment-74795803 [Test build #27668 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27668/consoleFull) for PR 3781 at commit [`42ca528`](https://githu

[GitHub] spark pull request: [SPARK-4949]shutdownCallback in SparkDeploySch...

2015-02-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3781#issuecomment-74795273 [Test build #27667 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27667/consoleFull) for PR 3781 at commit [`3c1c018`](https://githu

[GitHub] spark pull request: [SPARK-4949]shutdownCallback in SparkDeploySch...

2015-02-17 Thread sarutak
Github user sarutak commented on the pull request: https://github.com/apache/spark/pull/3781#issuecomment-74795129 @srowen Thank you for picking up this PR. I've changed the `shutdownCallback` to be a simple volatile variable. --- If your project is set up for it, you can reply to th

[GitHub] spark pull request: [SPARK-4949]shutdownCallback in SparkDeploySch...

2015-02-16 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/3781#discussion_r24771215 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/SparkDeploySchedulerBackend.scala --- @@ -31,16 +34,16 @@ private[spark] class SparkDeploySch

[GitHub] spark pull request: [SPARK-4949]shutdownCallback in SparkDeploySch...

2015-02-16 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/3781#issuecomment-74550130 This looks good to me. Most of it is making some fields private that look like they should be, simplifying one synchronization primitive, and does fix a theoretical concur

[GitHub] spark pull request: [SPARK-4949]shutdownCallback in SparkDeploySch...

2015-01-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3781#issuecomment-69234094 [Test build #25244 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25244/consoleFull) for PR 3781 at commit [`3e3631d`](https://gith

[GitHub] spark pull request: [SPARK-4949]shutdownCallback in SparkDeploySch...

2015-01-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3781#issuecomment-69234109 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25

[GitHub] spark pull request: [SPARK-4949]shutdownCallback in SparkDeploySch...

2015-01-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3781#issuecomment-69223166 [Test build #25244 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25244/consoleFull) for PR 3781 at commit [`3e3631d`](https://githu

[GitHub] spark pull request: [SPARK-4949]shutdownCallback in SparkDeploySch...

2015-01-08 Thread sarutak
Github user sarutak commented on the pull request: https://github.com/apache/spark/pull/3781#issuecomment-69222403 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] spark pull request: [SPARK-4949]shutdownCallback in SparkDeploySch...

2015-01-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3781#issuecomment-69217857 [Test build #25235 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25235/consoleFull) for PR 3781 at commit [`3e3631d`](https://gith

[GitHub] spark pull request: [SPARK-4949]shutdownCallback in SparkDeploySch...

2015-01-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3781#issuecomment-69217872 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25

[GitHub] spark pull request: [SPARK-4949]shutdownCallback in SparkDeploySch...

2015-01-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3781#issuecomment-69209207 [Test build #25235 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25235/consoleFull) for PR 3781 at commit [`3e3631d`](https://githu

[GitHub] spark pull request: [SPARK-4949]shutdownCallback in SparkDeploySch...

2014-12-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3781#issuecomment-68045313 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24

[GitHub] spark pull request: [SPARK-4949]shutdownCallback in SparkDeploySch...

2014-12-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3781#issuecomment-68045308 [Test build #24782 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24782/consoleFull) for PR 3781 at commit [`1b60fd1`](https://gith

[GitHub] spark pull request: [SPARK-4949]shutdownCallback in SparkDeploySch...

2014-12-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3781#issuecomment-68040463 [Test build #24782 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24782/consoleFull) for PR 3781 at commit [`1b60fd1`](https://githu