Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8022#issuecomment-154930447
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8022#issuecomment-154930397
**[Test build #45336 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45336/consoleFull)**
for PR 8022 at commit
[`0072400`](https://git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8022#issuecomment-154915147
**[Test build #45336 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45336/consoleFull)**
for PR 8022 at commit
[`0072400`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8022#issuecomment-154912370
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8022#issuecomment-154912360
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/8022#discussion_r43829408
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/StreamingLinearAlgorithm.scala
---
@@ -91,7 +112,22 @@ abstract class StreamingLinearAlgorith
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/8022#issuecomment-153411059
@rotationsymmetry Could you provide a simple unit test in Java to show Java
compatibility?
---
If your project is set up for it, you can reply to this email and have you
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8022#issuecomment-149743277
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8022#issuecomment-149743279
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8022#issuecomment-149743191
**[Test build #44017 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44017/consoleFull)**
for PR 8022 at commit
[`9ba83cb`](https://git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8022#issuecomment-149736720
**[Test build #44017 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44017/consoleFull)**
for PR 8022 at commit
[`9ba83cb`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8022#issuecomment-149735476
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8022#issuecomment-149735423
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/8022#issuecomment-149734860
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enab
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/8022#issuecomment-149734845
add to whitelist
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featur
Github user rotationsymmetry commented on the pull request:
https://github.com/apache/spark/pull/8022#issuecomment-137996870
@feynmanliang Much appreciated. I have update the PR for your comments.
---
If your project is set up for it, you can reply to this email and have your
reply a
Github user feynmanliang commented on the pull request:
https://github.com/apache/spark/pull/8022#issuecomment-137896891
LGTM after these changes and pending tests
CC @mengxr @freeman-lab
---
If your project is set up for it, you can reply to this email and have your
reply ap
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8022#discussion_r38806675
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/StreamingLinearRegressionWithSGD.scala
---
@@ -107,4 +113,16 @@ class StreamingLinearRe
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8022#discussion_r38806669
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/StreamingLinearAlgorithm.scala
---
@@ -59,11 +76,14 @@ import org.apache.spark.streamin
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8022#discussion_r38806663
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/StreamingDecay.scala ---
@@ -0,0 +1,117 @@
+/*
+ * Licensed to the Apache Softwa
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8022#discussion_r38806665
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/StreamingDecay.scala ---
@@ -0,0 +1,117 @@
+/*
+ * Licensed to the Apache Softwa
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8022#discussion_r38806661
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/StreamingDecay.scala ---
@@ -0,0 +1,117 @@
+/*
+ * Licensed to the Apache Softwa
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8022#discussion_r38806648
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/StreamingDecay.scala ---
@@ -0,0 +1,117 @@
+/*
+ * Licensed to the Apache Softwa
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8022#discussion_r38806603
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/StreamingLogisticRegressionWithSGD.scala
---
@@ -101,4 +107,14 @@ class StreamingLo
Github user feynmanliang commented on the pull request:
https://github.com/apache/spark/pull/8022#issuecomment-137896575
Streaming KMeans uses `decayFactor` and I think it's important we maintain
consistency
---
If your project is set up for it, you can reply to this email and have y
Github user rotationsymmetry commented on the pull request:
https://github.com/apache/spark/pull/8022#issuecomment-137871809
@feynmanliang Thank you for your comments. I have revised the PR, including
* Refactor: timeUnit has its own setter.
* Add @Since.
* Clean up ScalaDoc
Github user rotationsymmetry commented on a diff in the pull request:
https://github.com/apache/spark/pull/8022#discussion_r38717536
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/StreamingDecay.scala ---
@@ -0,0 +1,99 @@
+/*
+ * Licensed to the Apache Sof
Github user rotationsymmetry commented on a diff in the pull request:
https://github.com/apache/spark/pull/8022#discussion_r38717540
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/StreamingLogisticRegressionWithSGD.scala
---
@@ -101,4 +107,14 @@ class Streami
Github user rotationsymmetry commented on a diff in the pull request:
https://github.com/apache/spark/pull/8022#discussion_r38717482
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/regression/StreamingLinearRegressionSuite.scala
---
@@ -17,6 +17,8 @@
package org.a
Github user rotationsymmetry commented on a diff in the pull request:
https://github.com/apache/spark/pull/8022#discussion_r38717487
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/StreamingLinearRegressionWithSGD.scala
---
@@ -107,4 +113,16 @@ class StreamingLine
Github user rotationsymmetry commented on a diff in the pull request:
https://github.com/apache/spark/pull/8022#discussion_r38717322
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/regression/StreamingLinearRegressionSuite.scala
---
@@ -194,4 +196,204 @@ class StreamingLinea
Github user feynmanliang commented on the pull request:
https://github.com/apache/spark/pull/8022#issuecomment-137534276
Made another pass
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8022#discussion_r38678985
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/regression/StreamingLinearRegressionSuite.scala
---
@@ -194,4 +196,204 @@ class StreamingLinearReg
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8022#discussion_r38676398
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/regression/StreamingLinearRegressionSuite.scala
---
@@ -17,6 +17,8 @@
package org.apach
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8022#discussion_r38676377
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/StreamingLinearRegressionWithSGD.scala
---
@@ -107,4 +113,16 @@ class StreamingLinearRe
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8022#discussion_r38676215
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/StreamingDecay.scala ---
@@ -0,0 +1,99 @@
+/*
+ * Licensed to the Apache Softwar
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8022#discussion_r38675979
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/StreamingDecay.scala ---
@@ -0,0 +1,99 @@
+/*
+ * Licensed to the Apache Softwar
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8022#discussion_r38675249
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/StreamingDecay.scala ---
@@ -0,0 +1,99 @@
+/*
+ * Licensed to the Apache Softwar
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8022#discussion_r38674682
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/StreamingDecay.scala ---
@@ -0,0 +1,99 @@
+/*
+ * Licensed to the Apache Softwar
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8022#discussion_r38674463
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/StreamingDecay.scala ---
@@ -0,0 +1,99 @@
+/*
+ * Licensed to the Apache Softwar
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8022#discussion_r38674349
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/StreamingLogisticRegressionWithSGD.scala
---
@@ -101,4 +107,14 @@ class StreamingLo
Github user rotationsymmetry commented on the pull request:
https://github.com/apache/spark/pull/8022#issuecomment-136924899
@feynmanliang I have make another push to the PR:
Refactor StreamingDecay
Use case object for TimeUnit
Clean up ScalaDoc
Thank again for
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8022#discussion_r38389804
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/StreamingLinearRegressionWithSGD.scala
---
@@ -47,6 +52,7 @@ class StreamingLinearRegre
Github user rotationsymmetry commented on a diff in the pull request:
https://github.com/apache/spark/pull/8022#discussion_r38386646
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/StreamingLinearRegressionWithSGD.scala
---
@@ -47,6 +52,7 @@ class StreamingLinearR
Github user rotationsymmetry commented on a diff in the pull request:
https://github.com/apache/spark/pull/8022#discussion_r38337261
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/StreamingDecay.scala ---
@@ -0,0 +1,116 @@
+/*
+ * Licensed to the Apache So
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8022#discussion_r38242939
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/StreamingDecay.scala ---
@@ -0,0 +1,116 @@
+/*
+ * Licensed to the Apache Softwa
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8022#discussion_r38243525
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/StreamingLinearRegressionWithSGD.scala
---
@@ -47,6 +52,7 @@ class StreamingLinearRegre
Github user rotationsymmetry commented on a diff in the pull request:
https://github.com/apache/spark/pull/8022#discussion_r38163035
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/StreamingDecay.scala ---
@@ -0,0 +1,116 @@
+/*
+ * Licensed to the Apache So
Github user rotationsymmetry commented on a diff in the pull request:
https://github.com/apache/spark/pull/8022#discussion_r38162690
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/StreamingLinearRegressionWithSGD.scala
---
@@ -47,6 +52,7 @@ class StreamingLinearR
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8022#discussion_r38151338
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/StreamingLinearRegressionWithSGD.scala
---
@@ -47,6 +52,7 @@ class StreamingLinearRegre
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8022#discussion_r38150677
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/StreamingDecay.scala ---
@@ -0,0 +1,116 @@
+/*
+ * Licensed to the Apache Softwa
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8022#discussion_r38150314
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/StreamingDecay.scala ---
@@ -0,0 +1,116 @@
+/*
+ * Licensed to the Apache Softwa
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8022#discussion_r38150200
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/StreamingDecay.scala ---
@@ -0,0 +1,116 @@
+/*
+ * Licensed to the Apache Softwa
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8022#discussion_r38150131
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/StreamingDecay.scala ---
@@ -0,0 +1,116 @@
+/*
+ * Licensed to the Apache Softwa
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8022#discussion_r38150103
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/StreamingDecay.scala ---
@@ -0,0 +1,116 @@
+/*
+ * Licensed to the Apache Softwa
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8022#discussion_r38149945
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/StreamingDecay.scala ---
@@ -0,0 +1,116 @@
+/*
+ * Licensed to the Apache Softwa
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8022#discussion_r38149963
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/StreamingDecay.scala ---
@@ -0,0 +1,116 @@
+/*
+ * Licensed to the Apache Softwa
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8022#discussion_r38149766
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/StreamingDecay.scala ---
@@ -0,0 +1,116 @@
+/*
+ * Licensed to the Apache Softwa
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8022#discussion_r38149699
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/StreamingDecay.scala ---
@@ -0,0 +1,116 @@
+/*
+ * Licensed to the Apache Softwa
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8022#discussion_r38149662
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/StreamingLogisticRegressionWithSGD.scala
---
@@ -32,6 +32,11 @@ import
org.apache.
Github user rotationsymmetry commented on the pull request:
https://github.com/apache/spark/pull/8022#issuecomment-135557506
@feynmanliang Thank you very much for your review.
I have incorporated your comments in commit a4ed2b0.
* Add ScalaDoc for public API.
* Ad
Github user feynmanliang commented on the pull request:
https://github.com/apache/spark/pull/8022#issuecomment-135260755
@rotationsymmetry you also have a merge conflict, sorry :disappointed: do
you mind resolving?
---
If your project is set up for it, you can reply to this email and
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8022#discussion_r38057405
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/classification/StreamingLogisticRegressionSuite.scala
---
@@ -184,4 +184,72 @@ class StreamingLogi
Github user rotationsymmetry commented on a diff in the pull request:
https://github.com/apache/spark/pull/8022#discussion_r38008195
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/StreamingDecay.scala ---
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Sof
Github user rotationsymmetry commented on a diff in the pull request:
https://github.com/apache/spark/pull/8022#discussion_r38008092
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/StreamingDecay.scala ---
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Sof
Github user rotationsymmetry commented on a diff in the pull request:
https://github.com/apache/spark/pull/8022#discussion_r38005456
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/classification/StreamingLogisticRegressionSuite.scala
---
@@ -184,4 +184,72 @@ class Streaming
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8022#discussion_r37892379
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/StreamingDecay.scala ---
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Softwar
Github user rotationsymmetry commented on a diff in the pull request:
https://github.com/apache/spark/pull/8022#discussion_r37887648
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/StreamingDecay.scala ---
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Sof
Github user rotationsymmetry commented on a diff in the pull request:
https://github.com/apache/spark/pull/8022#discussion_r37887513
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/StreamingDecay.scala ---
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Sof
Github user rotationsymmetry commented on a diff in the pull request:
https://github.com/apache/spark/pull/8022#discussion_r37887358
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/StreamingDecay.scala ---
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Sof
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8022#discussion_r37824754
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/classification/StreamingLogisticRegressionSuite.scala
---
@@ -184,4 +184,72 @@ class StreamingLogi
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8022#discussion_r37824256
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/StreamingLinearAlgorithm.scala
---
@@ -84,7 +87,20 @@ abstract class StreamingLinearAlg
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8022#discussion_r37824112
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/StreamingLinearAlgorithm.scala
---
@@ -84,7 +87,20 @@ abstract class StreamingLinearAlg
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8022#discussion_r37823963
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/StreamingDecay.scala ---
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Softwar
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8022#discussion_r37823899
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/StreamingDecay.scala ---
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Softwar
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8022#discussion_r37823826
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/StreamingDecay.scala ---
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Softwar
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8022#discussion_r37823801
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/StreamingDecay.scala ---
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Softwar
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8022#discussion_r37823766
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/StreamingDecay.scala ---
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Softwar
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8022#discussion_r37823725
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/StreamingDecay.scala ---
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Softwar
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8022#issuecomment-128599819
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
GitHub user rotationsymmetry opened a pull request:
https://github.com/apache/spark/pull/8022
[SPARK-4980] [MLlib] Add decay factors to streaming linear methods
This PR includes an implementation of decay factors in streaming linear and
logistic regression. Unit tests are also inclu
81 matches
Mail list logo
