Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/7166
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/7166#issuecomment-119759171
LGTM. Merged into master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7166#discussion_r34210389
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/GaussianMixture.scala ---
@@ -171,14 +178,24 @@ class GaussianMixture private (
//
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7166#issuecomment-119739461
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7166#issuecomment-119739359
[Test build #36837 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36837/console)
for PR 7166 at commit
[`4f351fa`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7166#issuecomment-119731196
[Test build #36837 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36837/consoleFull)
for PR 7166 at commit
[`4f351fa`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7166#issuecomment-119730528
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7166#issuecomment-119730494
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/7166#discussion_r34197573
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/GaussianMixture.scala ---
@@ -192,6 +209,19 @@ class GaussianMixture private (
/*
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/7166#discussion_r34197260
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/GaussianMixture.scala ---
@@ -171,14 +178,24 @@ class GaussianMixture private (
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/7166#discussion_r34197267
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/GaussianMixture.scala ---
@@ -192,6 +209,19 @@ class GaussianMixture private (
/*
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7166#issuecomment-119727956
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7166#discussion_r34197166
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/GaussianMixture.scala ---
@@ -192,6 +209,19 @@ class GaussianMixture private (
/** Java
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7166#issuecomment-119727859
[Test build #36827 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36827/console)
for PR 7166 at commit
[`5ea947e`](https://github.
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/7166#discussion_r34196106
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/GaussianMixture.scala ---
@@ -43,6 +43,9 @@ import org.apache.spark.util.Utils
* W
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/7166#discussion_r34195633
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/GaussianMixture.scala ---
@@ -140,6 +143,10 @@ class GaussianMixture private (
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7166#discussion_r34194257
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/GaussianMixture.scala ---
@@ -171,14 +178,24 @@ class GaussianMixture private (
//
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7166#discussion_r34194143
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/GaussianMixture.scala ---
@@ -192,6 +209,19 @@ class GaussianMixture private (
/** Java
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7166#discussion_r34194134
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/GaussianMixture.scala ---
@@ -43,6 +43,9 @@ import org.apache.spark.util.Utils
* While t
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7166#discussion_r34194050
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/GaussianMixture.scala ---
@@ -140,6 +143,10 @@ class GaussianMixture private (
// Get
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7166#issuecomment-119719068
[Test build #36827 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36827/consoleFull)
for PR 7166 at commit
[`5ea947e`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7166#issuecomment-119718786
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7166#issuecomment-119718811
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user feynmanliang commented on the pull request:
https://github.com/apache/spark/pull/7166#issuecomment-119718203
jenkins retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7166#issuecomment-119705959
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7166#issuecomment-119705935
[Test build #36822 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36822/console)
for PR 7166 at commit
[`5ea947e`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7166#issuecomment-119703172
[Test build #36822 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36822/consoleFull)
for PR 7166 at commit
[`5ea947e`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7166#issuecomment-119702531
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7166#issuecomment-119702433
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/7166#discussion_r34186847
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/clustering/GaussianMixtureSuite.scala
---
@@ -106,7 +106,7 @@ class GaussianMixtureSuite extends S
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/7166#discussion_r34186784
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/GaussianMixture.scala ---
@@ -171,14 +177,25 @@ class GaussianMixture private (
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/7166#discussion_r34186686
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/GaussianMixture.scala ---
@@ -171,14 +177,25 @@ class GaussianMixture private (
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/7166#discussion_r34185831
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/GaussianMixture.scala ---
@@ -140,6 +143,9 @@ class GaussianMixture private (
/
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7166#discussion_r34178453
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/clustering/GaussianMixtureSuite.scala
---
@@ -106,7 +106,7 @@ class GaussianMixtureSuite extends SparkFu
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7166#discussion_r34178310
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/GaussianMixture.scala ---
@@ -171,14 +177,25 @@ class GaussianMixture private (
//
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7166#discussion_r34178317
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/GaussianMixture.scala ---
@@ -171,14 +177,25 @@ class GaussianMixture private (
//
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7166#discussion_r34177389
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/GaussianMixture.scala ---
@@ -140,6 +143,9 @@ class GaussianMixture private (
// Get
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7166#issuecomment-119400122
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7166#issuecomment-119400061
[Test build #36748 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36748/console)
for PR 7166 at commit
[`00eb7db`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7166#issuecomment-119396049
[Test build #36748 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36748/consoleFull)
for PR 7166 at commit
[`00eb7db`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7166#issuecomment-119395473
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7166#issuecomment-119395485
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user feynmanliang commented on the pull request:
https://github.com/apache/spark/pull/7166#issuecomment-119395257
jenkins retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7166#issuecomment-119395117
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7166#issuecomment-119395103
[Test build #36745 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36745/console)
for PR 7166 at commit
[`00eb7db`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7166#issuecomment-119392343
[Test build #36745 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36745/consoleFull)
for PR 7166 at commit
[`00eb7db`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7166#issuecomment-119392231
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7166#issuecomment-119392242
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/7166#discussion_r34108772
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/GaussianMixture.scala ---
@@ -171,14 +185,30 @@ class GaussianMixture private (
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/7166#discussion_r34108359
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/GaussianMixture.scala ---
@@ -171,14 +185,30 @@ class GaussianMixture private (
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/7166#discussion_r34108303
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/GaussianMixture.scala ---
@@ -121,6 +124,17 @@ class GaussianMixture private (
*
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7166#discussion_r34082037
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/GaussianMixture.scala ---
@@ -171,14 +185,30 @@ class GaussianMixture private (
//
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7166#discussion_r34081910
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/GaussianMixture.scala ---
@@ -121,6 +124,17 @@ class GaussianMixture private (
*/
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7166#discussion_r34081654
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/GaussianMixture.scala ---
@@ -171,14 +185,30 @@ class GaussianMixture private (
//
Github user feynmanliang commented on the pull request:
https://github.com/apache/spark/pull/7166#issuecomment-118238218
I did some [perf
testing](https://gist.github.com/feynmanliang/70d79c23dffc828939ec) and it
shows that distributing the Gaussians does yield a significant improveme
Github user feynmanliang commented on the pull request:
https://github.com/apache/spark/pull/7166#issuecomment-117919850
You're totally right; sorry about that! Totally slipped my mind. Will do
next time.
On Wed, Jul 1, 2015 at 9:01 PM Manoj Kumar wrote:
> Thanks
Github user MechCoder commented on the pull request:
https://github.com/apache/spark/pull/7166#issuecomment-117898553
Thanks for picking up on this. Next time it might be better to just
cherry-pick the commits from the branch as contributor and commit history is
not lost.
---
If you
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7166#issuecomment-117848841
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7166#issuecomment-117848783
[Test build #36314 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36314/console)
for PR 7166 at commit
[`e7c8127`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7166#issuecomment-117844437
[Test build #36314 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36314/consoleFull)
for PR 7166 at commit
[`e7c8127`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7166#issuecomment-117844241
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7166#issuecomment-117844225
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7166#issuecomment-117825721
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7166#issuecomment-117825624
[Test build #36301 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36301/console)
for PR 7166 at commit
[`1da3c7f`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7166#issuecomment-117817655
[Test build #36301 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36301/consoleFull)
for PR 7166 at commit
[`1da3c7f`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7166#issuecomment-117817442
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7166#issuecomment-117817472
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
67 matches
Mail list logo