[GitHub] spark pull request: [SPARK-5084][SQL]add if not exists after creat...

2015-03-16 Thread baishuo
Github user baishuo commented on the pull request: https://github.com/apache/spark/pull/3895#issuecomment-82048390 thank you @liancheng , I had study baishuo/spark#2 , and I think that is good :) @marmbrus --- If your project is set up for it, you can reply to this email and

[GitHub] spark pull request: [SPARK-5084][SQL]add if not exists after creat...

2015-03-15 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/3895#discussion_r26449025 --- Diff: sql/hive/v0.13.1/src/main/scala/org/apache/spark/sql/hive/Shim13.scala --- @@ -297,7 +297,7 @@ private[hive] object HiveShim { def getStats

[GitHub] spark pull request: [SPARK-5084][SQL]add if not exists after creat...

2015-03-15 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/3895#discussion_r26448485 --- Diff: sql/hive/v0.13.1/src/main/scala/org/apache/spark/sql/hive/Shim13.scala --- @@ -297,7 +297,7 @@ private[hive] object HiveShim { def get

[GitHub] spark pull request: [SPARK-5084][SQL]add if not exists after creat...

2015-03-15 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/3895#issuecomment-80945233 @marmbrus @baishuo My last merging operation happened to fail because of network issue, and then I saw Michael's comment. Created a baishuo/spark#2 per Michael's commen

[GitHub] spark pull request: [SPARK-5084][SQL]add if not exists after creat...

2015-03-14 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/3895#issuecomment-80642173 I actually question why we need this at all. As far as I understand, we only need this function because of a bug in the way we are initializing `TestHive` (the only pla

[GitHub] spark pull request: [SPARK-5084][SQL]add if not exists after creat...

2015-03-14 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/3895#issuecomment-80582987 This LGTM, merging to master. Thanks for working on this! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request: [SPARK-5084][SQL]add if not exists after creat...

2015-03-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3895#issuecomment-78825756 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28

[GitHub] spark pull request: [SPARK-5084][SQL]add if not exists after creat...

2015-03-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3895#issuecomment-78825738 [Test build #28550 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28550/consoleFull) for PR 3895 at commit [`58bbdb3`](https://gith

[GitHub] spark pull request: [SPARK-5084][SQL]add if not exists after creat...

2015-03-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3895#issuecomment-78807814 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28

[GitHub] spark pull request: [SPARK-5084][SQL]add if not exists after creat...

2015-03-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3895#issuecomment-78807805 [Test build #28548 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28548/consoleFull) for PR 3895 at commit [`3b86819`](https://gith

[GitHub] spark pull request: [SPARK-5084][SQL]add if not exists after creat...

2015-03-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3895#issuecomment-78801850 [Test build #28550 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28550/consoleFull) for PR 3895 at commit [`58bbdb3`](https://githu

[GitHub] spark pull request: [SPARK-5084][SQL]add if not exists after creat...

2015-03-12 Thread baishuo
Github user baishuo commented on a diff in the pull request: https://github.com/apache/spark/pull/3895#discussion_r26364448 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveContext.scala --- @@ -57,8 +57,10 @@ class LocalHiveContext(sc: SparkContext) extends HiveCon

[GitHub] spark pull request: [SPARK-5084][SQL]add if not exists after creat...

2015-03-12 Thread baishuo
Github user baishuo commented on the pull request: https://github.com/apache/spark/pull/3895#issuecomment-78794496 Hi guys, sorry for response this so late. I just work on trip before china new year. And I rebase the code. --- If your project is set up for it, you can reply to thi

[GitHub] spark pull request: [SPARK-5084][SQL]add if not exists after creat...

2015-03-12 Thread baishuo
Github user baishuo commented on a diff in the pull request: https://github.com/apache/spark/pull/3895#discussion_r26363950 --- Diff: sql/hive/v0.13.1/src/main/scala/org/apache/spark/sql/hive/Shim13.scala --- @@ -297,7 +297,7 @@ private[hive] object HiveShim { def getStatsSe

[GitHub] spark pull request: [SPARK-5084][SQL]add if not exists after creat...

2015-03-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3895#issuecomment-78784357 [Test build #28548 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28548/consoleFull) for PR 3895 at commit [`3b86819`](https://githu

[GitHub] spark pull request: [SPARK-5084][SQL]add if not exists after creat...

2015-01-25 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/3895#issuecomment-71410252 @baishuo Why do you want to use MySQL based metastore when running test suites? --- If your project is set up for it, you can reply to this email and have your reply a

[GitHub] spark pull request: [SPARK-5084][SQL]add if not exists after creat...

2015-01-20 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/3895#discussion_r23279095 --- Diff: sql/hive/v0.13.1/src/main/scala/org/apache/spark/sql/hive/Shim13.scala --- @@ -297,7 +297,7 @@ private[hive] object HiveShim { def getStatsSetu

[GitHub] spark pull request: [SPARK-5084][SQL]add if not exists after creat...

2015-01-20 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/3895#discussion_r23279084 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveContext.scala --- @@ -57,8 +57,10 @@ class LocalHiveContext(sc: SparkContext) extends HiveConte

[GitHub] spark pull request: [SPARK-5084][SQL]add if not exists after creat...

2015-01-14 Thread scwf
Github user scwf commented on the pull request: https://github.com/apache/spark/pull/3895#issuecomment-70046805 hey @baishuo, you should rebase this PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-5084][SQL]add if not exists after creat...

2015-01-14 Thread baishuo
Github user baishuo commented on the pull request: https://github.com/apache/spark/pull/3895#issuecomment-70046564 Hi @marmbrus ,can this PR be merged? :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] spark pull request: [SPARK-5084][SQL]add if not exists after creat...

2015-01-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3895#issuecomment-68847210 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25

[GitHub] spark pull request: [SPARK-5084][SQL]add if not exists after creat...

2015-01-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3895#issuecomment-68847206 [Test build #25095 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25095/consoleFull) for PR 3895 at commit [`1f42b8e`](https://gith

[GitHub] spark pull request: [SPARK-5084][SQL]add if not exists after creat...

2015-01-06 Thread baishuo
Github user baishuo commented on the pull request: https://github.com/apache/spark/pull/3895#issuecomment-68840957 I had modify some code and do test locally --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-5084][SQL]add if not exists after creat...

2015-01-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3895#issuecomment-68840820 [Test build #25095 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25095/consoleFull) for PR 3895 at commit [`1f42b8e`](https://githu

[GitHub] spark pull request: [SPARK-5084][SQL]add if not exists after creat...

2015-01-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3895#issuecomment-68676566 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25

[GitHub] spark pull request: [SPARK-5084][SQL]add if not exists after creat...

2015-01-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3895#issuecomment-68676564 [Test build #25050 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25050/consoleFull) for PR 3895 at commit [`1757fde`](https://gith

[GitHub] spark pull request: [SPARK-5084][SQL]add if not exists after creat...

2015-01-04 Thread baishuo
Github user baishuo commented on the pull request: https://github.com/apache/spark/pull/3895#issuecomment-68675593 some explain: if we want to use mysql instead of derby to store the metadata for spark-sql, we add the param such as "javax.jdo.option.ConnectionURL" to a hive-site.x

[GitHub] spark pull request: [SPARK-5084][SQL]add if not exists after creat...

2015-01-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3895#issuecomment-68675297 [Test build #25050 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25050/consoleFull) for PR 3895 at commit [`1757fde`](https://githu

[GitHub] spark pull request: [SPARK-5084][SQL]add if not exists after creat...

2015-01-04 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/3895#issuecomment-68675083 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] spark pull request: [SPARK-5084][SQL]add if not exists after creat...

2015-01-04 Thread baishuo
GitHub user baishuo opened a pull request: https://github.com/apache/spark/pull/3895 [SPARK-5084][SQL]add if not exists after create database-in Shim13.scala You can merge this pull request into a Git repository by running: $ git pull https://github.com/baishuo/spark SPARK-508

[GitHub] spark pull request: [SPARK-5084][SQL]add if not exists after creat...

2015-01-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3895#issuecomment-68673229 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro