Github user tianyi commented on the pull request:
https://github.com/apache/spark/pull/5730#issuecomment-100143023
@marmbrus the test issue is fixed in #5983
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user tianyi commented on the pull request:
https://github.com/apache/spark/pull/5730#issuecomment-99701707
OK, I will work on it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this f
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/5730#issuecomment-99565385
The test added here is _really_ noisy:
```
Using Spark's default log4j profile:
org/apache/spark/log4j-defaults.properties
15/04/29 01:59:46 INFO UISelen
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/5730
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/5730#issuecomment-98640818
LGTM, merging to master. Thanks for working on this!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5730#issuecomment-97319569
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5730#issuecomment-97324368
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/312
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5730#issuecomment-97328481
[Test build #31256 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31256/consoleFull)
for PR 5730 at commit
[`cfd14c7`](https://githu
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5730#issuecomment-97319612
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user tianyi commented on the pull request:
https://github.com/apache/spark/pull/5730#issuecomment-97374381
@liancheng The test codes and is ready to review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5730#issuecomment-97324367
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5730#issuecomment-97328328
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5730#issuecomment-97328344
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5730#issuecomment-97371745
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/312
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5730#issuecomment-97324366
[Test build #31254 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31254/consoleFull)
for PR 5730 at commit
[`0efe3d5`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5730#issuecomment-97319823
[Test build #31254 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31254/consoleFull)
for PR 5730 at commit
[`0efe3d5`](https://githu
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5730#issuecomment-97371741
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5730#issuecomment-97371709
[Test build #31256 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31256/consoleFull)
for PR 5730 at commit
[`cfd14c7`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5730#issuecomment-96988229
[Test build #31132 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31132/consoleFull)
for PR 5730 at commit
[`aa20408`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5730#issuecomment-96968035
[Test build #31132 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31132/consoleFull)
for PR 5730 at commit
[`aa20408`](https://githu
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5730#issuecomment-96965368
[Test build #31129 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31129/consoleFull)
for PR 5730 at commit
[`8809157`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5730#issuecomment-96963419
[Test build #31128 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31128/consoleFull)
for PR 5730 at commit
[`c9df6f9`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5730#issuecomment-96956692
[Test build #31129 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31129/consoleFull)
for PR 5730 at commit
[`8809157`](https://githu
Github user tianyi commented on the pull request:
https://github.com/apache/spark/pull/5730#issuecomment-96956131
@JoshRosen I just add some test for thrift server UI. But I'm not sure if I
need to add test cases for all the feature. Any suggestion?
---
If your project is set up for
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5730#issuecomment-96955450
[Test build #31128 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31128/consoleFull)
for PR 5730 at commit
[`c9df6f9`](https://githu
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/5730#issuecomment-96913392
This generally looks good, left some comments, most are about styling
issues.
@JoshRosen Would you mind to double check the web UI changes? This should
be gene
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/5730#discussion_r29214768
--- Diff:
sql/hive-thriftserver/v0.13.1/src/main/scala/org/apache/spark/sql/hive/thriftserver/Shim13.scala
---
@@ -227,11 +236,14 @@ private[hive] class
S
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/5730#discussion_r29214771
--- Diff:
sql/hive-thriftserver/v0.13.1/src/main/scala/org/apache/spark/sql/hive/thriftserver/Shim13.scala
---
@@ -227,11 +236,14 @@ private[hive] class
S
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/5730#discussion_r29214742
--- Diff:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerSessionPage.scala
---
@@ -0,0 +1,197 @@
+/*
+
Github user tianyi commented on the pull request:
https://github.com/apache/spark/pull/5730#issuecomment-96908252
@WangTaoTheTonic , the Thrift Server's driver UI you mentioned is a
universal UI for all kinds of work on spark, and mainly focus on jobs, stages
and tasks.
In this P
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/5730#discussion_r29213643
--- Diff:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerPage.scala
---
@@ -0,0 +1,189 @@
+/*
+ * Licen
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/5730#discussion_r29213610
--- Diff:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerPage.scala
---
@@ -0,0 +1,189 @@
+/*
+ * Licen
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/5730#discussion_r29213358
--- Diff:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerPage.scala
---
@@ -0,0 +1,189 @@
+/*
+ * Licen
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/5730#discussion_r29212930
--- Diff:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2.scala
---
@@ -73,15 +94,146 @@ object HiveThriftSer
Github user WangTaoTheTonic commented on the pull request:
https://github.com/apache/spark/pull/5730#issuecomment-96902704
Sorry for not follow the previous comments but could you tell the
difference between this tab and Thrift Server's driver UI?
Once this is added, will Thrift Se
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/5730#discussion_r29212594
--- Diff:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2.scala
---
@@ -73,15 +94,146 @@ object HiveThriftSer
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/5730#discussion_r29212588
--- Diff:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2.scala
---
@@ -73,15 +94,146 @@ object HiveThriftSer
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/5730#discussion_r29212502
--- Diff:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2.scala
---
@@ -73,15 +94,146 @@ object HiveThriftSer
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/5730#discussion_r29211781
--- Diff:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2.scala
---
@@ -73,15 +94,146 @@ object HiveThriftSer
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/5730#discussion_r29211792
--- Diff:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2.scala
---
@@ -73,15 +94,146 @@ object HiveThriftSer
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/5730#discussion_r29211717
--- Diff:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2.scala
---
@@ -73,15 +94,146 @@ object HiveThriftSer
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5730#issuecomment-96895450
[Test build #31097 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31097/consoleFull)
for PR 5730 at commit
[`9830199`](https://gith
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/5730#discussion_r29211503
--- Diff:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2.scala
---
@@ -73,15 +94,146 @@ object HiveThriftSer
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/5730#discussion_r29211457
--- Diff:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2.scala
---
@@ -73,15 +94,146 @@ object HiveThriftSer
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/5730#discussion_r29211406
--- Diff:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2.scala
---
@@ -73,15 +94,146 @@ object HiveThriftSer
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/5730#discussion_r29211392
--- Diff:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2.scala
---
@@ -73,15 +94,146 @@ object HiveThriftSer
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/5730#discussion_r29211337
--- Diff:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2.scala
---
@@ -73,15 +94,146 @@ object HiveThriftSer
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/5730#discussion_r29211340
--- Diff:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2.scala
---
@@ -73,15 +94,146 @@ object HiveThriftSer
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/5730#discussion_r29211295
--- Diff:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2.scala
---
@@ -73,15 +94,146 @@ object HiveThriftSer
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/5730#discussion_r29211143
--- Diff:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2.scala
---
@@ -73,15 +94,146 @@ object HiveThriftSer
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/5730#discussion_r29211137
--- Diff:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2.scala
---
@@ -73,15 +94,146 @@ object HiveThriftSer
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5730#issuecomment-96871978
[Test build #31097 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31097/consoleFull)
for PR 5730 at commit
[`9830199`](https://githu
52 matches
Mail list logo
