[GitHub] spark pull request: [SPARK-5223] [MLlib] [PySpark] fix MapConverte...

2015-01-14 Thread FlytxtRnD
Github user FlytxtRnD commented on the pull request: https://github.com/apache/spark/pull/4023#issuecomment-70040193 Ok. Thanks for the explanation. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-5223] [MLlib] [PySpark] fix MapConverte...

2015-01-14 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/4023#issuecomment-70039829 If obj is [], ListConverter() will work. If obj is a list of JavaObject, then obj can not be serialized, because JavaObject can not be serialized. ListConverter() can help

[GitHub] spark pull request: [SPARK-5223] [MLlib] [PySpark] fix MapConverte...

2015-01-14 Thread FlytxtRnD
Github user FlytxtRnD commented on the pull request: https://github.com/apache/spark/pull/4023#issuecomment-70038625 @davies Could you please explain why the second clause of this condition is added? ```elif isinstance(obj, list) and (obj or isinstance(obj[0],

[GitHub] spark pull request: [SPARK-5223] [MLlib] [PySpark] fix MapConverte...

2015-01-13 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/4023#issuecomment-69817385 LGTM. Merged into master and branch-1.2. Thanks for explaining the problem! --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-5223] [MLlib] [PySpark] fix MapConverte...

2015-01-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/4023 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-5223] [MLlib] [PySpark] fix MapConverte...

2015-01-13 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/4023#issuecomment-69816419 It did not have problems right now, some one hit this while working on other algorithms/API, see http://apache-spark-developers-list.1001551.n3.nabble.com/Python-to-Java-o

[GitHub] spark pull request: [SPARK-5223] [MLlib] [PySpark] fix MapConverte...

2015-01-13 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/4023#issuecomment-69813804 @davies Could you provide an example to produce the bug and turn it into a unit test? --- If your project is set up for it, you can reply to this email and have your repl

[GitHub] spark pull request: [SPARK-5223] [MLlib] [PySpark] fix MapConverte...

2015-01-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4023#issuecomment-69807204 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25

[GitHub] spark pull request: [SPARK-5223] [MLlib] [PySpark] fix MapConverte...

2015-01-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4023#issuecomment-69807194 [Test build #25478 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25478/consoleFull) for PR 4023 at commit [`55d4ab2`](https://gith

[GitHub] spark pull request: [SPARK-5223] [MLlib] [PySpark] fix MapConverte...

2015-01-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4023#issuecomment-69794861 [Test build #25478 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25478/consoleFull) for PR 4023 at commit [`55d4ab2`](https://githu

[GitHub] spark pull request: [SPARK-5223] [MLlib] [PySpark] fix MapConverte...

2015-01-13 Thread davies
GitHub user davies opened a pull request: https://github.com/apache/spark/pull/4023 [SPARK-5223] [MLlib] [PySpark] fix MapConverter and ListConverter in MLlib It will introduce problems if the object in dict/list/tuple can not support by py4j, such as Vector. Also, pickle may ha