Github user OopsOutOfMemory closed the pull request at:
https://github.com/apache/spark/pull/4060
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user OopsOutOfMemory commented on the pull request:
https://github.com/apache/spark/pull/4060#issuecomment-98597077
OK, Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fea
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4060#issuecomment-96769804
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/4060#issuecomment-89094249
Thanks again for working on this. However, to keep the PR queue small, I
propose we close this issue until you have time to update it.
---
If your project is set up fo
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/4060#discussion_r26333135
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/sources/ddl.scala ---
@@ -328,6 +335,33 @@ private [sql] case class CreateTempTableUsingAsSelect(
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/4060#discussion_r2650
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/sources/ddl.scala ---
@@ -328,6 +335,33 @@ private [sql] case class CreateTempTableUsingAsSelect(
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/4060#discussion_r2604
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/sources/ddl.scala ---
@@ -328,6 +335,33 @@ private [sql] case class CreateTempTableUsingAsSelect(
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/4060#issuecomment-78569754
Thanks for working on this! Please merge with master and eliminate
conflicts.
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/4060#discussion_r26333439
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveStrategies.scala ---
@@ -244,6 +244,10 @@ private[hive] trait HiveStrategies {
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/4060#discussion_r26333184
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/sources/ddl.scala ---
@@ -328,6 +335,33 @@ private [sql] case class CreateTempTableUsingAsSelect(
Github user OopsOutOfMemory commented on the pull request:
https://github.com/apache/spark/pull/4060#issuecomment-73202418
yeah, I use a single logical operator here.
If handle the type of the table and then delegate.
Is that ok to do like below? we need catch exceptions in stra
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4060#issuecomment-72915694
[Test build #26764 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26764/consoleFull)
for PR 4060 at commit
[`e7299aa`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4060#issuecomment-72915703
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26
Github user OopsOutOfMemory commented on a diff in the pull request:
https://github.com/apache/spark/pull/4060#discussion_r24102921
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/sources/ddl.scala ---
@@ -231,6 +241,32 @@ private [sql] case class CreateTempTableUsing(
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4060#issuecomment-72902442
[Test build #26764 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26764/consoleFull)
for PR 4060 at commit
[`e7299aa`](https://githu
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/4060#discussion_r23970286
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/sources/ddl.scala ---
@@ -231,6 +241,32 @@ private [sql] case class CreateTempTableUsing(
}
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/4060#discussion_r23969817
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala ---
@@ -33,8 +33,9 @@ import org.apache.spark.sql.catalyst.plans._
import org.ap
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4060#issuecomment-72490610
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4060#issuecomment-72490599
[Test build #26517 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26517/consoleFull)
for PR 4060 at commit
[`b7146cc`](https://gith
Github user OopsOutOfMemory commented on a diff in the pull request:
https://github.com/apache/spark/pull/4060#discussion_r23932366
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/sources/ddl.scala ---
@@ -231,6 +241,32 @@ private [sql] case class CreateTempTableUsing(
Github user OopsOutOfMemory commented on the pull request:
https://github.com/apache/spark/pull/4060#issuecomment-72478581
Updated.
/cc @marmbrus @yhuai @liancheng
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If y
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4060#issuecomment-72477382
[Test build #26517 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26517/consoleFull)
for PR 4060 at commit
[`b7146cc`](https://githu
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4060#issuecomment-72433231
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4060#issuecomment-72433225
[Test build #26507 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26507/consoleFull)
for PR 4060 at commit
[`00ecc25`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4060#issuecomment-72431971
[Test build #26505 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26505/consoleFull)
for PR 4060 at commit
[`998eb3b`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4060#issuecomment-72431978
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4060#issuecomment-72429548
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4060#issuecomment-72428327
[Test build #26507 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26507/consoleFull)
for PR 4060 at commit
[`00ecc25`](https://githu
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4060#issuecomment-72427107
[Test build #26505 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26505/consoleFull)
for PR 4060 at commit
[`998eb3b`](https://githu
Github user OopsOutOfMemory commented on a diff in the pull request:
https://github.com/apache/spark/pull/4060#discussion_r23841357
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/sources/ddl.scala ---
@@ -231,6 +241,32 @@ private [sql] case class CreateTempTableUsing(
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/4060#discussion_r23797723
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveStrategies.scala ---
@@ -230,7 +232,8 @@ private[hive] trait HiveStrategies {
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/4060#discussion_r23797651
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala ---
@@ -454,7 +455,8 @@
https://cwiki.apache.org/confluence/display/Hive/Enhanced+A
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/4060#discussion_r23796841
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/sources/TableScanSuite.scala ---
@@ -315,6 +315,33 @@ class TableScanSuite extends DataSourceTest {
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/4060#discussion_r23796642
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
@@ -321,6 +321,12 @@ private[sql] abstract class SparkStrategies
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/4060#discussion_r23796446
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/sources/ddl.scala ---
@@ -231,6 +241,32 @@ private [sql] case class CreateTempTableUsing(
}
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/4060#discussion_r23796095
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/sources/ddl.scala ---
@@ -231,6 +241,32 @@ private [sql] case class CreateTempTableUsing(
}
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/4060#discussion_r23796102
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/sources/ddl.scala ---
@@ -231,6 +241,32 @@ private [sql] case class CreateTempTableUsing(
}
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/4060#discussion_r23795979
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
@@ -321,6 +321,12 @@ private[sql] abstract class SparkStrategies
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/4060#discussion_r23795876
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/sources/ddl.scala ---
@@ -78,10 +81,17 @@ private[sql] class DDLParser extends
AbstractSparkSQLParser
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4060#issuecomment-72008423
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4060#issuecomment-72008420
[Test build #26311 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26311/consoleFull)
for PR 4060 at commit
[`f047fda`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4060#issuecomment-72004787
[Test build #26309 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26309/consoleFull)
for PR 4060 at commit
[`43ae1da`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4060#issuecomment-72004795
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4060#issuecomment-72003064
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4060#issuecomment-72003056
[Test build #26306 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26306/consoleFull)
for PR 4060 at commit
[`e6f836b`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4060#issuecomment-71999238
[Test build #26311 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26311/consoleFull)
for PR 4060 at commit
[`f047fda`](https://githu
Github user OopsOutOfMemory commented on the pull request:
https://github.com/apache/spark/pull/4060#issuecomment-71998834
/cc @marmbrus
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this f
Github user OopsOutOfMemory commented on the pull request:
https://github.com/apache/spark/pull/4060#issuecomment-71996144
Hi, @liancheng
Would you mind review this ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4060#issuecomment-71995053
[Test build #26309 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26309/consoleFull)
for PR 4060 at commit
[`43ae1da`](https://githu
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4060#issuecomment-71989281
[Test build #26306 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26306/consoleFull)
for PR 4060 at commit
[`e6f836b`](https://githu
50 matches
Mail list logo
