[GitHub] spark pull request: [SPARK-5277][SQL] - SparkSqlSerializer doesn't...

2015-04-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/5237 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-5277][SQL] - SparkSqlSerializer doesn't...

2015-04-15 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/5237#issuecomment-93594809 Manually fixed conflicts while merging with master. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

[GitHub] spark pull request: [SPARK-5277][SQL] - SparkSqlSerializer doesn't...

2015-04-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5237#issuecomment-93110412 [Test build #30279 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30279/consoleFull) for PR 5237 at commit [`3175c2f`](https://gith

[GitHub] spark pull request: [SPARK-5277][SQL] - SparkSqlSerializer doesn't...

2015-04-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5237#issuecomment-93110441 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30

[GitHub] spark pull request: [SPARK-5277][SQL] - SparkSqlSerializer doesn't...

2015-04-14 Thread mhseiden
Github user mhseiden commented on the pull request: https://github.com/apache/spark/pull/5237#issuecomment-93077853 @yhuai - The Limit case is covered as well. @marmbrus - Not a problem! My most recent PR addresses your comments. Is this a change that could be backported to 1.

[GitHub] spark pull request: [SPARK-5277][SQL] - SparkSqlSerializer doesn't...

2015-04-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5237#issuecomment-93076044 [Test build #30279 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30279/consoleFull) for PR 5237 at commit [`3175c2f`](https://githu

[GitHub] spark pull request: [SPARK-5277][SQL] - SparkSqlSerializer doesn't...

2015-04-13 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/5237#issuecomment-92485811 Seems `new SparkSqlSerializer(new SparkConf(false))` is also used in `org.apache.spark.sql.execution.Limit`. Can you fix that as well? --- If your project is set up for it

[GitHub] spark pull request: [SPARK-5277][SQL] - SparkSqlSerializer doesn't...

2015-04-11 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/5237#issuecomment-91955687 Thanks for working on this. This LGTM with two minor comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-5277][SQL] - SparkSqlSerializer doesn't...

2015-04-11 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/5237#discussion_r28199691 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/columnar/ColumnTypeSuite.scala --- @@ -229,3 +267,23 @@ class ColumnTypeSuite extends FunSuite with Lo

[GitHub] spark pull request: [SPARK-5277][SQL] - SparkSqlSerializer doesn't...

2015-04-11 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/5237#discussion_r28199689 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/Exchange.scala --- @@ -46,6 +46,7 @@ case class Exchange(newPartitioning: Partitioning, chil

[GitHub] spark pull request: [SPARK-5277][SQL] - SparkSqlSerializer doesn't...

2015-04-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5237#issuecomment-91953138 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30

[GitHub] spark pull request: [SPARK-5277][SQL] - SparkSqlSerializer doesn't...

2015-04-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5237#issuecomment-91953132 [Test build #30093 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30093/consoleFull) for PR 5237 at commit [`e5011fb`](https://gith

[GitHub] spark pull request: [SPARK-5277][SQL] - SparkSqlSerializer doesn't...

2015-04-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5237#issuecomment-91937795 [Test build #30093 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30093/consoleFull) for PR 5237 at commit [`e5011fb`](https://githu

[GitHub] spark pull request: [SPARK-5277][SQL] - SparkSqlSerializer doesn't...

2015-04-11 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/5237#issuecomment-91937365 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] spark pull request: [SPARK-5277][SQL] - SparkSqlSerializer doesn't...

2015-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5237#issuecomment-87183235 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] spark pull request: [SPARK-5277][SQL] - SparkSqlSerializer doesn't...

2015-03-28 Thread mhseiden
GitHub user mhseiden opened a pull request: https://github.com/apache/spark/pull/5237 [SPARK-5277][SQL] - SparkSqlSerializer doesn't always register user specified KryoRegistrators [SPARK-5277][SQL] - SparkSqlSerializer doesn't always register user specified KryoRegistrators