Github user nchammas commented on the pull request:
https://github.com/apache/spark/pull/4162#issuecomment-73435450
Thank you @Liuchang0812 for working on this!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proj
Github user Liuchang0812 commented on the pull request:
https://github.com/apache/spark/pull/4162#issuecomment-73369125
:) thanks @srowen
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/4162#issuecomment-73368543
Looks like everyone is cool with this, and it passes all tests. I can merge
shortly if there are no objections.
---
If your project is set up for it, you can reply to thi
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/4162
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user nchammas commented on the pull request:
https://github.com/apache/spark/pull/4162#issuecomment-73378772
I had one final minor comment, but otherwise LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
Github user nchammas commented on a diff in the pull request:
https://github.com/apache/spark/pull/4162#discussion_r24291969
--- Diff: ec2/spark_ec2.py ---
@@ -1003,6 +1006,18 @@ def real_main():
DeprecationWarning
)
+if opts.identity_file
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4162#issuecomment-73396904
[Test build #27029 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27029/consoleFull)
for PR 4162 at commit
[`fc37355`](https://githu
Github user Liuchang0812 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4162#discussion_r24295815
--- Diff: ec2/spark_ec2.py ---
@@ -1003,6 +1006,18 @@ def real_main():
DeprecationWarning
)
+if opts.identity_
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4162#issuecomment-73398401
[Test build #27029 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27029/consoleFull)
for PR 4162 at commit
[`fc37355`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4162#issuecomment-73398404
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4162#issuecomment-73304383
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4162#issuecomment-73304375
[Test build #26924 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26924/consoleFull)
for PR 4162 at commit
[`01ed464`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4162#issuecomment-73292357
[Test build #26924 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26924/consoleFull)
for PR 4162 at commit
[`01ed464`](https://githu
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/4162#issuecomment-73291745
Jenkins, this is ok to test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
Github user nchammas commented on the pull request:
https://github.com/apache/spark/pull/4162#issuecomment-73291572
One final comment @Liuchang0812 and I think this is good to go.
@shivaram Can you have Jenkins trigger tests? I don't believe I have that
permission.
---
If yo
Github user nchammas commented on a diff in the pull request:
https://github.com/apache/spark/pull/4162#discussion_r24262082
--- Diff: ec2/spark_ec2.py ---
@@ -1003,6 +1006,18 @@ def real_main():
DeprecationWarning
)
+if opts.identity_file
Github user Liuchang0812 commented on the pull request:
https://github.com/apache/spark/pull/4162#issuecomment-73288219
@shivaram :) thanks for your suggestion. I'm very glad to contribute to
spark.
---
If your project is set up for it, you can reply to this email and have your
repl
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/4162#issuecomment-73285601
Thanks @Liuchang0812 - LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user Liuchang0812 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4162#discussion_r24229266
--- Diff: ec2/spark_ec2.py ---
@@ -1003,6 +1006,17 @@ def real_main():
DeprecationWarning
)
+if opts.identity_
Github user nchammas commented on a diff in the pull request:
https://github.com/apache/spark/pull/4162#discussion_r24211576
--- Diff: ec2/spark_ec2.py ---
@@ -1003,6 +1006,17 @@ def real_main():
DeprecationWarning
)
+if opts.identity_file
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/4162#issuecomment-73152636
This is a pretty useful change - Can we print a message on how programmers
can fix this ? AFAIK spark-ec2 only works on Mac/Linux, so we can just say that
'Please run ch
Github user nchammas commented on the pull request:
https://github.com/apache/spark/pull/4162#issuecomment-73150514
@pwendell / @shivaram - What's your take on this?
I think its a minor but non-trivial usability improvement that we should
take.
---
If your project is set up
Github user nchammas commented on the pull request:
https://github.com/apache/spark/pull/4162#issuecomment-72223944
OK, LGTM pending Python style tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user Liuchang0812 commented on the pull request:
https://github.com/apache/spark/pull/4162#issuecomment-72235154
ubuntu@ip-172-31-24-113:~/spark/ec2$ ../dev/lint-python
PEP 8 checks passed.
---
If your project is set up for it, you can reply to this email and have yo
Github user Liuchang0812 commented on the pull request:
https://github.com/apache/spark/pull/4162#issuecomment-72190513
@nchammas Done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fea
Github user nchammas commented on the pull request:
https://github.com/apache/spark/pull/4162#issuecomment-72114356
> Should we just be propagating the SSH message rather than trying to
duplicate logic here?
Absolutely. That's being done in #4262.
That said, it's stil
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/4162#issuecomment-72113135
Hey on this one - doesn't ssh itself give a good error message if the key
file does not have the correct permissions? Should we just be propagating the
SSH message rathe
Github user nchammas commented on the pull request:
https://github.com/apache/spark/pull/4162#issuecomment-72088000
OK, I think we're almost there. One final suggestion I'd make it to move
these checks on the identity file to the [input parameter validation
area](https://github.com/Li
Github user nchammas commented on a diff in the pull request:
https://github.com/apache/spark/pull/4162#discussion_r23794983
--- Diff: ec2/spark_ec2.py ---
@@ -349,6 +351,17 @@ def launch_cluster(conn, opts, cluster_name):
if opts.identity_file is None:
print >
Github user Liuchang0812 commented on the pull request:
https://github.com/apache/spark/pull/4162#issuecomment-72068788
Yesï¼ I have tested it with some private keysãThe check can pass iff
only owner has read permissionã
---
If your project is set up for it, you can reply to thi
Github user nchammas commented on the pull request:
https://github.com/apache/spark/pull/4162#issuecomment-72064539
No problem @Liuchang0812. Did you test your latest changes to make sure
they work as expected?
---
If your project is set up for it, you can reply to this email and hav
Github user Liuchang0812 commented on the pull request:
https://github.com/apache/spark/pull/4162#issuecomment-72020501
@nchammas
Thanks for your reviewing. You are so helful and nice.
I'm very sorry for the mistake.
---
If your project is set up for it, you can reply to th
Github user nchammas commented on a diff in the pull request:
https://github.com/apache/spark/pull/4162#discussion_r23629383
--- Diff: ec2/spark_ec2.py ---
@@ -349,6 +351,16 @@ def launch_cluster(conn, opts, cluster_name):
if opts.identity_file is None:
print >
Github user nchammas commented on a diff in the pull request:
https://github.com/apache/spark/pull/4162#discussion_r23627130
--- Diff: ec2/spark_ec2.py ---
@@ -349,6 +351,16 @@ def launch_cluster(conn, opts, cluster_name):
if opts.identity_file is None:
print >
Github user nchammas commented on a diff in the pull request:
https://github.com/apache/spark/pull/4162#discussion_r23626906
--- Diff: ec2/spark_ec2.py ---
@@ -349,6 +351,16 @@ def launch_cluster(conn, opts, cluster_name):
if opts.identity_file is None:
print >
Github user nchammas commented on a diff in the pull request:
https://github.com/apache/spark/pull/4162#discussion_r23626504
--- Diff: ec2/spark_ec2.py ---
@@ -349,6 +351,16 @@ def launch_cluster(conn, opts, cluster_name):
if opts.identity_file is None:
print >
Github user nchammas commented on a diff in the pull request:
https://github.com/apache/spark/pull/4162#discussion_r23626017
--- Diff: ec2/spark_ec2.py ---
@@ -24,10 +24,12 @@
import hashlib
import logging
import os
+import os.path
import pipes
import ra
Github user Liuchang0812 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4162#discussion_r23504896
--- Diff: ec2/spark_ec2.py ---
@@ -349,6 +350,15 @@ def launch_cluster(conn, opts, cluster_name):
if opts.identity_file is None:
pri
Github user Liuchang0812 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4162#discussion_r23504693
--- Diff: ec2/spark_ec2.py ---
@@ -349,6 +350,15 @@ def launch_cluster(conn, opts, cluster_name):
if opts.identity_file is None:
pri
Github user Liuchang0812 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4162#discussion_r23504683
--- Diff: ec2/spark_ec2.py ---
@@ -349,6 +350,15 @@ def launch_cluster(conn, opts, cluster_name):
if opts.identity_file is None:
pri
Github user nchammas commented on a diff in the pull request:
https://github.com/apache/spark/pull/4162#discussion_r23499969
--- Diff: ec2/spark_ec2.py ---
@@ -349,6 +350,15 @@ def launch_cluster(conn, opts, cluster_name):
if opts.identity_file is None:
print >
Github user nchammas commented on a diff in the pull request:
https://github.com/apache/spark/pull/4162#discussion_r23499848
--- Diff: ec2/spark_ec2.py ---
@@ -349,6 +350,15 @@ def launch_cluster(conn, opts, cluster_name):
if opts.identity_file is None:
print >
Github user nchammas commented on a diff in the pull request:
https://github.com/apache/spark/pull/4162#discussion_r23499744
--- Diff: ec2/spark_ec2.py ---
@@ -349,6 +350,15 @@ def launch_cluster(conn, opts, cluster_name):
if opts.identity_file is None:
print >
Github user Liuchang0812 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4162#discussion_r23446495
--- Diff: ec2/spark_ec2.py ---
@@ -346,9 +347,15 @@ def get_spark_ami(opts):
# Returns a tuple of EC2 reservation objects for the master and slaves
Github user nchammas commented on a diff in the pull request:
https://github.com/apache/spark/pull/4162#discussion_r23421637
--- Diff: ec2/spark_ec2.py ---
@@ -346,9 +347,15 @@ def get_spark_ami(opts):
# Returns a tuple of EC2 reservation objects for the master and slaves
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4162#issuecomment-71035537
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
GitHub user Liuchang0812 opened a pull request:
https://github.com/apache/spark/pull/4162
[SPARK-5366][EC2] Check the mode of private key
Check the mode of private key file.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Liuchang
47 matches
Mail list logo
